Ignoring Emacs temp files

When you're editing a buffer in emacs, it will create a
temporary symlink 
in the same directory of the file in the form
".#<filename>".

Since these have the same .pm ending as normal modules,
Catalyst will 
attempt to load them on startup, and they get included in
the watch list 
for the restarting HTTP server. I've attached two patches to
tighten up 
the regexes involved so as to avoid this problem.

The first is for Catalyst.pm itself. When using
Module::Pluggable::Object, 
it passes a regex to ignore any class name that include
".#", which isn't 
a valid Perl class name anyway (this could be further
tightened to really 
only accept valid class names).

The Other is for Catalyst:evel,
and it tweaks the $restart_regex in the 
foo_server.pl script it generates. It basically excludes any
path that 
has ".#" at the beginning of the filename or after
a slash.


-dave

/*===================================================
VegGuide.Org                        www.BookIRead.com
Your guide to all that's veg.       My book blog
===================================================*/
_______________________________________________
Catalyst-dev mailing list
Catalyst-devlists.rawmode.org
http://lists.rawmode.org/mailman/listinfo/catalyst-dev

Applied (changeset 6741 and 6742 - don't ask) , thanks 

On 27/08/07, Dave Rolsky <autarchurth.org> wrote:
> When you're editing a buffer in emacs, it will create a
temporary symlink
> in the same directory of the file in the form
".#<filename>".
>
> Since these have the same .pm ending as normal modules,
Catalyst will
> attempt to load them on startup, and they get included
in the watch list
> for the restarting HTTP server. I've attached two
patches to tighten up
> the regexes involved so as to avoid this problem.
>
> The first is for Catalyst.pm itself. When using
Module::Pluggable::Object,
> it passes a regex to ignore any class name that include
".#", which isn't
> a valid Perl class name anyway (this could be further
tightened to really
> only accept valid class names).
>
> The Other is for Catalyst:evel,
and it tweaks the $restart_regex in the
> foo_server.pl script it generates. It basically
excludes any path that
> has ".#" at the beginning of the filename or
after a slash.
>
>
> -dave
>
> /*===================================================
> VegGuide.Org                        www.BookIRead.com
> Your guide to all that's veg.       My book blog
> ===================================================*/
> _______________________________________________
> Catalyst-dev mailing list
> Catalyst-devlists.rawmode.org
> http://lists.rawmode.org/mailman/listinfo/catalyst-dev

>
>
>

_______________________________________________
Catalyst-dev mailing list
Catalyst-devlists.rawmode.org
http://lists.rawmode.org/mailman/listinfo/catalyst-dev

Kieren Diment wrote:
> Applied (changeset 6741 and 6742 - don't ask) , thanks

>
> On 27/08/07, Dave Rolsky <autarchurth.org> wrote:
>   
>> When you're editing a buffer in emacs, it will
create a temporary symlink
>> in the same directory of the file in the form
".#<filename>".
Thanks kd++ and autarch++   This has
been an open issue for over a
year because we've been waiting for users to compile a list
for every
editor and patch MPO accordingly.  I only use emacs, so all
I could
provide was similar to Dave's patch.  With this applied, I
am happy 

Users of other editors: we weren't kidding when we asked you
for regexes
that exclude your editor's cruft files.  They all do it, but
I don't
have any of them so I don't know what the files are.  Please
send data.

Regards,
Jonathan Rockway


_______________________________________________
Catalyst-dev mailing list
Catalyst-devlists.rawmode.org
http://lists.rawmode.org/mailman/listinfo/catalyst-dev

On Tue, 28 Aug 2007, Jonathan Rockway wrote:

>>> When you're editing a buffer in emacs, it will
create a temporary symlink
>>> in the same directory of the file in the form
".#<filename>".
>
> Thanks kd++ and autarch++   This has
been an open issue for over a
> year because we've been waiting for users to compile a
list for every
> editor and patch MPO accordingly.  I only use emacs, so
all I could
> provide was similar to Dave's patch.  With this
applied, I am happy 

Ronald Kimball pointed out (off-list) that my patch for the
helper script 
will also catch things like ".#dir/file.pm".
That's not exactly what I 
intended, but on the other hand why would we want to include
that?

He suggested this:

  ^(?!.#)[^/]*(?:/(?!.#)[^/]*)*(?:.yml$|.yaml$|.pm)$

I think that's correct. This would all be much simpler if we
could run the 
regex against just the file name.


-dave

/*===================================================
VegGuide.Org                        www.BookIRead.com
Your guide to all that's veg.       My book blog
===================================================*/

_______________________________________________
Catalyst-dev mailing list
Catalyst-devlists.rawmode.org
http://lists.rawmode.org/mailman/listinfo/catalyst-dev

On Mon, Aug 27, 2007 at 11:33:07PM +1000, Kieren Diment
wrote:
> Applied (changeset 6741 and 6742 - don't ask) , thanks


Revert the M::P::O change please.

That needs to go upstream to the Module::Pluggable
maintainer.

He's already said he'll take a patch, we're just waiting for
somebody to
actually bother sending him one.

-- 
      Matt S Trout       Need help with your Catalyst or
DBIx::Class project?
   Technical Director    Want a managed development or
deployment platform?
 Shadowcat Systems Ltd.  Contact mst (at)
shadowcatsystems.co.uk for a quote
http://chainsawblues.vo
x.com/                    http://www.shadowcat.co.u
k/ 

_______________________________________________
Catalyst-dev mailing list
Catalyst-devlists.rawmode.org
http://lists.rawmode.org/mailman/listinfo/catalyst-dev