Heartbeat 2.0.8 spec file patch

To get heartbeat 2.0.8 to build successfully for me on
CentOS5, I needed to add a few BuildRequires to the spec
file.  

matt


--- heartbeat.spec-orig 2007-05-21 15:45:57.000000000 -0700
+++ heartbeat.spec      2007-05-21 16:14:14.000000000 -0700
 -8,7
+8,7 
 Summary: heartbeat - The Heartbeat Subsystem for
High-Availability Linux
 Name:  heartbeat
 Version:       2.0.8
-Release:       3%{?dist}
+Release:       4%{?dist}
 License: GPL/LGPL
 URL: http://linux-ha.org/
 Group: Utilities
 -21,7
+21,7 
 BuildPrereq: glib-devel, perl, iputils, /usr/bin/ssh,
openssl-devel, libnet
 # libnet available from www.ultramonkey.org and others
 Requires: sysklogd, heartbeat-stonith =
%-%, heartbeat-pils =
%-%
-BuildRequires: libgcrypt-devel, lm_sensors-devel,
net-snmp-devel
+BuildRequires: libgcrypt-devel, lm_sensors-devel,
net-snmp-devel, glib2-devel, python-devel, pam-devel,
gnutls-devel, curses-devel
 
 %package ldirectord
 Summary: Monitor daemon for maintaining high availability
resources
 -96,6
+96,10 
 %endif
 
 %changelog
+* Mon May 21 2007  Matt Albright <mattalbrightyahoo.com>
+- added glib2-devel, python-devel, pam-devel, gnutls-devel
and curses-devel as
+  build requirements
+
 * Sun May 13 2007  Johnny Hughes <johnnycentos.org>
 - added net-snmp-devel as a build requirement
 - fixed an error in 'ipmilan.c' function
'ipmilan_set_config' that prevents

_______________________________________________
CentOS-devel mailing list
CentOS-develcentos.org
http://lists.centos.org/mailman/listinfo/centos-devel

On Mon, 21 May 2007, Matthew Albright wrote:

> To get heartbeat 2.0.8 to build successfully for me on
CentOS5, I needed to add a few BuildRequires to the spec
file.
...
>  -21,7 +21,7 
> BuildPrereq: glib-devel, perl, iputils, /usr/bin/ssh,
openssl-devel, libnet
> # libnet available from www.ultramonkey.org and others
> Requires: sysklogd, heartbeat-stonith =
%-%, heartbeat-pils =
%-%
> -BuildRequires: libgcrypt-devel, lm_sensors-devel,
net-snmp-devel
> +BuildRequires: libgcrypt-devel, lm_sensors-devel,
net-snmp-devel, glib2-devel, python-devel, pam-devel,
gnutls-devel, curses-devel

I'd suggest that you list those as:

> +BuildRequires: glib2-devel
> +BuildRequires: python-devel
> +BuildRequires: pam-devel
> +BuildRequires: gnutls-devel
> +BuildRequires: ncurses-devel

Makes for much more readable diffs.
_______________________________________________
CentOS-devel mailing list
CentOS-develcentos.org
http://lists.centos.org/mailman/listinfo/centos-devel

On Mon, 2007-05-21 at 21:52 -0400, Charlie Brady wrote:
> On Mon, 21 May 2007, Matthew Albright wrote:
> 
> > To get heartbeat 2.0.8 to build successfully for
me on CentOS5, I needed to add a few BuildRequires to the
spec file.
> ...
> >  -21,7 +21,7 
> > BuildPrereq: glib-devel, perl, iputils,
/usr/bin/ssh, openssl-devel, libnet
> > # libnet available from www.ultramonkey.org and
others
> > Requires: sysklogd, heartbeat-stonith =
%-%, heartbeat-pils =
%-%
> > -BuildRequires: libgcrypt-devel, lm_sensors-devel,
net-snmp-devel
> > +BuildRequires: libgcrypt-devel, lm_sensors-devel,
net-snmp-devel, glib2-devel, python-devel, pam-devel,
gnutls-devel, curses-devel
> 

I do need to build these in mock and analyze for hidden
build
requirements.  I apologize for not doing so, but it is
something I
intend to do for all packages in CentOS-Extras / Plus.  I'm
sure you
have found all of those for heartbeat, thanks.

> I'd suggest that you list those as:
> 
> > +BuildRequires: glib2-devel
> > +BuildRequires: python-devel
> > +BuildRequires: pam-devel
> > +BuildRequires: gnutls-devel
> > +BuildRequires: ncurses-devel
> 

That is probably not a bad suggestion, but the heartbeat RPM
that I use
from upstream has them all in one line.  As I maintain that
as a diff, I
guess I can do it either way ... but will probably stay with
the
upstream way for now.  (Upstream being <http://linux-ha.org>).


As we are currently listed as the Enterprise Linux RPMs for
heartbeat
there ... I'd like to stay as close to upstream as
possible.

Thanks,
Johnny Hughes





_______________________________________________
CentOS-devel mailing list
CentOS-develcentos.org
http://lists.centos.org/mailman/listinfo/centos-devel