List Info

Thread: Reworked code to ignore errors from certain libraries




Reworked code to ignore errors from certain libraries
country flaguser name
United States
2007-06-29 16:58:42
Patches item #1745559, was opened at 2007-06-29 16:58
Message generated for change (Tracker Item Submitted) made
by Item Submitter
You can respond by visiting: 
https://sourcefor
ge.net/tracker/?func=detail&atid=559968&aid=1745559&
amp;group_id=80503

Please note that this message will contain a full copy of
the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: ccHost
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: John Bintz (johncoswell)
Assigned to: Nobody/Anonymous (nobody)
Summary: Reworked code to ignore errors from certain
libraries

Initial Comment:
This patch reworks how cc_error_handler() in cc-debug.php
handles ignoring errors triggered by certain libraries
(PEAR, PHPTAL, and getID3).  Before this patch, for every
time that the cc_error_handler() was called, strpos() could
be run up to three times.  Now, the results of the strpos()
checks are cached on a per-filename basis.  The first time a
PHP file triggers an error, the strpos() checks are cached,
and any subsequent errors triggered by that file use the
cached results, skipping strpos().

When loading the homepage on a brand new install on my
laptop, strpos() was called 3451 times from
cc_error_handler() before this patch.  After the patch, it
was called 199 times.  These results were gathered using
Xdebug/KCacheGrind.

------------------------------------------------------------
----------

You can respond by visiting: 
https://sourcefor
ge.net/tracker/?func=detail&atid=559968&aid=1745559&
amp;group_id=80503
_______________________________________________
cc-devel mailing list
cc-devellists.ibiblio.org
ht
tp://lists.ibiblio.org/mailman/listinfo/cc-devel

[1]

about | contact  Other archives ( Real Estate discussion Medical topics )