liblicense make check fail

Bugs item #1827893, was opened at 2007-11-07 13:22
Message generated for change (Settings changed) made by
kidproto
You can respond by visiting: 
https://sourcefor
ge.net/tracker/?func=detail&atid=559966&aid=1827893&
amp;group_id=80503

Please note that this message will contain a full copy of
the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: liblicense
Group: None
Status: Open
Resolution: None
>Priority: 7
Private: No
Submitted By: Hubert Figuiere (hfiguiere)
>Assigned to: Asheesh Laroia (paulproteus)
Summary: liblicense make check fail

Initial Comment:
liblicense "make check" fail if liblicense hasn't
been installed (in the same prefix).

------------------------------------------------------------
----------

Comment By: Hubert Figuiere (hfiguiere)
Date: 2007-11-07 15:01

Message:
Logged In: YES 
user_id=27487
Originator: YES

Here is first a patch that fix the crash I encounter for
this reason.
Don't try to free NULL or even dereference it.
File Added: bug1827893.diff

------------------------------------------------------------
----------

You can respond by visiting: 
https://sourcefor
ge.net/tracker/?func=detail&atid=559966&aid=1827893&
amp;group_id=80503
_______________________________________________
cc-devel mailing list
cc-devellists.ibiblio.org
ht
tp://lists.ibiblio.org/mailman/listinfo/cc-devel

On Wed, 2007-11-07 at 15:12 -0800, SourceForge.net wrote:
> liblicense "make check" fail if liblicense
hasn't been installed (in the same prefix).

This is the same problem as the one I mentioned a few weeks
ago, how he
automated tests are using the installed modules.

One way to avoid this problem would be to keep the module
mechanism (for
3rd party modules), but link the liblicense-supplied modules
into
liblicense.so

If that's too radical, some kind of LIBLICENSE_MODULE_PATH
environment
variable is clearly necessary, so that the automated tests
can set it
and be guaranteed to be testing the modules built in the
local checkout,
and not the installed modules.

Or maybe both.


Regards
Peter Miller <millerpcanb.auug.org.au>
//*        http://miller.emu.id
.au/pmiller/

PGP public key ID: 1024D/D0EDB64D
fingerprint = AD0A C5DF C426 4F03 5D53  2BDB 18D8 A4E2 D0ED
B64D
See http://www.keyserver.net
or any PGP keyserver for public key.

"Never attribute to malice that which is adequately
explained by
stupidity." -- Hanlon's razor

_______________________________________________
cc-devel mailing list
cc-devellists.ibiblio.org
ht
tp://lists.ibiblio.org/mailman/listinfo/cc-devel

On Thu, 2007-11-08 at 13:23 +1100, Peter Miller wrote:
> If that's too radical, some kind of
LIBLICENSE_MODULE_PATH environment
> variable is clearly necessary, so that the automated
tests can set it
> and be guaranteed to be testing the modules built in
the local checkout,
> and not the installed modules.

Given the current hierarchy we'd have to have a hook to make
check to do

  (cd $top_builddir/modules ; DESTDIR=$builddir/modules make
install)

prior to actually running the checks.

Hub

_______________________________________________
cc-devel mailing list
cc-devellists.ibiblio.org
ht
tp://lists.ibiblio.org/mailman/listinfo/cc-devel

On Wed, 2007-11-07 at 23:11 -0500, Hubert Figuiere wrote:
> On Thu, 2007-11-08 at 13:23 +1100, Peter Miller wrote:
> > If that's too radical, some kind of
LIBLICENSE_MODULE_PATH environment
> > variable is clearly necessary, so that the
automated tests can set it
> > and be guaranteed to be testing the modules built
in the local checkout,
> > and not the installed modules.
> 
> Given the current hierarchy we'd have to have a hook to
make check to do
> 
>   (cd $top_builddir/modules ; DESTDIR=$builddir/modules
make install)
> 
> prior to actually running the checks.

I actually have done it and it works.

See attached patch.
PLEASE DO NOT COMMIT IT. This patch contain other minor
changes that are
already in the patch queue.

I'll clean it up and attach to the bug.

Hub

_______________________________________________
cc-devel mailing list
cc-devellists.ibiblio.org
ht
tp://lists.ibiblio.org/mailman/listinfo/cc-devel

Sweet, Jason or Scott or Asheesh, what do you guys think?

Jon


On Thu, 2007-11-08 at 01:49 -0500, Hubert Figuiere wrote:
> On Wed, 2007-11-07 at 23:11 -0500, Hubert Figuiere
wrote:
> > On Thu, 2007-11-08 at 13:23 +1100, Peter Miller
wrote:
> > > If that's too radical, some kind of
LIBLICENSE_MODULE_PATH environment
> > > variable is clearly necessary, so that the
automated tests can set it
> > > and be guaranteed to be testing the modules
built in the local checkout,
> > > and not the installed modules.
> > 
> > Given the current hierarchy we'd have to have a
hook to make check to do
> > 
> >   (cd $top_builddir/modules ;
DESTDIR=$builddir/modules make install)
> > 
> > prior to actually running the checks.
> 
> I actually have done it and it works.
> 
> See attached patch.
> PLEASE DO NOT COMMIT IT. This patch contain other minor
changes that are
> already in the patch queue.
> 
> I'll clean it up and attach to the bug.
> 
> Hub
> _______________________________________________
> cc-devel mailing list
> cc-devellists.ibiblio.org
> ht
tp://lists.ibiblio.org/mailman/listinfo/cc-devel
-- 
Jon Phillips

San Francisco, CA
USA PH 510.499.0894
jonrejon.org
http://www.rejon.org

MSN, AIM, Yahoo Chat: kidproto
Jabber Chat: rejongristle.org
IRC: rejonirc.freenode.net

Please note: the contents of this email are not intended to
be
legal advice nor should they be relied upon as or
represented to be
legal advice. Jon Phillips does not represent any
organization through
this email address.

_______________________________________________
cc-devel mailing list
cc-devellists.ibiblio.org
ht
tp://lists.ibiblio.org/mailman/listinfo/cc-devel