List Info

Thread: v2.1beta3 need patch ?
v2.1beta3 need patch ?
user name
 2008-04-16 13:18:21 
I think i've found a bug in iaxclient_lib.c :
Line 1168 need to be commented. (calls[callNo].state |= 
IAXC_CALL_STATE_COMPLETE;)
Else when receiving an incoming call the call state is
always marked as 
complete.

I patched my local version and it works fine now.


jf

------------------------------------------------------------
-------------
This SF.net email is sponsored by the 2008 JavaOne(SM)
Conference 
Don't miss this year's exciting event. There's still time to
save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;1987
57673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Iaxclient-devel mailing list
Iaxclient-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iaxclie
nt-devel
Re: v2.1beta3 need patch ?
user name
 2008-04-16 16:43:15 
Hi Jean-François,

On Wed, Apr 16, 2008 at 2:18 PM, Jean-François Guchens
<jf.guchenssqualesystems.com> wrote:
> I think i've found a bug in iaxclient_lib.c :
>  Line 1168 need to be commented. (calls[callNo].state
|=
>  IAXC_CALL_STATE_COMPLETE;)

This behavior has been in iaxclient for a very long time. I
will need
more information to be convinced that the semantic here is
wrong.

>  Else when receiving an incoming call the call state is
always marked as
>  complete.

Could you describe the exact scenario? I'm not sure I
understand what
the problem is. It seems like this may be related to what
Ruslan
reported earlier this week -- have you read that thread?

Does this affect calls directly between iaxclient
applications?

>  I patched my local version and it works fine now.

What about for calls going through asterisk?

It seems like if you made an outbound call with iaxclient
this change
would prevent the call from ever getting to the completed
state.

Pete
------------------------------------------------------------
-------------
This SF.net email is sponsored by the 2008 JavaOne(SM)
Conference 
Don't miss this year's exciting event. There's still time to
save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;1987
57673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Iaxclient-devel mailing list
Iaxclient-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iaxclie
nt-devel
Re: v2.1beta3 need patch ?
user name
 2008-04-17 03:35:22 

  


  

    
Hi Pete,




Peter Grayson a écrit :


mail.gmail.com"
 type="cite">
  
Hi Jean-François,

On Wed, Apr 16, 2008 at 2:18 PM, Jean-François Guchens
squalesystems.com">&lt;jf.guchenssqualesystems.com> wrote:
  

  

    
I think i've found a bug in iaxclient_lib.c :
 Line 1168 need to be commented. (calls[callNo].state |=
 IAXC_CALL_STATE_COMPLETE;)
    

  

  

This behavior has been in iaxclient for a very long time. I will need
more information to be convinced that the semantic here is wrong.

  



ok



mail.gmail.com"
 type="cite">
  

    
 Else when receiving an incoming call the call state is always marked as
 complete.

    

  

  

Could you describe the exact scenario? I'm not sure I understand what
the problem is. It seems like this may be related to what Ruslan
reported earlier this week -- have you read that thread?


Does this affect calls directly between iaxclient applications?

  



No i didn't read this report, i'm new on iaxclient ML 



Here my output :

Incoming call : 

 ============== STATE :  active  ringing !free :
10                      -> ringing

 ============== STATE :  active  complete !free : 18                  
-&gt; answered


 ============== STATE :  active  complete  selected !free : 50   ->
selected



Outgoing call:

IAXCLIENT: Originating an audio only call

 ============== STATE :  outgoing  active  selected !free :
38                    -> sending packet

IAXCLIENT: Failed video codec negotiation.

IAXCLIENT: Call 0 accepted


 ============== STATE :  outgoing  active  selected !free :
38                    -> receive ack

IAXCLIENT: Call 0 answered


 ============== STATE :  outgoing  active  selected  ringing !free :
46      -> ringing

IAXCLIENT: Call 0 ringing

 ============== STATE :  outgoing  active  complete  selected !free :
54   -> complete




I test IAXC_CALL_STATE_* and print the call.state value. Don't pay
attention to !free.



This calls are made between an iaxclient app i develop and a very basic
phone plugged on a TDM11b, through asterisk  1.4.17.



As you can see the COMPLETE flag appear, and it's at the right time.

Before my ""patch"", this flag was alway here on outgoing calls. I
think it's just a flag of iaxclient lib, and this don't change anything
on IAX protocol communication.



jf


mail.gmail.com"
 type="cite">
  

  

    
 I patched my local version and it works fine now.
    

  

  

What about for calls going through asterisk?


It seems like if you made an outbound call with iaxclient this change
would prevent the call from ever getting to the completed state.

Pete
  






  

  
  
   
     
    






 [1-3]











   
 





about | contact  Other archives ( Real Estate discussion Medical topics )