Re: DBMail imap folders issue

I think he is saying he is creating

INBOX/test1
INBOX/test1/test2

Then renaming
INBOX/test1 -> INBOX/testX

But then DBMail is no longer showing test2 underneath testX

(INBOX/testX/test2). Most likely the test2 mailbox row in
the DB is 
still showing as INBOX/test1/test2, and the INBOX/test1 is
now 
INBOX/testX. But since the test2 folder has no parent
anymore he can't 
see it. He is not saying which version he is running, but I
think that 
the renaming of the children was fixed sometime back and has
been doing 
things correctly in the db.

I have tested this on the 2.2 branch as of this weekend and
the only 
problem I encountered was that Tbird returns a mailbox not
found and it 
thinks that the rename failed as it is still trying to show
the 
INBOX/test1/test2 structure. DBMail is renaming the both of
folders in 
the db on the single rename command. After closing Tbird off
and 
relaunching, the test1/test2 become testX/test2 as the
subscriptions are 
looked at again by Tbird.

TBird issues to following command sequence
16 rename "INBOX/test1" "INBOX/testX"
17 subscribe "INBOX/testX"
18 unsubscribe "INBOX/test1"
19 subscribe "INBOX/testX/test2"
20 unsubscribe "INBOX/test1/test2"

The problem lies in that DBMail is written to return a NO to
an 
unsubcribe on a mailbox that doesn't even exist when really
we should be 
telling the client OK because otherwise the client still
thinks that 
mailbox exists during its current session. I can't think of
any reason 
we shouldn't return an OK for an unsubscribe of a mailbox
that no longer 
exists. The attached patch changes the response from a NO to
an OK with 
a descriptive message that the mailbox wan't even there.

After testing this patch, my TBird does the rename with out
issue and 
updates the folder structure with the new INBOX/testX/test2
and drops 
the INBOX/test1/test2 structure.

-Jon

Aaron Stone wrote:
> On Thu, Jul 26, 2007, umask <umaskyandex.ru> said:
>
>   
>> Hi,
>>
>> I noticed that DBMail did not work properly with
IMAP folders.
>> E.g. In DBMail IMAP folder is inline string in
message and it's BIG problem.
>>
>> For example: I created via Thunderbird
'INBOX/test1' folder, and next I created folder
'INBOX/test1/test2'.
>> Next I renamed folder 'test1' to 'testX' (also in
Thunderbird) and lost 'textX' (!!!).
>> DBMail didn't change inline string which define
IMAP folder.
>>
>> How to fix this problem?
>>     
>
> If I understood you correctly, the situation is:
>
> Create INBOX/test1
> Create INBOX/test1/test2
>
> Rename INBOX/test1 -> INBOX/testX
>
> Now you cannot see INBOX/test1/test2 anymore?
>
> Aaron
> _______________________________________________
> DBmail mailing list
> DBmaildbmail.org
> htt
ps://mailman.fastxs.nl/mailman/listinfo/dbmail
>
>
>   




_______________________________________________
DBmail mailing list
DBmaildbmail.org
htt
ps://mailman.fastxs.nl/mailman/listinfo/dbmail

Nice! I'll apply this patch later today (or perhaps Paul
might have time
before I do). Thanks!

Aaron

On Thu, Jul 26, 2007, Jonathan Fealy <vulturenetvulture.com> said:

> I think he is saying he is creating
> 
> INBOX/test1
> INBOX/test1/test2
> 
> Then renaming
> INBOX/test1 -> INBOX/testX
> 
> But then DBMail is no longer showing test2 underneath
testX 
> (INBOX/testX/test2). Most likely the test2 mailbox row
in the DB is 
> still showing as INBOX/test1/test2, and the INBOX/test1
is now 
> INBOX/testX. But since the test2 folder has no parent
anymore he can't 
> see it. He is not saying which version he is running,
but I think that 
> the renaming of the children was fixed sometime back
and has been doing 
> things correctly in the db.
> 
> I have tested this on the 2.2 branch as of this weekend
and the only 
> problem I encountered was that Tbird returns a mailbox
not found and it 
> thinks that the rename failed as it is still trying to
show the 
> INBOX/test1/test2 structure. DBMail is renaming the
both of folders in 
> the db on the single rename command. After closing
Tbird off and 
> relaunching, the test1/test2 become testX/test2 as the
subscriptions are 
> looked at again by Tbird.
> 
> TBird issues to following command sequence
> 16 rename "INBOX/test1"
"INBOX/testX"
> 17 subscribe "INBOX/testX"
> 18 unsubscribe "INBOX/test1"
> 19 subscribe "INBOX/testX/test2"
> 20 unsubscribe "INBOX/test1/test2"
> 
> The problem lies in that DBMail is written to return a
NO to an 
> unsubcribe on a mailbox that doesn't even exist when
really we should be 
> telling the client OK because otherwise the client
still thinks that 
> mailbox exists during its current session. I can't
think of any reason 
> we shouldn't return an OK for an unsubscribe of a
mailbox that no longer 
> exists. The attached patch changes the response from a
NO to an OK with 
> a descriptive message that the mailbox wan't even
there.
> 
> After testing this patch, my TBird does the rename with
out issue and 
> updates the folder structure with the new
INBOX/testX/test2 and drops 
> the INBOX/test1/test2 structure.
> 
> -Jon
> 
> Aaron Stone wrote:
>> On Thu, Jul 26, 2007, umask <umaskyandex.ru> said:
>>
>>   
>>> Hi,
>>>
>>> I noticed that DBMail did not work properly
with IMAP folders.
>>> E.g. In DBMail IMAP folder is inline string in
message and it's BIG problem.
>>>
>>> For example: I created via Thunderbird
'INBOX/test1' folder, and next I created folder
'INBOX/test1/test2'.
>>> Next I renamed folder 'test1' to 'testX' (also
in Thunderbird) and lost 'textX' (!!!).
>>> DBMail didn't change inline string which define
IMAP folder.
>>>
>>> How to fix this problem?
>>>     
>>
>> If I understood you correctly, the situation is:
>>
>> Create INBOX/test1
>> Create INBOX/test1/test2
>>
>> Rename INBOX/test1 -> INBOX/testX
>>
>> Now you cannot see INBOX/test1/test2 anymore?
>>
>> Aaron
>> _______________________________________________
>> DBmail mailing list
>> DBmaildbmail.org
>> htt
ps://mailman.fastxs.nl/mailman/listinfo/dbmail
>>
>>
>>   
> 
> 
> 
> 

-- 



_______________________________________________
DBmail mailing list
DBmaildbmail.org
htt
ps://mailman.fastxs.nl/mailman/listinfo/dbmail