Re: fix email module for python 3000 (bytes/str)

On Sunday 12 August 2007 16:50:05 Barry Warsaw wrote:
> In r56957 I committed changes to sndhdr.py and
imghdr.py so that they
> compare what they read out of the files against proper
byte
> literals.

So nobody read my patches? :-( See my emails
"[Python-3000] Fix imghdr module 
for bytes" and "[Python-3000] Fix sndhdr module
for bytes" from last 
saturday. But well, my patches look similar.

Barry's patch is incomplete: test_voc() is wrong.

I attached a new patch:
 - fix "h[sbseek] == b'1'" and "ratecode =
ord(h[sbseek+4])" in test_voc()
 - avoid division by zero
 - use startswith method: replace h[:2] == b'BM' by
h.startswith(b'BM')
 - use aifc.open() instead of old aifc.openfp()
 - use ord(b'P') instead of ord('P')

Victor Stinner aka haypo
http://hachoir.org/

_______________________________________________
Email-SIG mailing list
Email-SIGpython.org
Your options: http://mail.python.org/mailman/options/em
ail-sig/nessto%40sharedlog.com

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Aug 12, 2007, at 8:26 PM, Victor Stinner wrote:

> On Sunday 12 August 2007 16:50:05 Barry Warsaw wrote:
>> In r56957 I committed changes to sndhdr.py and
imghdr.py so that they
>> compare what they read out of the files against
proper byte
>> literals.
>
> So nobody read my patches? :-( See my emails
"[Python-3000] Fix  
> imghdr module
> for bytes" and "[Python-3000] Fix sndhdr
module for bytes" from last
> saturday. But well, my patches look similar.

Victor, sorry but my email was very spotty and I definitely
missed  
your original patches.  Sorry for duplicating work and
thanks for  
fixing the last few things in these modules.  Glad Guido got
these  
committed.

I'll follow up on email package more in a bit.
- -Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQCVAwUBRsGuknEjvBPtnXfVAQLbfgQAqfiBeaVwIN35nXn9D7DZXItkzoZS
d+1V
f/a4PnzBHTdvFZgggisK/7o5b1uULOaHILLSmiQMFp0W/zV2JFCvKI7kc1/S
kjSo
UgIXK3o9WtmljH3aj1njc6fgy3VCVfa09NDKf89/rCy15AaSxF21YinIDIqF
/yGN
Sn2RQJqvNPc=
=KpZC
-----END PGP SIGNATURE-----
_______________________________________________
Email-SIG mailing list
Email-SIGpython.org
Your options: http://mail.python.org/mailman/options/em
ail-sig/nessto%40sharedlog.com