List Info

Thread: Re: commit




Re: commit
country flaguser name
Germany
2007-04-16 12:53:24

On Monday 16 April 2007 19:28:17 Thomas Zander wrote:

>Just FYI;

>I took a look at the bold command and the code there is failing to do what

>the current code does.

>Usecase:

>;The following text is selected:

>   text<i>foo</i>bar

>expected result;

>  <b>text<i>;foo</i&gt;bar</b>

&gt;Which means that 'foo' is bold AND italic.  Which your code does not do,

>it looses all formatting information of the 'foo' and the 'bar' text

>sections.

>The 'italic' is just an example; this goes for all formatting, from text

>color to the ID of an inlineTextChar thats stored in the format.

Weird, it seems to work here. Just to make sure I am doing the test steps right:

I type text, then hit italic and type foo, hit italic again and type bar.

The result is: textfoobar (foo in italic in case the formating is lost on the mailing list)

I then select everything and hit bold.

The result here is: textfoobar (everything in bold with foo also in italic)

I have also tried with replacing italic with a red font color and it still seems to work, as well as typing everything, selecting foo, press italic and then select everything and press bold.

I don't understand where this discrepency in behaviour could come from.

Pierre

Re: commit
country flaguser name
Netherlands
2007-04-16 13:24:29
On Monday 16 April 2007 19:53, Pierre Stirnweiss wrote:
> I type text, then hit italic and type foo, hit italic
again and type
> bar. The result is: textfoobar (foo in italic in case
the formating is
> lost on the mailing list) I then select everything and
hit bold.
> The result here is: textfoobar (everything in bold with
foo also in
> italic)

I read the bold command in your branch and I concluded that
the above 
behavior would not be able to occur. At least it did not
using Qt4.2 ;)
So you see the result _with_ your bold command?
Specifically using a single 
  m_caret->mergeCharFormat(format);
did not give me the effect above.
-- 
Thomas Zander

_______________________________________________
koffice-devel mailing list
koffice-develkde.org
h
ttps://mail.kde.org/mailman/listinfo/koffice-devel

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )