List Info

Thread: Route record can not be updated using WebAdmin




Route record can not be updated using WebAdmin
user name
2006-02-06 09:28:51
When using the WebAdmin module I noticed that updating routes does not have any affect on the routes stored in the DB.
 
I noticed the following section (lines 955:961)  in WebAdmin.cxx :
if (!rec.mMatchingPattern.empty() && !rec.mRewriteExpression.empty())

{

// write out the updated record to the database now

mStore.mRouteStore.updateRoute(key, method,event,matchingPattern,rewriteExpression,order );

s << "<p><em>Updated:</em> " << rec.mMatchingPattern << "</p>;" << endl;

}

I guess that the goal here is to prevent&nbsp;records with empty MathcingPattern or RewriteExpression from being updated into the DB. Yet the variable rec is not referenced in the function before this context (except&nbsp;its initiation with - AbstractDb::RouteRecord rec;) ;I believe this means that the if statement always evaluates to false.

A possible fix would be to change the if statement to:

if (!matchingPattern.empty() &&; !rewriteExpression.empty())

Best Regards,

Ofir Roval ( ofirkayote.com" target=_blank>ofirkayote.com) - Kayote Networks

 
[1]

about | contact  Other archives ( Real Estate discussion Medical topics )