List Info

Thread: Re: CR: PR 143956: SDP has incorrect default track for 3gp Rel6 multirate conten




Re: CR: PR 143956: SDP has incorrect default track for 3gp Rel6 multirate conten
user name
2005-07-11 18:17:04
>  -2112,8 +2112,8 
> 
>      memset((void*)pDefaultTracks, MAX_UINT32,
>          ulNumStreamGroups*(sizeof(UINT32)));
> -    memset((void*)pDefaultSet, MAX_UINT32,
> -        ulNumStreamGroups*(sizeof(UINT32)));
> +    memset((void*)pDefaultSet, FALSE,
> +        ulNumStreamGroups*(sizeof(BOOL)));

This is surely functional because FALSE is #define'd to 0,
but it looks
really strange to me.  The second parameter to memset is an
int representing
a byte value (an old salty C-ism, of course) and it looks
strange to see a
boolean-ish value there -- kinda like seeing NULL assigned
to an int type.

Could we use 0 instead of FALSE?

-- 
Don't get suckered in by the comments -- they can be
terribly misleading. 
Debug only code.
        -- Dave Storer
_______________________________________________
Helix-server-dev mailing list
Helix-server-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-server-dev
[1]

about | contact  Other archives ( Real Estate discussion Medical topics )