List Info

Thread: fix a typo when building libgcrypt and gnupg 1.4 with mingw-runtime 3.10




fix a typo when building libgcrypt and gnupg 1.4 with mingw-runtime 3.10
user name
2006-11-02 20:17:00
Hello,

Since version 3.10, mingw-runtime now includes
gettimeofday() defined
in <sys/time.h> as specified by POSIX:
http://www.opengroup.org/onlinepubs/009
695399/functions/gettimeofday.html

People using this version to compile are experiencing
problems with a
piece of code which is common to gnupg 1.4 and libcrypt
1.2.3 :
cipher/random.c
http://lists.gnupg.org/pipermail/gnupg-devel/2
006-June/022975.html

Here is that code:

#ifdef HAVE_GETTIMEOFDAY
#include <sys/times.h>
#endif

What will happen on UNIX systems: they all have
gettimeofday(), and they
all have sys/times.h so it's ok

What will happen on WINDOWS systems: they don't have
gettimeofday() , so
it's ok too

What will happen on WINDOWS systems using mingw compiler and
mingw-runtime 3.10 : they have gettimeofday(), but they
don't have
<sys/times.h> so the build will fail

To my knowledge, there is no system that defines
gettimeofday() in
<sys/times.h>, only in <sys/time.h>

Please replace <sys/times.h> by <sys/time.h>
because this is an
annoying typo.

Thanks.

-- 
Rafaël Carré
_______________________________________________
Gcrypt-devel mailing list
Gcrypt-develgnupg.org

http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
fix a typo when building libgcrypt and gnupg 1.4 with mingw-runtime 3.10
user name
2006-11-03 10:24:42
On Thu,  2 Nov 2006 21:17, Rafaël Carré said:

> Please replace <sys/times.h> by
<sys/time.h> because this is an
> annoying typo.

Done in my working copy of gnupg 1.4 and libgcrypt trunk.

Thanks,

  Werner


_______________________________________________
Gcrypt-devel mailing list
Gcrypt-develgnupg.org

http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )