I have checked in your fix to both Cay150 and HEAD.
Most external community memebers don't have CVS checkin
rights by default.
Rishi Mathew or Michael Frazier can provide criteria of
obtaining the CVs
checkin rights.
-->Henry
> -----Original Message-----
> From: David Audrain [mailto:daudrain roundbox.com]
> Sent: Monday, December 04, 2006 2:37 AM Ping
> To: Henry Ping
> Cc: protocol-devhelixcommunity.org
> Subject: Re: [Protocol-dev] CR-Client : Fix tcp
transport
> request handling
>
> Henry,
>
> I do not have the rights to commit.
>
> **** Access denied: Insufficient Karma
> (daudrain33|/cvsroot/protocol|rtsp|)
> cvs commit: Pre-commit check failed
> cvs [commit aborted]: correct above errors first!
>
> David
>
> Henry Ping wrote:
> > I suggest to check pRtpAddr and pRtcpAddr, i.e.
> >
> > + UINT16 nRtpPort = pRtpAddr ?
> pRtpAddr->GetPort() : 0;
> > + UINT16 nRtcpPort = pRtcpAddr
?
> pRtcpAddr->GetPort() :
> > 0;
> >
> > Looks good otherwise. Please merge this to the
HEAD.
> >
> > Thanks
> > -->Henry
> >
> >
> >> -----Original Message-----
> >> From: protocol-dev-bounceshelixcommunity.org
> >> [mailto:protocol-dev-bounceshelixcommunity.org] On Behalf
> Of David
> >> Audrain
> >> Sent: Friday, December 01, 2006 8:27 AM Ping
> >> To: protocol-devhelixcommunity.org
> >> Subject: [Protocol-dev] CR-Client : Fix tcp
transport request
> >> handling
> >>
> >> Modified by: daudrainroundbox.com
> >> Date: 12:01:2006
> >> Project: protocol
> >> Bug Number: none
> >> Bug URL: none
> >>
> >> Synopsis: Fix tcp transport request handling
done in
> >> RTSPClientProtocol::sendSetupRequestMessageExt
> >>
> >> Overview: When HELIX_FEATURE_RTP is defined,
and TCP transport
> >> requests are processed in
> >>
RTSPClientProtocol::sendSetupRequestMessageExt, a crash
> >> occurs in the second switch because
> >> pRtpAddr and pRtcpAddr are still
null.
> >>
> >> Files Added: None
> >>
> >> Files Modified:
> >> protocol/rtsp/rtspclnt.cpp
> >>
> >>
> >> Image Size and Heap Use impact (Client -Only):
None
> >>
> >> Platforms and Profiles Affected:
> >>
> >> Distribution Libraries Affected: None
> >>
> >> Distribution library impact and planned
action:
> >> None
> >>
> >> Platforms and Profiles Build Verified:
> >> win32-i386-vc6 helix-client-all-defines
> >>
> >> Platforms and Profiles Functionality verified:
> >> win32-i386-vc6 helix-client-all-defines
> >>
> >> Branch: hxclient_1_5_0_cayenne
> >>
> >> Copyright assignment:
> >>
> >> My company Roundbox Inc submits this code
under the terms of a
> >> commercial contribution agreement with
RealNetworks, and I am
> >> authorized to contribute this code under said
agreement.
> >>
> >>
> >> QA Instructions:
> >>
> >>
> >>
> >>
> >
> >
>
>
> --
> David Audrain
> Software Engineer
>
> Roundbox
> 9 rue de conde
> 4 eme Etage
> 33270 Bordeaux
> FRANCE
> www.roundbox.com
>
> T: +33 556.001.250
> F: +33 556.442.351
>
> E: daudrainroundbox.com
> Yahoo: daudrain33
> Skype: daudrain33
>
_______________________________________________
Protocol-dev mailing list
Protocol-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/pr
otocol-dev
|