RE: CR: Fix Crash for Streaming via YouTube applicationwhen HTTP/1.0 302 Redirect is

This change looks good to me.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: protocol-dev-bounceshelixcommunity.org 
> [mailto:protocol-dev-bounceshelixcommunity.org] On
Behalf Of 
> Shy.Wardnokia.com
> Sent: Wednesday, April 16, 2008 10:42 AM
> To: protocol-devhelixcommunity.org
> Cc: I-Chin.Yunokia.com
> Subject: [Protocol-dev] CR: Fix Crash for Streaming via

> YouTube applicationwhen HTTP/1.0 302 Redirect is
Received
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement
> with RealNetworks, and I am authorized to contribute
this 
> code under said agreement." 
> Modified by: shy.wardnokia.com
> 
> Reviewed by: rajesh.rathinasamynokia.com 
> Date: 15-April-2008
> 
> Project: SymbianMmf_Rel 
> TSW: MFAE-7DDB8X
> 
> Synopsis: Fix Crash for Streaming via YouTube
application 
> when HTTP/1.0 302 Redirect is Received 
> Overview: When no UDP data is received from the Google
server 
> we switch transport and we get an HTTP redirect and
this 
> introduces a memory corruption when we are deleted.
Basically 
> a buffer is being deleted twice. The fix is already in
the 
> HEAD branch. Also made all buffer creation to be from
CCF.
> 
> Files Modified:
> 
> /cvsroot/protocol/common/util/hxcloakedsocket.cpp 
> Image Size and Heap Use impact: None
> 
> Module Release testing (STIF) : Pass, Streaming Cases
only
> 
> Test case(s) Added : No 
> Memory leak check performed : No new leaks introduced.

> Platforms and Profiles Build Verified:
> Profile -> helix-client-s60-32-mmf-mdf-arm
> BIF branch -> helix_restricted
> SYSTEM_ID -> symbian-91-armv5
> Target -> symbianMmf_rel
> 
> Platforms and Profiles Functionality verified: armv5,
winscw
> 
> Branch: Cays_2_1_0, Cays_2_2_1 
> <<protocol.diff>> 
> 
> 


_______________________________________________
Protocol-dev mailing list
Protocol-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/pr
otocol-dev

Check into Cays_2_1_0 & Cays_2_2_1

Thanks,

Shy; 

-----Original Message-----
From: ext Eric Hyche [mailto:ehychereal.com] 
Sent: Wednesday, April 16, 2008 10:07 AM
To: Ward Shy (Nokia-D-MSW/Dallas); protocol-devhelixcommunity.org
Cc: Yu I-Chin (Nokia-D-MSW/Dallas)
Subject: RE: [Protocol-dev] CR: Fix Crash for Streaming via
YouTube
applicationwhen HTTP/1.0 302 Redirect is Received


This change looks good to me.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: protocol-dev-bounceshelixcommunity.org
> [mailto:protocol-dev-bounceshelixcommunity.org] On
Behalf Of 
> Shy.Wardnokia.com
> Sent: Wednesday, April 16, 2008 10:42 AM
> To: protocol-devhelixcommunity.org
> Cc: I-Chin.Yunokia.com
> Subject: [Protocol-dev] CR: Fix Crash for Streaming via
YouTube 
> applicationwhen HTTP/1.0 302 Redirect is Received
> 
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with RealNetworks, and I am authorized to
contribute this 
> code under said agreement."
> Modified by: shy.wardnokia.com
> 
> Reviewed by: rajesh.rathinasamynokia.com
> Date: 15-April-2008
> 
> Project: SymbianMmf_Rel
> TSW: MFAE-7DDB8X
> 
> Synopsis: Fix Crash for Streaming via YouTube
application when 
> HTTP/1.0 302 Redirect is Received
> Overview: When no UDP data is received from the Google
server we 
> switch transport and we get an HTTP redirect and this
introduces a 
> memory corruption when we are deleted. Basically a
buffer is being 
> deleted twice. The fix is already in the HEAD branch.
Also made all 
> buffer creation to be from CCF.
> 
> Files Modified:
> 
> /cvsroot/protocol/common/util/hxcloakedsocket.cpp
> Image Size and Heap Use impact: None
> 
> Module Release testing (STIF) : Pass, Streaming Cases
only
> 
> Test case(s) Added : No
> Memory leak check performed : No new leaks introduced.

> Platforms and Profiles Build Verified:
> Profile -> helix-client-s60-32-mmf-mdf-arm BIF
branch -> 
> helix_restricted SYSTEM_ID -> symbian-91-armv5
Target -> 
> symbianMmf_rel
> 
> Platforms and Profiles Functionality verified: armv5,
winscw
> 
> Branch: Cays_2_1_0, Cays_2_2_1
> <<protocol.diff>>
> 
> 


_______________________________________________
Protocol-dev mailing list
Protocol-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/pr
otocol-dev