crash in history handler

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mikkel Kamstrup Erlandsen schrieb:
> Without this patch the history module consistently
crashes with :
> 
> Traceback (most recent call last):
>   File
>
"/home/mikkel/Projects/deskbar-applet/deskbar/ui/Cuemia
cWindowView.py",
> line 216, in append_matches
>     self.treeview_model.append (matches,
self.entry.get_text())
>   File
>
"/home/mikkel/Projects/deskbar-applet/deskbar/ui/cuemia
c/CuemiacModel.py",
> line 105, in append
>     self.__append_match(hit, query_string)
>   File
>
"/home/mikkel/Projects/deskbar-applet/deskbar/ui/cuemia
c/CuemiacModel.py",
> line 91, in __append_match
>     if not
self.__match_hashes.has_key(match_obj.get_hash()):
>   File
>
"/home/mikkel/Projects/deskbar-applet/deskbar/handlers/
history.py", line
> 19, in get_hash
>     return
"history_"+self._action.get_hash()
> TypeError: cannot concatenate 'str' and 'NoneType'
objects
> 
Arg, one day too late. Now you have to request a Hard Code
freeze break.
Could you do that, because it's your patch anyway?

- --
Greetings,
Sebastian Pölsterl
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFG5mAl1ygZeJ3lLIcRAvZ3AKCjv+khcof3A++g5QVLxlDzy+ZaRQCf
VvJC
DPVXx4YBEuvNCO7vMrz7LaQ=
=y9Nd
-----END PGP SIGNATURE-----
_______________________________________________
deskbar-applet-list mailing list
deskbar-applet-listgnome.org
http://mail.gnome.org/mailman/listinfo/deskbar-applet-
list

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mikkel Kamstrup Erlandsen schrieb:
> 
> Ooops, sorry about that 
> I don't know if it is the right fix though. If you
think it is OK, I can
> try to get it acked. So, is it ok?
> 
In an ideal world Action's get_hash should not return None,
but since we
don't live in such world your patch is absolutely okay ;)

- --
Greetings,
Sebastian Pölsterl
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFG57eZ1ygZeJ3lLIcRAii5AJkBUncA9myYCFCtTTyEmdiPBCDI+gCe
LMsN
WHMb85SFNkXfhYeVI+ZjomA=
=hRNb
-----END PGP SIGNATURE-----
_______________________________________________
deskbar-applet-list mailing list
deskbar-applet-listgnome.org
http://mail.gnome.org/mailman/listinfo/deskbar-applet-
list