Match/Action display string

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mikkel Kamstrup Erlandsen schrieb:
> Why is the string displayed by a match != string
displayed by default
> action? I know you can enforce this in each module, but
it seems quite odd.
> 
The match stands for the object that has been found (e.g. a
file or a
e-mail). Therefore, get_name() should return the name of
this object.
Actions on the other hand do something with this object.
Most of the
time the description of a action is more complex than that
of a match.

> For 2.22 I suggest we simply scrap Match.get_name() and
display the default
> Action instead.
> 
If a match has only one action "get_name() &
get_verb()" of the action
will displayed in the results. If it has more than one
action match's
get_name() will be displayed.

In my opinion it's confusing when the description of the
default action
is displayed. If more actions available it seems that the
action has
more actions. But on the other hand: when only the name of
the match is
displayed how should the user know what the default action
is?

> 
> PS: The Action api also has richer formatting options.
Match only has
> get_name() while Action have the old style
get_name/get_verb combo.
> 
That's intended, because the name of a match (get_name)
should be static
and not require any fancy formatting. Whereas actions are
more complex.

- --
Greetings,
Sebastian Pölsterl
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFG/L7+1ygZeJ3lLIcRAmytAJ9fHGh8dsJsQpT4lcOLPxuyJHGeqgCe
PakE
VLP5giwJRyAMyq1JJcYspYo=
=k7kz
-----END PGP SIGNATURE-----
_______________________________________________
deskbar-applet-list mailing list
deskbar-applet-listgnome.org
http://mail.gnome.org/mailman/listinfo/deskbar-applet-
list

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mikkel Kamstrup Erlandsen schrieb:
> 
> Hmm... I think it is a difference in how the
Match/Action relation is
> understood that is the root of my confusion.
> 
> My idea was that Actions was extra functionality you
could add to a match,
> while I understand from your explanation that a match
with a set of actions
> is merely a placeholder for those actions...
> 
The match in 2.20 has nothing to do with the match in <=
2.18. In 2.20
the match is just a placeholder for the object that the
module has
found. A match without actions added to it does actually
nothing.
However, the 2.20 actions is very similar to the <= 2.18
match.

> Showing the default actions makes sense in from my
view, but from your view
> (as I understand it) I guess it makes sense to display
something else.
> 
It makes sense when only one action is available. The
question is if a
match has more than one actions, should we display the
description of
the default action or the name of the match?

- --
Greetings,
Sebastian Pölsterl
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFG/sWi1ygZeJ3lLIcRAroZAKCeEnspZuIDA2t0SJsCkS44e28TswCg
gWqK
RgE/jU263f9L6P7cDukpcTU=
=pY5n
-----END PGP SIGNATURE-----
_______________________________________________
deskbar-applet-list mailing list
deskbar-applet-listgnome.org
http://mail.gnome.org/mailman/listinfo/deskbar-applet-
list

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mikkel Kamstrup Erlandsen schrieb:
> 2007/9/29, Sebastian Pölsterl <mardukk-d-w.org>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Mikkel Kamstrup Erlandsen schrieb:
>>> Hmm... I think it is a difference in how the
Match/Action relation is
>>> understood that is the root of my confusion.
>>>
>>> My idea was that Actions was extra
functionality you could add to a
>> match,
>>> while I understand from your explanation that a
match with a set of
>> actions
>>> is merely a placeholder for those actions...
>>>
>> The match in 2.20 has nothing to do with the match
in <= 2.18. In 2.20
>> the match is just a placeholder for the object that
the module has
>> found. A match without actions added to it does
actually nothing.
>> However, the 2.20 actions is very similar to the
<= 2.18 match.
>>
>>> Showing the default actions makes sense in from
my view, but from your
>> view
>>> (as I understand it) I guess it makes sense to
display something else.
>>>
>> It makes sense when only one action is available.
The question is if a
>> match has more than one actions, should we display
the description of
>> the default action or the name of the match?
> 
> 
> Hmmm, I'm not really sure what the right solution is.
The ultimate goal is
> of course to display the most useful and relevant
information to the user.
> How the API looks underneath should not govern what
reaches the user.
> 
> I still think I would display the default action. After
all you still have
> the arrow to indicate that there are other
possibilities. It's just a hunch
> though, I'm not really sure...
> 
After thinking about it for a while I think it's the best to
show the
the description of the default action at all time.
Therefore,
Match.get_name() is not needed anymore.

- --
Greetings,
Sebastian Pölsterl
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFHC4eB1ygZeJ3lLIcRAnxIAKCS8EwIJyHZWxP5wVHS4ft0nHc+EACf
Xuzk
Miyx9gcCSgkzC5pXbxUyCeY=
=OyUq
-----END PGP SIGNATURE-----
_______________________________________________
deskbar-applet-list mailing list
deskbar-applet-listgnome.org
http://mail.gnome.org/mailman/listinfo/deskbar-applet-
list