./configure confused about FLTK version

Hi all,

it seems that the ./configure script as generated by
./autogen.sh of
current cvs tree will happily go with fltk < 2, giving
compilation
errors later.

	Jan



$ uname -a
OpenBSD dell.stare.cz 4.1 GENERIC#0 i386

$ pkg_info | grep fltk
fltk-1.1.7          Fast-Light Tool Kit

$ pwd
/home/hans/src

$ cvs -z3 -d:pserver:anonymousauriga.wearlab.de:/sfhome/cvs/dillo co dillo2
cvs checkout: Updating dillo2
[...]
$ cvs -z3 -d:pserver:anonymousauriga.wearlab.de:/sfhome/cvs/dillo co dw2
cvs checkout: Updating dw2
[...]

$ ln -s dw2 dw-testbed
$ cd dw-testbed
$ export AUTOCONF_VERSION=2.61
$ export AUTOMAKE_VERSION=1.9
$ ./autogen.sh
aclocal         found
autoheader      found
autoconf        found
automake        found
[Checks passed]
Generating...
[...]
$ ./configure
[...]
checking FLTK2... yes
[...]
config.status: executing depfiles commands
$
$ gmake
[...]
if g++ -DPACKAGE_NAME=""
-DPACKAGE_TARNAME=""
-DPACKAGE_VERSION=""
-DPACKAGE_STRING=""
-DPACKAGE_BUGREPORT=""
-DPACKAGE="dw-testbed"
-DVERSION="0.0.43j" -DSTDC_HEADERS=1
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
-DHAVE_FCNTL_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_UIO_H=1 -I.
-I.    -I/usr/local/include -O2 -pipe -I/usr/local/include
-I/usr/X11R6/include -g -O2 -D_REENTRANT -D_THREAD_SAFE
-Wall -W -Wno-unused-parameter -MT
libDw_fltk_a-fltkcomplexbutton.o -MD -MP -MF
".deps/libDw_fltk_a-fltkcomplexbutton.Tpo" -c -o
libDw_fltk_a-fltkcomplexbutton.o `test -f
'fltkcomplexbutton.cc' || echo './'`fltkcomplexbutton.cc; 
then mv -f
".deps/libDw_fltk_a-fltkcomplexbutton.Tpo"
".deps/libDw_fltk_a-fltkcomplexbutton.Po"; else rm
-f ".deps/libDw_fltk_a-fltkcomplexbutton.Tpo";
exit 1; fi
fltkcomplexbutton.cc:23:25: fltk/events.h: No such file or
directory
fltkcomplexbutton.cc:24:25: fltk/damage.h: No such file or
directory
fltkcomplexbutton.cc:25:24: fltk/Group.h: No such file or
directory
fltkcomplexbutton.cc:26:22: fltk/Box.h: No such file or
directory
In file included from fltkcomplexbutton.cc:29:
fltkcomplexbutton.hh:28:24: fltk/Group.h: No such file or
directory
In file included from fltkcomplexbutton.cc:29:
fltkcomplexbutton.hh:34: error: `fltk' is not a class or
namespace
fltkcomplexbutton.hh:35: error: `Group' is not a class or
namespace
fltkcomplexbutton.hh:35: error: invalid base-class
specification
fltkcomplexbutton.hh:43: error: syntax error before `&'
token
fltkcomplexbutton.hh:45: error: syntax error before `::'
token
[...]


_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

On Thu, Oct 18, 2007 at 03:53:25PM +0200, Jan Stary wrote:
> Hi all,
> 
> it seems that the ./configure script as generated by
./autogen.sh of
> current cvs tree will happily go with fltk < 2,
giving compilation
> errors later.
> 
>       Jan

  Try this:

- else if sh -c "fltk-config --version"
>/dev/null 2>&1
+ else if sh -c "fltk-config --version|grep ^2"
>/dev/null 2>&1

-- 
  Cheers
  Jorge.-

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

On Thu, Oct 18, 2007 at 11:46:06AM -0300, Johannes Hofmann
wrote:
> On Thu, Oct 18, 2007 at 03:53:25PM +0200, Jan Stary
wrote:
> > Hi all,
> > 
> > it seems that the ./configure script as generated
by ./autogen.sh of
> > current cvs tree will happily go with fltk < 2,
giving compilation
> > errors later.
> > 
> >       Jan
> 
>   Try this:
> 
> - else if sh -c "fltk-config --version"
>/dev/null 2>&1
> + else if sh -c "fltk-config --version|grep
^2" >/dev/null 2>&1

All newer fltk2 builds install fltk2-config so I think we
could drop the
check for fltk-config alltogether, i.e for dw-testbed:

diff -r 67316fad7af1 configure.in
--- a/configure.in      Thu Oct 18 16:23:15 2007 +0200
+++ b/configure.in      Thu Oct 18 18:27:20 2007 +0200
 -38,14
+38,8  then AC_MSG_RESULT(yes)
      LIBFLTK_CXXFLAGS=`fltk2-config --cxxflags`
      LIBFLTK_CFLAGS=`fltk2-config --cflags`
      LIBFLTK_LIBS=`fltk2-config --use-images --ldflags`
-else if sh -c "fltk-config --version"
>/dev/null 2>&1
-     then AC_MSG_RESULT(yes)
-          LIBFLTK_CXXFLAGS=`fltk-config --cxxflags`
-          LIBFLTK_CFLAGS=`fltk-config --cflags`
-          LIBFLTK_LIBS=`fltk-config --ldflags`
-     else AC_MSG_RESULT(no)
-          AC_ERROR(FLTK2 must be installed!)
-     fi
+else AC_MSG_RESULT(no)
+     AC_ERROR(FLTK2 must be installed!)
 fi
 
 dnl --------------------


_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

On Thu, Oct 18, 2007 at 06:29:27PM +0200, Johannes Hofmann
wrote:
> On Thu, Oct 18, 2007 at 11:46:06AM -0300, Johannes
Hofmann wrote:
> > On Thu, Oct 18, 2007 at 03:53:25PM +0200, Jan
Stary wrote:
> > > Hi all,
> > > 
> > > it seems that the ./configure script as
generated by ./autogen.sh of
> > > current cvs tree will happily go with fltk
< 2, giving compilation
> > > errors later.
> > > 
> > >       Jan
> > 
> >   Try this:
> > 
> > - else if sh -c "fltk-config --version"
>/dev/null 2>&1
> > + else if sh -c "fltk-config --version|grep
^2" >/dev/null 2>&1
> 
> All newer fltk2 builds install fltk2-config so I think
we could drop the
> check for fltk-config alltogether, i.e for dw-testbed:
> 
> diff -r 67316fad7af1 configure.in
> --- a/configure.in      Thu Oct 18 16:23:15 2007 +0200
> +++ b/configure.in      Thu Oct 18 18:27:20 2007 +0200
>  -38,14 +38,8  then AC_MSG_RESULT(yes)
>       LIBFLTK_CXXFLAGS=`fltk2-config --cxxflags`
>       LIBFLTK_CFLAGS=`fltk2-config --cflags`
>       LIBFLTK_LIBS=`fltk2-config --use-images
--ldflags`
> -else if sh -c "fltk-config --version"
>/dev/null 2>&1
> -     then AC_MSG_RESULT(yes)
> -          LIBFLTK_CXXFLAGS=`fltk-config --cxxflags`
> -          LIBFLTK_CFLAGS=`fltk-config --cflags`
> -          LIBFLTK_LIBS=`fltk-config --ldflags`
> -     else AC_MSG_RESULT(no)
> -          AC_ERROR(FLTK2 must be installed!)
> -     fi
> +else AC_MSG_RESULT(no)
> +     AC_ERROR(FLTK2 must be installed!)
>  fi

  Some time ago they were deciding whether
{fltk,fltk2}-config.
If you're sure they decided for fltk2-config finally, I'd
commit.

-- 
  Cheers
  Jorge.-

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

> 
>   Some time ago they were deciding whether
{fltk,fltk2}-config.
> If you're sure they decided for fltk2-config finally,
I'd commit.

Currently it's fltk2-config. They might switch back, but I
don't
think this will happen any time soon.

  Johannes

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

On Fri, Oct 19, 2007 at 03:33:14PM +0200, Johannes Hofmann
wrote:
> > 
> >   Some time ago they were deciding whether
{fltk,fltk2}-config.
> > If you're sure they decided for fltk2-config
finally, I'd commit.
> 
> Currently it's fltk2-config. They might switch back,
but I don't
> think this will happen any time soon.

  OK, I can point at you then!   

  Done.

  BTW Jan, for the record, did the other patch work?

-- 
  Cheers
  Jorge.-

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev