rc4 testing

Hi,

  Kelson told me the patch in CVS works for the web bug
segfault.

  It looks like we're close to a release.

  I'll wait a couple of days more for feedback.

-- 
  Cheers
  Jorge.-

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

Is it too late for a small hack?
dl_gui is not localized, but wget yes. When you have a
locale diferent from "C" or one english one
dl_gui do not get the download size (it search for
"Lenght:" in wget log) and progress bar do not
show real progress.

How i unknown how portables are locale functions y use
puntenv to change locale environ and set wget(and its log)
to "C"
A better solution can be to localize dl_gui or generalize
wget parser


diff -pru dillo-0.8.6-rc4-C/dpi/downloads.cc
dillo-0.8.6-rc4/dpi/downloads.cc
--- dillo-0.8.6-rc4-C/dpi/downloads.cc	2006-04-10
19:47:00.000000000 +0200
+++ dillo-0.8.6-rc4/dpi/downloads.cc	2006-04-10
19:48:26.000000000 +0200
 -458,6
+458,8  void DLItem::child_init()
    close(1); // stdout
    close(LogPipe[0]);
    dup2(LogPipe[1], 2); // stderr
+   // put locale to C (small hack) dl_gui search for
"Lenght:" in wget log
+   putenv("LC_ALL=C");
    // start wget
    execvp(dl_argv[0], dl_argv);
 }

If i get time i will try to support dillo cookies file. It
is only add "--load-cookies
$HOME/.dillo/cookies.txt" to wget comandline. May be
this work (not tested, can anyone test and report?)


diff -pru dillo-0.8.6-rc4-C/dpi/downloads.cc
dillo-0.8.6-rc4/dpi/downloads.cc
--- dillo-0.8.6-rc4-C/dpi/downloads.cc	2006-04-10
20:20:30.000000000 +0200
+++ dillo-0.8.6-rc4/dpi/downloads.cc	2006-04-10
20:20:11.000000000 +0200
 -325,7
+325,7  DLItem:LItem(co
nst char *full_filename
    /* avoid malicious SMTP relaying with FTP urls */
    if (g_strncasecmp(esc_url, "ftp:/", 5) == 0)
       Filter_smtp_hack(esc_url);
-   dl_argv = new char*[6];
+   dl_argv = new char*[7];
    int i = 0;
    dl_argv[i++] = "wget";
    if (action == DL_CONTINUE) {
 -336,6
+336,7  DLItem:LItem(co
nst char *full_filename
    dl_argv[i++] = "-O";
    dl_argv[i++] = fullname;
    dl_argv[i++] = esc_url;
//g_strdup_printf("'%s'", esc_url);
+   dl_argv[i++] = "--load-cookies
$HOME/.dillo/cookies.txt";
    dl_argv[i++] = NULL;
    //g_free(esc_url);
 

But i do not understand this lines in DLItem::~DLItem()

   if (dl_argv[4] == NULL)                                  
                   
      g_free(dl_argv[3]);                                   
                   
   else                                                     
                   
      g_free(dl_argv[4]);                                   
                   
   delete(dl_argv);                                         
                   

¿do not change arguments order if "-c" is used
or not?

Diego.

El Sun, 9 Apr 2006 19:44:43 -0400
Jorge Arellano Cid <jciddillo.org> escribio:

> Hi,
> 
>   Kelson told me the patch in CVS works for the web bug
segfault.
> 
>   It looks like we're close to a release.
> 
>   I'll wait a couple of days more for feedback.
> 
> -- 
>   Cheers
>   Jorge.-
> 
> _______________________________________________
> Dillo-dev mailing list
> Dillo-devdillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev
_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

Hi there,

On Mon, Apr 10, 2006 at 08:23:33PM +0200, Diego Sáenz wrote:
> Is it too late for a small hack?
> dl_gui is not localized, but wget yes. When you have a
locale diferent from "C" or one english one
dl_gui do not get the download size (it search for
"Lenght:" in wget log) and progress bar do not
show real progress.
> 
> How i unknown how portables are locale functions y use
puntenv to change locale environ and set wget(and its log)
to "C"
> A better solution can be to localize dl_gui or
generalize wget parser

  The patchset for downloads GUI is in CVS now. This is:

    - LC_ALL=C
    - cookies
    - Last download goes on top
      (please send feedback on this)

  NOTE: please use FLTK2 r4898 or less. The latest versions
are too
unstable or simply crash.

  From scratch from svn:
 
    svn co -r 4898 http://
svn.easysw.com/public/fltk/fltk/trunk/ fltk

  to an existing svn tree:
  
    svn update -r 4898


  If I don't get more bug reports from rc4 in a couple of
days, I'll
expect Diego's feedback and pack rc5 with CVS.

-- 
  Cheers
  Jorge.-

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

Hi Diego,

On Mon, Apr 10, 2006 at 08:23:33PM +0200, Diego Sáenz wrote:
> Is it too late for a small hack?

  Still time to squash bugs.

> dl_gui is not localized, but wget yes. When you have a
locale diferent from "C" or one english one
dl_gui do not get the download size (it search for
"Lenght:" in wget log) and progress bar do not
show real progress.
> 
> How i unknown how portables are locale functions y use
puntenv to change locale environ and set wget(and its log)
to "C"
> A better solution can be to localize dl_gui or
generalize wget parser
> 
> 
> diff -pru dillo-0.8.6-rc4-C/dpi/downloads.cc
dillo-0.8.6-rc4/dpi/downloads.cc
> --- dillo-0.8.6-rc4-C/dpi/downloads.cc       
2006-04-10 19:47:00.000000000 +0200
> +++ dillo-0.8.6-rc4/dpi/downloads.cc  2006-04-10
19:48:26.000000000 +0200
>  -458,6 +458,8  void DLItem::child_init()
>     close(1); // stdout
>     close(LogPipe[0]);
>     dup2(LogPipe[1], 2); // stderr
> +   // put locale to C (small hack) dl_gui search for
"Lenght:" in wget log
> +   putenv("LC_ALL=C");
>     // start wget
>     execvp(dl_argv[0], dl_argv);
>  }

  I prefer setenv(), because with putenv() you have to
define
_XOPEN_SOURCE or _SVID_SOURCE.


> 
> If i get time i will try to support dillo cookies file.
It is only add "--load-cookies
$HOME/.dillo/cookies.txt" to wget comandline. May be
this work (not tested, can anyone test and report?)
> 
> 
> diff -pru dillo-0.8.6-rc4-C/dpi/downloads.cc
dillo-0.8.6-rc4/dpi/downloads.cc
> --- dillo-0.8.6-rc4-C/dpi/downloads.cc       
2006-04-10 20:20:30.000000000 +0200
> +++ dillo-0.8.6-rc4/dpi/downloads.cc  2006-04-10
20:20:11.000000000 +0200
>  -325,7 +325,7  DLItem:LItem(co
nst char *full_filename
>     /* avoid malicious SMTP relaying with FTP urls */
>     if (g_strncasecmp(esc_url, "ftp:/", 5)
== 0)
>        Filter_smtp_hack(esc_url);
> -   dl_argv = new char*[6];
> +   dl_argv = new char*[7];
>     int i = 0;
>     dl_argv[i++] = "wget";
>     if (action == DL_CONTINUE) {
>  -336,6 +336,7  DLItem:LItem(co
nst char *full_filename
>     dl_argv[i++] = "-O";
>     dl_argv[i++] = fullname;
>     dl_argv[i++] = esc_url;
//g_strdup_printf("'%s'", esc_url);
> +   dl_argv[i++] = "--load-cookies
$HOME/.dillo/cookies.txt";
>     dl_argv[i++] = NULL;
>     //g_free(esc_url);
>  

  AFAIU that code will not work (setting two arguments in
one place)...


> 
> But i do not understand this lines in DLItem::~DLItem()
> 
>    if (dl_argv[4] == NULL)                             
                        
>       g_free(dl_argv[3]);                              
                        
>    else                                                
                        
>       g_free(dl_argv[4]);                              
                        
>    delete(dl_argv);                                    
                        
> 
> ¿do not change arguments order if "-c" is
used or not?

  Yes, but it's buggy! ;)

  All of it is fixed in my tree, but FLTK2 last version
breaks lots
of things so I'm going back for testing. :-P

  BTW,  I have the idea of adding new downloads on top
instead of
bottom.  That  way you always see the fresh download you
started,
no  matter  what  the  size of the window. I'll test this
with an
older FLTK2 version and commit for your testing pleasure. ;)


-- 
  Cheers
  Jorge.-

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

All well for me.

Diego.


El Wed, 12 Apr 2006 10:59:52 -0400
Jorge Arellano Cid <jciddillo.org> escribio:

> Hi there,
> 
> On Mon, Apr 10, 2006 at 08:23:33PM +0200, Diego Sáenz
wrote:
> > Is it too late for a small hack?
> > dl_gui is not localized, but wget yes. When you
have a locale diferent from "C" or one english
one dl_gui do not get the download size (it search for
"Lenght:" in wget log) and progress bar do not
show real progress.
> > 
> > How i unknown how portables are locale functions y
use puntenv to change locale environ and set wget(and its
log) to "C"
> > A better solution can be to localize dl_gui or
generalize wget parser
> 
>   The patchset for downloads GUI is in CVS now. This
is:
> 
>     - LC_ALL=C
>     - cookies
>     - Last download goes on top
>       (please send feedback on this)
> 
>   NOTE: please use FLTK2 r4898 or less. The latest
versions are too
> unstable or simply crash.
> 
>   From scratch from svn:
>  
>     svn co -r 4898 http://
svn.easysw.com/public/fltk/fltk/trunk/ fltk
> 
>   to an existing svn tree:
>   
>     svn update -r 4898
> 
> 
>   If I don't get more bug reports from rc4 in a couple
of days, I'll
> expect Diego's feedback and pack rc5 with CVS.
> 
> -- 
>   Cheers
>   Jorge.-
> 
> _______________________________________________
> Dillo-dev mailing list
> Dillo-devdillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev
_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

I'm still investigating this message below from cronocloud.
The first
bit is more concerning (but was it rc3 or 4? - I don't yet
know) than
the 2nd.

The second point is probably because he's still got the v6
d/l in place

Read and respond to this message at: 
https://playstation2-linux.com/forum/message.php?ms
g_id=49497
By: cronocloud

I reverted to 0.8.5, the new downloader only worked for me
once, as far
as I
could tell.  And even if I recompiled with --disable-dlgui
it still
wouldn't
download properly.

I
-- 
robert w hall

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev

Hi,

On Thu, Apr 13, 2006 at 06:53:50PM +0100, robert w hall
wrote:
> I'm still investigating this message below from
cronocloud. The first
> bit is more concerning (but was it rc3 or 4? - I don't
yet know) than
> the 2nd.
> 
> The second point is probably because he's still got
the v6 d/l in place
> 
> Read and respond to this message at: 
> https://playstation2-linux.com/forum/message.php?ms
g_id=49497
> By: cronocloud
> 
> I reverted to 0.8.5, the new downloader only worked for
me once, as far
> as I
> could tell.  And even if I recompiled with
--disable-dlgui it still
> wouldn't
> download properly.

  It's very important not to mix versions, and to be
careful.

  This is:

  dpidc stop
  make
  make install-strip
  (be sure not to have old dpis under ~/.dillo/ too!).

  test


  BTW, Friday or Saturday rc5 could be out.

-- 
  Cheers
  Jorge.-

_______________________________________________
Dillo-dev mailing list
Dillo-devdillo.org
http://lists.auriga.wearlab.de/cgi-bin/mailman/
listinfo/dillo-dev