List Info

Thread: Patch submission




Patch submission
user name
2007-01-23 09:26:18
Hi, I recently submitted a patch to this list. After doing that, I realized that I didn't check the rules for patch submission at DirectFB. So, here's my question: - How should I submit a patch? Is submission to this list sufficient? - What response should I expect? Is there a maintainer that checks for patches every x weeks or so? Do I have to send aditional requests to other people? Richard. _______________________________________________ directfb-dev mailing list directfb-devdirectfb.org http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
Re: Patch submission
user name
2007-01-23 15:27:55
On Tue, Jan 23, 2007 at 04:26:18PM +0100, Richard van Paasen
wrote:
> Hi,
> 
>   I recently submitted a patch to this list. After
doing that, I realized
> that I didn't check the rules for patch submission at
DirectFB.
> 
> So, here's my question:
> - How should I submit a patch? Is submission to this
list sufficient?

There are no official rules for patch submission. I like to
see patches 
on the list rather than hidden in the bug tacker. However it
might be a 
good idea to add patches to the bug tracker in addition to
sending them 
to the list so they are easier to find later.

It looks like your patch was in line with what I prefer
personally. Add 
-p to your diff flags and it's perfect 

> - What response should I expect? Is there a maintainer
that checks for
> patches every x weeks or so? Do I have to send
aditional requests to other
> people?

I think historically we have been a little slow to respond
to some 
patches, and others may have simply fallen through the
cracks. If 
nothing happens for a week or so, it's usually a good idea
to ping the 
list.

Your patch is against df_xine which means it's up to Claudio
Ciccani to 
review. Let's give him a little more time... 

-- 
Ville Syrjälä
syrjalasci.fi
http://www.sci.fi/~syrjal
a/

_______________________________________________
directfb-dev mailing list
directfb-devdirectfb.org
http://mail.directfb.org/cgi-bin/mailman/listinfo/
directfb-dev

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )