OPAL SIP & RFC2833

On 31. Okt 2006, at 12:23, Simon Zwahlen wrote:

> Hi Hannes,
>
> could you perhaps have a look at my proposed patch
1566917 in the  
> sourceforge tracker?
>
> I'd find it much better if we'd add the filter in the  
> OnPatchMediaStream callback, which would also make sure
it's added  
> only once. I'm not sure whether I've got the the media
format  
> changes correctly, though.

I'll have a look
>
> Thanks,
> Simon
>
>
> On Thu, 5 Oct 2006 21:18:36 +0200, Hannes Friederich  
> <hannesfee.ethz.ch> wrote:
>> I guess this post wasn't 100% correct. The problems
of having the
>> same RFC2833 handler being called twice is still
not nice, but not
>> the problem
>>
>> The problem is that
SIPConnection::InitRFC2833Handler() installes the
>> RFC2833 handler without specifying a media format.
>> Thus, the handler is called both within
OpalMediaPatch::Main and
>> OpalMediaPatch::Sink::WriteFrame(), wich causes the
problems.
>>
>> I'll fix that and will also try to ensure that the
RFC2833 filter is
>> added only once.
>>
>> Begin forwarded message:
>>
>>> From: Hannes Friederich <hannesfee.ethz.ch>
>>> Date: 5. Oktober 2006 19:50:20 GMT+02:00
>>> To: OpenH323 list <openh323openh323.org>
>>> Subject: OPAL SIP & RFC2833
>>>
>>> Hi,
>>>
>>> There is another problem with OPAL SIP, this
time related to  
>>> RFC2833:
>>>
>>> It may be that the RFC2833 handler gets
appended twice as a filter
>>> to the media patch (In fact, once for every
time OnConnected() is
>>> called within SIPConnection)
>>>
>>> -> The RFC2833 handler filters the same
frame twice, producing
>>> garbage output : Duration is always zero and
the "end" bit is never
>>> set. Most Gateways bridging into the PSTN
network have problems
>>> with that. At least this explains why DTMF does
not work with
>>> XMeeting/SIP.
>>>
>>> For the solution: It is certainly easy to fix
this within
>>> SIPConnection. But I just wonder whether it
would not be more
>>> elegant to handle this in the media patch
itself by adjust AddFilter
>>> () ?
>>>
>>> Hannes
>>
>>
>>

------------------------------------------------------------
------------
Check the FAQ before asking! - http://www.
openh323.org/~openh323/fom.cgi
The OpenH323 Project mailing list, using Mailman. To
unsubscribe or
change your subscription options, goto
htt
p://www.openh323.org/mailman/listinfo/openh323
Maintained by Quicknet Technologies, Inc - http://www.quicknet.net
------------------------------------------------------------
------------