List Info

Thread: Re: Fix to missing sysctls on Zaurus




Re: Fix to missing sysctls on Zaurus
country flaguser name
France
2007-08-13 09:45:06
> The last change to sys/arch/arm/include/cpu.h (1.17)
made by robert  
>  broke the machdep.maxspeed and machdep.lidsuspend
sysctls.
>
> Basically robert removed two sysctls (ztsscale and
ztsrawmode)   
> without renumbering the #defines in the CTL_MACHDEP
section. Since   
> sysctl uses the index of the text string to find the
mib the defines  
>  must match the index position of the strings.
>
> The following patch corrects the defines and has been
tested with   
> 4.2 -current.

No, that's not correct, the sysctl values should never
change.

Instead, you should fix CTL_MACHDEP_NAMES by restoring the
removed
entries, even though they are not handled anymore, so that
the final
entries positions match their CPU_xxx value.

Miod


[1]

about | contact  Other archives ( Real Estate discussion Medical topics )