Jonas Borgström wrote:
> Christian Boos wrote:
>
>> Hello again,
>>
>> The blame branch looks ready for integration in
trunk to me, so I'm
>> asking for review (1) and approval.
>>
>
> I've tested the branch a bit now and as far as I can
tell it works ok.
>
> One thing I'm not sure I like yet is the way the age
column in the
> directory browser is colorized. IMHO it's too
eye-catching since the
> rest of the trac ui is pretty colorless.
Agreed, that was one of the things I still wanted to
improve. What I had
in mind:
- first make it configurable, enabled by default but allow
people who
don't like it to turn off the feature
- use a narrow column in front of the age column for the
color scale,
not the background of age column itself
> Maybe coloring border-bottom or something might work
better.
>
Ok, so I tried both approaches and the above, implemented in
r4543,
looks better.
Another idea would be to colorize the text itself , which
also looks
good, but that would conflict with the age being turned into
a link to
the timeline by the #975 changes, as I couldn't find a way
to force the
"color" of the cell to be inherited by the
<a> it contains....
Another fine tuning for the CSS would be to improve the
rendering of the
annotated source code in IExplorer, as the cell borders are
too visible
there.
> Or maybe even dropping the color coding completely and
use icons to
> indicate when the file/folder was last modified. being
able to tell if a
> file was modified today/this week/this month/older/
would be a high
> enough resolution. Using slightly different colors for
"9 months" and
> "10 months" is IMHO just confusing.
>
Well, I'm not sure why you would find that confusing, it's
the same
principle used on the annotation page itself.
I don't see what kind of icons you have in mind in this
case. I can
think of a (new!) icon for the most recent changes, but
don't see which
ones could be used to convey the "today/this week/this
month/older"
concepts. OTOH, a color /code/ could achieve that (e.g.
today => red,
... older => blue).
Also, suggestions for making the color scale nicer and
perhaps more
accessible are welcomed.
In particular, people that can make a test "blame"
Trac available on the
net could check the accessibility of the color scale to
color-blind
people using http://colorfilter.w
ickline.org/ (I suspect the current
scale to be quite bad in that respect).
-- Christian
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the
Google Groups "Trac Development" group.
To post to this group, send email to trac-dev googlegroups.com
To unsubscribe from this group, send email to
trac-dev-unsubscribegooglegroups.com
For more options, visit this group at http://
groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
|