x264 plugin patch and a couple of questions

Hi Michal
I have created a simple patch for new x264 encoder plugin.
It adds the
code which forwards log messages from libx264 to gst log
subsystem,
maybe you will find it usefull.
I also have a couple of questions about this plugin
Why do you need to add one frame period to pts when b-frames
are used?
You use timestamp queue to store/retrive buffer durations.
But the
order of encoded frames can be different from the order of
the
incoming buffers. I think you should lookup a queue entry
with
timestamp equal to the pts of output picture, not just use
the queue
as a ring buffer. Although I am not sure what practical
value those
buffer durations have.
Anyway, thank you for your contribution, it is nice that we
have an
encoder for this very important standard.
---
   Roma

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
gstreamer-devel mailing list
gstreamer-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gstream
er-devel

Hi Roman,

> I have created a simple patch for new x264 encoder
plugin. It adds the
> code which forwards log messages from libx264 to gst
log subsystem,
> maybe you will find it usefull.

	than you. It is indeed useful. I will adapt the patch
little bit to
match style of other gstreamer plugins.

> I also have a couple of questions about this plugin
> Why do you need to add one frame period to pts when
b-frames are used?
> You use timestamp queue to store/retrive buffer
durations. But the
> order of encoded frames can be different from the order
of the
> incoming buffers. I think you should lookup a queue
entry with
> timestamp equal to the pts of output picture, not just
use the queue
> as a ring buffer. Although I am not sure what practical
value those
> buffer durations have.

	The queue is used for generating DTS. This is probably not
the best
methos to do so, but it was reasonably easy one. PTS are
retrieved from
the decoder correctly. We use some hack for storing DTS
which are later
used by our mpeg-ts muxer. Packet queue would not be needed,
because
normal GttBuffers can not hold DTS.

	Michal


------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
gstreamer-devel mailing list
gstreamer-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gstream
er-devel

On 3/30/07, Michal Benes <michal.benesitonis.tv> wrote:
> Hi Roman,
>
> > I have created a simple patch for new x264 encoder
plugin. It adds the
> > code which forwards log messages from libx264 to
gst log subsystem,
> > maybe you will find it usefull.
>
>         than you. It is indeed useful. I will adapt the
patch little bit to
> match style of other gstreamer plugins.
>
> > I also have a couple of questions about this
plugin
> > Why do you need to add one frame period to pts
when b-frames are used?
> > You use timestamp queue to store/retrive buffer
durations. But the
> > order of encoded frames can be different from the
order of the
> > incoming buffers. I think you should lookup a
queue entry with
> > timestamp equal to the pts of output picture, not
just use the queue
> > as a ring buffer. Although I am not sure what
practical value those
> > buffer durations have.
>
>         The queue is used for generating DTS. This is
probably not the best
> methos to do so, but it was reasonably easy one. PTS
are retrieved from
> the decoder correctly. We use some hack for storing DTS
which are later
> used by our mpeg-ts muxer. Packet queue would not be
needed, because
> normal GttBuffers can not hold DTS.
>
>         Michal
>
>
I see. Just curios why just you don't use something like a
simple
counter for DTS? If it's too long to explain, please
ignore.
---
   Roma

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
gstreamer-devel mailing list
gstreamer-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gstream
er-devel