Thomas Klausner schrieb:
> On Wed, Jan 31, 2007 at 09:04:08AM -0500, Glenn
Randers-Pehrson wrote:
>> Libpng-1.0.24 and libpng-1.2.16 are available at
>> ftp://ftp.simplesystems.org/pub/png/src
>> and at
>> libpng.sf.net
>>
>> There is no change to the C source files. The
CMakeLists.txt and makefile.nommx
>> scripts are updated.
>
> I'm just learning cmake myself, but this in
> libpng-1.2.16/scripts/CMakeLists.txt lines 151ff. looks
wrong:
>
> if(PNG_SHARED)
> add_library($ SHARED $)
> else(PNG_SHARED)
> add_library(STATIC $)
> endif(PNG_SHARED)
>
> 1) the second add_library has no library name
> 2) a similar (but more correct) copy of this is in
lines 69ff.
>
> When I copy scripts/CMakeLists.txt (unmodified) one
level up and run "cmake .",
> I get:
> You have called ADD_LIBRARY for library png12 without
any source files. This typically indicates a problem with
your CMakeLists.txt file
> -- Configuring done
> CMake Error: Cannot determine link language for target
"png12".
>
This is an erorr in the cmakelists.txt, but I wonder why I
my cmake did
not complain about this 
Maybe I also send glenn a wrong cmakelists.txt
> When I move lines 69ff. below the definition of
libpng_sources,
> it works fine. (This is with cmake-2.4.6, in case it
matters).
> So perhaps the second copy should be fixed and the
first one removed.
>
You're right.
> Another unrelated thing: Neither the .pc nor the
*-config files
> contain an rpath entry (which is needed at least on
Solaris and
> NetBSD).
>
This is because CMakeLists.txt was primarily created for
win32 and I've
not that much knowledge about rpath
Feel free to improve the cmake script.
Christian
------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
png-mng-implement mailing list
png-mng-implement lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-m
ng-implement
|
