This looks weird....

In pngset.c, in the routine png_set_text_2, on line 782,
there is:

       png_textp textp =
&(info_ptr->text[info_ptr->num_text]);

and then later, on line 880, there is:

       info_ptr->text[info_ptr->num_text]= *textp;

and I don't think that textp was changed in between.

(This is in 1.2.16)
I don't think it does any harm, but I'm pretty sure that
it's not right....
-- 
-- Marshall

Marshall Clow     Idio Software   <mailto:marshallidio.com>

It is by caffeine alone I set my mind in motion.
It is by the beans of Java that thoughts acquire speed,
the hands acquire shaking, the shaking becomes a warning.
It is by caffeine alone I set my mind in motion.

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
png-mng-implement mailing list
png-mng-implementlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-m
ng-implement

At 12:59 PM 3/5/2007 -0800, Marshall Clow wrote:
>In pngset.c, in the routine png_set_text_2, on line 782,
there is:
>
>       png_textp textp =
&(info_ptr->text[info_ptr->num_text]);
>
>and then later, on line 880, there is:
>
>       info_ptr->text[info_ptr->num_text]=
*textp;
>
>and I don't think that textp was changed in between.
>
>(This is in 1.2.16)
>I don't think it does any harm, but I'm pretty sure that
it's not right....

Line 880 does appear to be redundant but harmless.

Glenn

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
png-mng-implement mailing list
png-mng-implementlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-m
ng-implement