Problem with MMX and VisStudio

>From the bug tracker at SourceForge.  Perhaps someone
familiar with
the VC projects can answer this.

Submitted By: Nobody/Anonymous (nobody)
Assigned to: Glenn Randers-Pehrson (glennrp)
Summary: Build error 1.2.16 VisStudio MMX optimized

Initial Comment:
Building 1.2.16 with
PNG_ASSEMBLER_CODE_SUPPORTED;PNG_MMX_CODE_SUPPORTED results
in multiple definitions of png_combine_row,
png_do_read_interlace, and png_read_filter_row (and thus
linker error LNK2005 on these functions). 

It appears the #define(s) PNG_HAVE_MMX_COMBINE_ROW,
PNG_HAVE_MMX_READ_INTERLACE, and
PNG_HAVE_MMX_READ_FILTER_ROW are meant to avoid this, but
these are never set to any value in code or the project file
for build "DLL ASM RELEASE". Simply setting these
to extant fixes the problem; I'm bugging only because I
could find no mention of these in the README or project file
itself, and they seem sensible for "DLL ASM
RELEASE" builds.



------------------------------------------------------------
----------

>Comment By: Glenn Randers-Pehrson (glennrp)
Date: 2007-03-09 22:52

Message:
Logged In: YES 
user_id=7859
Originator: NO

I don't see why they aren't getting set at pngconf.h line
1462-4, since
the project is setting PNG_USE_PNGVCRD


------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
png-mng-implement mailing list
png-mng-implementlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-m
ng-implement

Glenn Randers-Pehrson schrieb:
>> >From the bug tracker at SourceForge.  Perhaps
someone familiar with
> the VC projects can answer this.
afaics PNG_HAVE_MMX_COMBINE_ROW is nowhere defined and
therefore also 
png_combine_row() from pngrutil.c is used.
Maybe there it should be PNG_HAVE_ASSEMBLER_COMBINE_ROW
instead?

I suggest removing the vcproj files and switch to cmake -
then you don't 
get such problems with wrong vcproj files anymore 

Christian


------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
png-mng-implement mailing list
png-mng-implementlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-m
ng-implement