Re: newforms-admin: allow_tags and autoescape

On Fri, 2007-12-14 at 09:29 -0500, Karen Tracey wrote:
[...]

> Looks like a bug in newforms-admin to me. Seems that
somehow the fix
> for this on trunk (changeset 6703) didn't get merged
into the
> newforms-admin branch.  newforms-admin has code to
check the setting
> of allow_tags, so I believe it is intended to work
there.  If you
> can't find an already open ticket for this, I'd open
one. 

Yeah, that's going to happen sometimes, unfortunately. We're
trying hard
not to change (trunk) admin any more than necessary and only
apply
non-showstopper fixes to the branch. The auto-escaping
changes were one
of those cases where it couldn't be helped, though, and some
things
(particularly ones like this where it was only fixed after
the main
patch was applied) might have fallen through the cracks.

Definitely open a ticket for this so it doesn't get
forgotten next time
Joseph wants to do some relatively easy patch application.

Regards,
Malcolm

-- 
What if there were no hypothetical questions? 
http://www.pointy-s
tick.com/blog/


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the
Google Groups "Django users" group.
To post to this group, send email to django-usersgooglegroups.com
To unsubscribe from this group, send email to
django-users-unsubscribegooglegroups.com
For more options, visit this group at htt
p://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---

Hi!

I could not find an open ticket so I open it myself ;)
http://code
.djangoproject.com/ticket/6226

I could write the patch, but I don't know what is the best
approach,
if we must port allow_tags or if the function should return
a
SafeString instance. Even breaking backward compatibility, I
think to
return a SafeString smarter ;)

Thanks for the help,
Best regards.

--
Michel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the
Google Groups "Django users" group.
To post to this group, send email to django-usersgooglegroups.com
To unsubscribe from this group, send email to
django-users-unsubscribegooglegroups.com
For more options, visit this group at htt
p://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---