file handling, open_basedir for 4.7?

Whats the consensus on supporting open_basedir for 4.7. I
have one issue
open with that I'd appreciate some external testing on...
http://drupal.org/node/59
61

If open_basedir support is not critical for 4.7 I'll
downgrade the bug.
Regardless I'd like to have it working. So if you have time
for patch
review please poke at it.

IMHO it is critical, Dries pointed out that Drupal should
aim to be
working at least on the small hosted environments, where
open_basedir
issues are of concern. This bugfix is long overdue.

Goba

Darrel O'Pry wrote:
> Whats the consensus on supporting open_basedir for 4.7.
I have one issue
> open with that I'd appreciate some external testing
on...
> http://drupal.org/node/59
61
> 
> If open_basedir support is not critical for 4.7 I'll
downgrade the bug.
> Regardless I'd like to have it working. So if you have
time for patch
> review please poke at it.
> 

I've made some more headway, but ran into one of those
collateral
issues....

php has its own garbage collection for upload_tmp_dir....
Since my solution requires moving a file out of php's
upload_tmp_dir to 
Drupal's tmp dir, functions that quit or don't complete
leave a hanging
file in drupal's tmp dir... 

Is system_cron a good place for this garbage collection?

.darrel.


On Thu, 2006-02-23 at 17:52 +0100, Gabor Hojtsy wrote:
> IMHO it is critical, Dries pointed out that Drupal
should aim to be
> working at least on the small hosted environments,
where open_basedir
> issues are of concern. This bugfix is long overdue.
> 
> Goba
> 
> Darrel O'Pry wrote:
> > Whats the consensus on supporting open_basedir for
4.7. I have one issue
> > open with that I'd appreciate some external
testing on...
> > http://drupal.org/node/59
61
> > 
> > If open_basedir support is not critical for 4.7
I'll downgrade the bug.
> > Regardless I'd like to have it working. So if you
have time for patch
> > review please poke at it.
> > 
> 
> 

Darrel O'Pry wrote:
> I've made some more headway, but ran into one of those
collateral
> issues....
> 
> php has its own garbage collection for
upload_tmp_dir....
> Since my solution requires moving a file out of php's
upload_tmp_dir to 
> Drupal's tmp dir, functions that quit or don't
complete leave a hanging
> file in drupal's tmp dir... 
> 
> Is system_cron a good place for this garbage
collection?

IMHO functions which can detect malfunctions should remove
the uploaded
files (ie. my patch included a file remove action for the
locale upload,
since the file is not needed after the import is done).
Unexpected halts
will leave files there, for sure... Hm...

Goba

On Sat, 2006-02-25 at 10:56 +0100, Gabor Hojtsy wrote:
> Darrel O'Pry wrote:
> > I've made some more headway, but ran into one of
those collateral
> > issues....
> > 
> > php has its own garbage collection for
upload_tmp_dir....
> > Since my solution requires moving a file out of
php's upload_tmp_dir to 
> > Drupal's tmp dir, functions that quit or don't
complete leave a hanging
> > file in drupal's tmp dir... 
> > 
> > Is system_cron a good place for this garbage
collection?
> 
> IMHO functions which can detect malfunctions should
remove the uploaded
> files (ie. my patch included a file remove action for
the locale upload,
> since the file is not needed after the import is done).
Unexpected halts
> will leave files there, for sure... Hm...
> 
> Goba


I've got normal operation working at this point... I'll
review your
patch, and try to implement the explicit garbage
collection... I still
feel a need for a regular garbage day though... I  assume 
there are web
server and OS level errors I cannot catch from inside of php
that may
halt the execution of drupal, and leave files hanging in the
temp dir.

Darrel O'Pry wrote:
> feel a need for a regular garbage day though... I 
assume  there are web
> server and OS level errors I cannot catch from inside
of php that may
> halt the execution of drupal, and leave files hanging
in the temp dir.

True.

Gabor