MySQL 5.0.12+ bugs (was Re: enterprise needs)

On Mon, 27 Feb 2006 23:30:57 -0500  Walt Daniels wrote:

> I think there are bugs which deserve a similar high
priority, e.g.
> the MySQL 5.12+ bug.

there's no 1 bug.  this bug is spread out over numerous
contrib
modules.  the best summary and solution (that i've seen) is
described
here:

http://dru
pal.org/node/43735#comment-92865

starbow (the author of that post) and i have submitted
patches to the
event, image, taxonomy, and project modules.  so far, the
one for
event was applied, but none of the others have been
committed (yet).
there are probably other modules where this is a problem
(e.g. http://drupal.org/node/5
1696), but we've only found/fixed this
bug for the modules we're actively using.

the solution is usually very easy: you just have to re-order
the
tables in a SELECT query so that if you're JOIN'ing w/ the

table, that it comes first.  otherwise, db_rewrite_sql()
will break
SQL standards compliance if you enable any of the node
access modules
(node_privacy_byrole, simple_access, taxonomy_access, etc),
since they
add an "INNER JOIN  ON na.nid =
n.nid" before the "
n" in the query.

it's really just up to each module maintainer to apply
these patches
that already exist, or, in cases where there's no patch
yet, a
relatively trivial change to the code can get their module
to work
with MySQL 5.0.12+.  i'd be happy to help folks test
patches to
various modules if needed.

-derek


p.s. for the interested reader, here are links to the
not-yet-applied
patches:

image -- http://drupal.org/node/4
9433
project -- http://drupal.org/node/5
0572
taxonomy -- http://drupal.org/node/4
9430

On Tue, 28 Feb 2006 02:39:13 -0600  Derek Wright wrote:

> there's no 1 bug.

however, a single patch will fix the vast majority of the
problems:

http://drupal.org/node/5
1850
http://dru
pal.org/node/51850#comment-78069 (#16, includes the
patch)

if a core maintainer could apply chx's
db_rewrite_nail_2.patch, that'd
be great.  the various contrib maintainers will still have
to patch
their 4.6 modules if they want to support MySQL 5.0.12+, but
at least
this won't really be a problem in 4.7 anymore (except
modules that do
implicit joins, most of which are in the process of being
fixed).

thanks to everyone who's making this happen, especially chx
for the
fix!

-derek