On 28-Feb-06, at 6:35 PM, Derek Wright wrote:
>
> The Drupal coding standards (http://drupal.org/node/318
) doesn't
> explicitly list this point. In addition to .php files
using:
>
> // $Id$
>
> it seems like .mysql and .pgsql files should also
include something
> like this:
>
> -- $Id$
+1
>
> Knowing the exact revision of a .mysql file seems just
as handy as
> knowing it for source (.php, .module or .inc) files.
>
> Upon further inspection, I see that this has now been
done in
> core/database/database.* in HEAD. Nice work, Markus
and Dries,
> thanks.
>
> a) I'd like to encourage all module developers on this
list to add
> this comment to any .mysql and .pgsql files in their
own module(s).
well, as of 4.7 - folks can use .install files instead... so
(hopefully) there won't be any *.*sql files any more
> b) We should update the coding standards page about
this. I'd just
> add a comment to the page, but it seems better to have
it in the body
> of the node, instead. What's the best way for me to
help make that
> happen? I submitted an issue to the Documentation
project's
> "Developer Guide" component... is that the
desired behavior?
I believe you can edit the page directly ... but i'll defer
to a
documentation team type ...
--
James Walker :: http://walkah.net/
|