Some issues and their fixes with Drupal 4.6.6 and PostgreSQL

Hello All,

We ran into few issues when running Drupal 4.6.6 with
PostgreSQL. The 
issue, in general, seems to be with some queries in some of
the modules 
that attempted to insert a blank string ('') into an
integer field.

The modules affected are: user.module and node.module from
Drupal Core, 
and flexinode module.

I found that this issue has been discussed already at 
http://drupal.org/node/
27870.

I have a patch that fixes this issue reasonably. Please let
me know how 
I should go about contributing it. Perhaps I could post the
patch 
somewhere - either on this list or on one of the forums on
drupal.org - 
and then one of the contributors can propagate it to the
source code.

Also, what is best place to post a patch for the fix in
flexinode module?

Thanks,
Nimish

First, to submit a patch: http://drupal.org/node/2
2568

> I have a patch that fixes this issue reasonably. Please
let me know how
> I should go about contributing it. Perhaps I could post
the patch
> somewhere - either on this list or on one of the forums
on drupal.org -
> and then one of the contributors can propagate it to
the source code.

I'm sure nobody would mind you posting your fix to the
list.  Though
that's not technically the way to submit a bug fix, it's a
nice thing
to offer those of us who'll not likely benefit from your
work lest you
apply it to 4.7 and it's accepted.

Just send us an URL with your fix and tell us about it. 
Since
Drupal's in 4.7 mode right now, your fix may get slotted
for limbo
land.  But, if you can hone your fix for 4.7, that would be
nice.

--

Jason A. Nunnelley
----------------------------------------
http://www.jasonn.com/

Hello Nimish

It is unlikely that bug fixes against 4.6.x would be
accepted, simply because
we try to restrict fixes to stable releases to secruity
fixes only.

However, you can always file a bug by registering for an
account at drupal.org
and then creating an issue against the below mentioned
modules and attaching
a patch in unidiff format (read the Drupal Handbook for more
details on how
to create patches).

More importantly, you should check if  the latest 4.7
release candidate has
the same problem, and submit a patch for that. 4.7 is around
the corner, and
we need all the fixes we can for it.

Thanks and regards.

On 4/19/06, Nimish Pachapurkar <npacspikesource.com> wrote:
> Hello All,
>
> We ran into few issues when running Drupal 4.6.6 with
PostgreSQL. The
> issue, in general, seems to be with some queries in
some of the modules
> that attempted to insert a blank string ('') into an
integer field.
>
> The modules affected are: user.module and node.module
from Drupal Core,
> and flexinode module.
>
> I found that this issue has been discussed already at
> http://drupal.org/node/
27870.
>
> I have a patch that fixes this issue reasonably. Please
let me know how
> I should go about contributing it. Perhaps I could post
the patch
> somewhere - either on this list or on one of the forums
on drupal.org -
> and then one of the contributors can propagate it to
the source code.
>
> Also, what is best place to post a patch for the fix in
flexinode module?
>
> Thanks,
> Nimish
>

JasonN wrote:
> First, to submit a patch: http://drupal.org/node/2
2568
> 
>> I have a patch that fixes this issue reasonably.
Please let me know how
>> I should go about contributing it. Perhaps I could
post the patch
>> somewhere - either on this list or on one of the
forums on drupal.org -
>> and then one of the contributors can propagate it
to the source code.
> 
> I'm sure nobody would mind you posting your fix to the
list.  Though
> that's not technically the way to submit a bug fix,
it's a nice thing
> to offer those of us who'll not likely benefit from
your work lest you
> apply it to 4.7 and it's accepted.
> 
> Just send us an URL with your fix and tell us about it.
 Since
> Drupal's in 4.7 mode right now, your fix may get
slotted for limbo
> land.  But, if you can hone your fix for 4.7, that
would be nice.
>

Unfortunately, I do not have a externally available URL for 
demonstrating the fix.

I will see if I can try out Drupal 4.7.x and verify if the
bug exists 
there also.

Thanks,
Nimish

> --
> 
> Jason A. Nunnelley
> ----------------------------------------
> http://www.jasonn.com/

> Unfortunately, I do not have a externally available URL
for
> demonstrating the fix.

You do not have to demonstrate the fix. You have  to provide
a) a description of the problem
b) a patch that has the fix.

These are best done via opening an issue on drupal.org
against
the appropriate project(s).

This way they will be tracked and have the best chance of
gaining
visibility and being acted upon as well as having followups
by
others (reports on success to reproduce the issue, people
who
had it fixed, improvements to your fix, ...etc.)

> I will see if I can try out Drupal 4.7.x and verify if
the bug exists
> there also.

If you find it there, please be quick to provide a fix. It
has a very
good chance for making it with the first 4.7 release.

On 20 Apr 2006, at 03:11, Khalid B wrote:
> It is unlikely that bug fixes against 4.6.x would be
accepted,  
> simply because
> we try to restrict fixes to stable releases to secruity
fixes only.

This information is incorrect.

The Drupal 4.6 branch is being maintained and fixes are
being  
committed.  (See the release announcements for details.)  We
are,  
however, slightly more conservative with patches that fix
bugs in  
Drupal 4.6.  Given that your patches are tested and
supported by a  
number of people, they can make it into the next Drupal 4.6 

maintenance release.

So best to submit your patch to the issue tracker and to
rally up  
some people to thumb it up.

--
Dries Buytaert  ::  http://www.buytaert.net/

"Dries Buytaert" wrote:

> So best to submit your patch to the issue tracker and
to rally up some people
> to thumb it up.

Respectfully, this sounds likek a problem.

If a patch fixes a bug, and someone has taken the time to
spot the bug, fix
the bug, and make a patch, then why do they also then need
to engage in
personality politics to get the fix applied?

This statement reads a bit like  "Well, even you fix a
bug, we may not apply
the fix if we don't like you."

That's an odd method of development.  But it surely
explains some things.

Or did I mis-read?  Or did you mis-write?
--
Gary

On 4/20/06, Dries Buytaert <dries.buytaertgmail.com> wrote:
>
> On 20 Apr 2006, at 03:11, Khalid B wrote:
> > It is unlikely that bug fixes against 4.6.x would
be accepted,
> > simply because
> > we try to restrict fixes to stable releases to
secruity fixes only.
>
> This information is incorrect.
>
> The Drupal 4.6 branch is being maintained and fixes are
being
> committed.  (See the release announcements for
details.)  We are,
> however, slightly more conservative with patches that
fix bugs in
> Drupal 4.6.  Given that your patches are tested and
supported by a
> number of people, they can make it into the next Drupal
4.6
> maintenance release.
>
> So best to submit your patch to the issue tracker and
to rally up
> some people to thumb it up.

I was merely reiterating our historical practice to date,
which is
basically what I said. See for example Dries' comment and
closing an issue as won't fix.
http://dru
pal.org/node/43712#comment-68805

However, this is in the past, and things have changed now.
We have
two more committers to core, and people designated for
specific
branches.

This means we have more capacity to maintain the previous
branch
than we had before.

So, if this is a change in policy that we should consider
going forward,
then that is a good thing to have. We improve things as we
move forward
including policies and processes.

I have opened an issue on Drupal.org and attached the patch
to it.

http://drupal.org/node/6
0894

The patch for flexinode is actually different. It had to do
with an 
empty where clause being appended to the query in one of the
contrib 
files. I misspoke earlier when I said that this module also
suffers from 
the PostgreSQL problem.

I have created an issue for the flexinode problem and
attached a patch 
as well.

http://drupal.org/node/6
0901

Thanks to all for directing me to the right place.

- Nimish


Khalid B wrote:
>> Unfortunately, I do not have a externally available
URL for
>> demonstrating the fix.
> 
> You do not have to demonstrate the fix. You have  to
provide
> a) a description of the problem
> b) a patch that has the fix.
> 
> These are best done via opening an issue on drupal.org
against
> the appropriate project(s).
> 
> This way they will be tracked and have the best chance
of gaining
> visibility and being acted upon as well as having
followups by
> others (reports on success to reproduce the issue,
people who
> had it fixed, improvements to your fix, ...etc.)
> 
>> I will see if I can try out Drupal 4.7.x and verify
if the bug exists
>> there also.
> 
> If you find it there, please be quick to provide a fix.
It has a very
> good chance for making it with the first 4.7 release.