dct-test exit deprecated

svn ci -m'exit remapped for test infastructure'


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

Hi

On Sat, Mar 31, 2007 at 07:40:55AM -0400, Marc Hoffman
wrote:
Content-Description: message body text
> 
> svn ci -m'exit remapped for test infastructure'
> 

Content-Description: exit deprecated
> Index: dct-test.c
>
============================================================
=======
> --- dct-test.c	(revision 8564)
> +++ dct-test.c	(working copy)
>  -40,6 +40,7 
>  #endif
>  
>  #undef printf
> +#undef exit
>  

simply putting a return after the call to help() would be
simpler

[...]

-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself
and study your
own failings. Then you will forget your anger. -- Epictetus

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

Michael Niedermayer writes:
 > Hi
 > 
 > On Sat, Mar 31, 2007 at 07:40:55AM -0400, Marc Hoffman
wrote:
 > Content-Description: message body text
 > > 
 > > svn ci -m'exit remapped for test infastructure'
 > > 
 > 
 > Content-Description: exit deprecated
 > > Index: dct-test.c
 > >
============================================================
=======
 > > --- dct-test.c	(revision 8564)
 > > +++ dct-test.c	(working copy)
 > >  -40,6 +40,7 
 > >  #endif
 > >  
 > >  #undef printf
 > > +#undef exit
 > >  
 > 
 > simply putting a return after the call to help() would
be simpler
 > 

I did that first then realized that this is how we were
handling
printf so I decided to keep it in consistent.

Do you really want it changed back to return?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

Michael Niedermayer writes:
 > Hi
 > 
 > On Sat, Mar 31, 2007 at 07:40:55AM -0400, Marc Hoffman
wrote:
 > Content-Description: message body text
 > > 
 > > svn ci -m'exit remapped for test infastructure'
 > > 
 > >  
 > 
 > simply putting a return after the call to help() would
be simpler
 > 

removing call to exit it is illegal.


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

Hi

On Sat, Mar 31, 2007 at 09:24:36AM -0400, Marc Hoffman
wrote:
Content-Description: message body text
> Michael Niedermayer writes:
>  > Hi
>  > 
>  > On Sat, Mar 31, 2007 at 07:40:55AM -0400, Marc
Hoffman wrote:
>  > Content-Description: message body text
>  > > 
>  > > svn ci -m'exit remapped for test
infastructure'
>  > > 
>  > >  
>  > 
>  > simply putting a return after the call to help()
would be simpler
>  > 
> 
> removing call to exit it is illegal.

looks ok

[...]
-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of
the fool.
-- Epicurus

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Sat, Mar 31, 2007 at 06:15:09PM +0200, Michael
Niedermayer wrote:
> 
> On Sat, Mar 31, 2007 at 09:24:36AM -0400, Marc Hoffman
wrote:
> > Michael Niedermayer writes:
> >  > 
> >  > On Sat, Mar 31, 2007 at 07:40:55AM -0400,
Marc Hoffman wrote:
> >  > > 
> >  > > svn ci -m'exit remapped for test
infastructure'
> >  > 
> >  > simply putting a return after the call to
help() would be simpler
> > 
> > removing call to exit it is illegal.
> 
> looks ok

Applied.

Note: Please create your patches from the root of the source
treee, it's
more convenient for applying them.

Diego
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel