fix unused variable warning in faanidct.c

$subj

regards,
mark

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox wrote:
> $subj

rejected, mixing declaraions and statements

[...]
-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact
solution to an
approximation. Benchmarking OTOH is finding an approximation
of the exact

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 5, 2008 at 10:56 PM, Michael Niedermayer
<michaelnigmx.at>
wrote:

> On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox
wrote:
> > $subj
>
> rejected, mixing declaraions and statements
>

fixed.


> [...]
> --
> Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Complexity theory is the science of finding the exact
solution to an
> approximation. Benchmarking OTOH is finding an
approximation of the exact
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
>
iD8DBQFHzopaYR7HhwQLD6sRArCRAKCOCViTmxbFqasumkAyXOfFSLZD+wCg
jEOQ
> r4LjwSIj1xieDpEiftzNq9Q=
> =5XVe
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-develmplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

>

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 05, 2008 at 11:07:58PM +1100, mark cox wrote:
> On Wed, Mar 5, 2008 at 10:56 PM, Michael Niedermayer
<michaelnigmx.at>
> wrote:
> 
> > On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox
wrote:
> > > $subj
> >
> > rejected, mixing declaraions and statements
> >
> 
> fixed.

Now it wont compile anymore with the alternative rotation as
the variable
would be missing.

[...]
-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my
tongue.
-- Xenocrates

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 5, 2008 at 11:33 PM, Michael Niedermayer
<michaelnigmx.at>
wrote:

> On Wed, Mar 05, 2008 at 11:07:58PM +1100, mark cox
wrote:
> > On Wed, Mar 5, 2008 at 10:56 PM, Michael
Niedermayer <michaelnigmx.at>
> > wrote:
> >
> > > On Wed, Mar 05, 2008 at 10:22:04PM +1100,
mark cox wrote:
> > > > $subj
> > >
> > > rejected, mixing declaraions and statements
> > >
> >
> > fixed.
>
> Now it wont compile anymore with the alternative
rotation as the variable
> would be missing.
>


There is no compile switch to enable #if 0.! Those variables
are only used
within #if 0 block.

Regards,
mark


>
> [...]
> --
> Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I have often repented speaking, but never of holding my
tongue.
> -- Xenocrates
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
>
iD8DBQFHzpMtYR7HhwQLD6sRAry0AJ49+vMyQ4ziKLq1Qq5jre53IBI5zwCf
cVfF
> 68Ao6meClxz3wxkoPLKEHcs=
> =Pjr/
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-develmplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 05, 2008 at 11:40:04PM +1100, mark cox wrote:
> On Wed, Mar 5, 2008 at 11:33 PM, Michael Niedermayer
<michaelnigmx.at>
> wrote:
> 
> > On Wed, Mar 05, 2008 at 11:07:58PM +1100, mark cox
wrote:
> > > On Wed, Mar 5, 2008 at 10:56 PM, Michael
Niedermayer <michaelnigmx.at>
> > > wrote:
> > >
> > > > On Wed, Mar 05, 2008 at 10:22:04PM
+1100, mark cox wrote:
> > > > > $subj
> > > >
> > > > rejected, mixing declaraions and
statements
> > > >
> > >
> > > fixed.
> >
> > Now it wont compile anymore with the alternative
rotation as the variable
> > would be missing.
> >
> 
> 
> There is no compile switch to enable #if 0.! Those
variables are only used
> within #if 0 block.

Before your patch the #if 0 block did work if one changed
the 0 to a 1
afterwards the "user" would have to debug it
first.

if you want to get rid of the warning add a unused
attribute

[...]

-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the
same ideas make
their appearance in the world. -- Aristotle

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 5, 2008 at 11:48 PM, Michael Niedermayer
<michaelnigmx.at>
wrote:

> On Wed, Mar 05, 2008 at 11:40:04PM +1100, mark cox
wrote:
> > On Wed, Mar 5, 2008 at 11:33 PM, Michael
Niedermayer <michaelnigmx.at>
> > wrote:
> >
> > > On Wed, Mar 05, 2008 at 11:07:58PM +1100,
mark cox wrote:
> > > > On Wed, Mar 5, 2008 at 10:56 PM, Michael
Niedermayer <
> michaelnigmx.at>
> > > > wrote:
> > > >
> > > > > On Wed, Mar 05, 2008 at 10:22:04PM
+1100, mark cox wrote:
> > > > > > $subj
> > > > >
> > > > > rejected, mixing declaraions and
statements
> > > > >
> > > >
> > > > fixed.
> > >
> > > Now it wont compile anymore with the
alternative rotation as the
> variable
> > > would be missing.
> > >
> >
> >
> > There is no compile switch to enable #if 0.! Those
variables are only
> used
> > within #if 0 block.
>
> Before your patch the #if 0 block did work if one
changed the 0 to a 1
> afterwards the "user" would have to debug it
first.
>
> if you want to get rid of the warning add a unused
attribute
>

Like attached?

Regards,
mark


>
> [...]
>
> --
> Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB
>
> it is not once nor twice but times without number that
the same ideas make
> their appearance in the world. -- Aristotle
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
>
iD8DBQFHzpapYR7HhwQLD6sRAquPAKCINjOvsJz+NnkvAHf8CievJ3Nr2gCf
S31g
> o8lLAzBEQKV+UZtQriz5960=
> =xQGz
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-develmplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

>

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Thu, Mar 06, 2008 at 12:13:00AM +1100, mark cox wrote:
> On Wed, Mar 5, 2008 at 11:48 PM, Michael Niedermayer
<michaelnigmx.at>
> wrote:
> 
> > On Wed, Mar 05, 2008 at 11:40:04PM +1100, mark cox
wrote:
> > > On Wed, Mar 5, 2008 at 11:33 PM, Michael
Niedermayer <michaelnigmx.at>
> > > wrote:
> > >
> > > > On Wed, Mar 05, 2008 at 11:07:58PM
+1100, mark cox wrote:
> > > > > On Wed, Mar 5, 2008 at 10:56 PM,
Michael Niedermayer <
> > michaelnigmx.at>
> > > > > wrote:
> > > > >
> > > > > > On Wed, Mar 05, 2008 at
10:22:04PM +1100, mark cox wrote:
> > > > > > > $subj
> > > > > >
> > > > > > rejected, mixing declaraions
and statements
> > > > > >
> > > > >
> > > > > fixed.
> > > >
> > > > Now it wont compile anymore with the
alternative rotation as the
> > variable
> > > > would be missing.
> > > >
> > >
> > >
> > > There is no compile switch to enable #if 0.!
Those variables are only
> > used
> > > within #if 0 block.
> >
> > Before your patch the #if 0 block did work if one
changed the 0 to a 1
> > afterwards the "user" would have to
debug it first.
> >
> > if you want to get rid of the warning add a unused
attribute
> >
> 
> Like attached?

If you move the unused vars to their own line then yes.

[...]
-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the
same ideas make
their appearance in the world. -- Aristotle

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox wrote:
> $subj

I have the following in my local tree since yesterday. 
Michael, OK to
commit?

Diego

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

Hi

On Wed, Mar 05, 2008 at 04:12:26PM +0100, Diego Biurrun
wrote:
> On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox
wrote:
> > $subj
> 
> I have the following in my local tree since yesterday. 
Michael, OK to
> commit?

without the // and with a unused yes

[...]
-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the
same ideas make
their appearance in the world. -- Aristotle

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Thu, Mar 6, 2008 at 3:18 AM, Michael Niedermayer
<michaelnigmx.at>
wrote:

> Hi
>
> On Wed, Mar 05, 2008 at 04:12:26PM +0100, Diego Biurrun
wrote:
> > On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox
wrote:
> > > $subj
> >
> > I have the following in my local tree since
yesterday.  Michael, OK to
> > commit?
>
> without the // and with a unused yes
>

Patch like above attached.

Regards,
mark


> [...]
> --
> Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB
>
> it is not once nor twice but times without number that
the same ideas make
> their appearance in the world. -- Aristotle
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
>
iD8DBQFHzsfvYR7HhwQLD6sRApKRAJ9OgiqU+kSQo56VscNfCz25wyPH2wCf
RJLi
> g0DNJyUlzbIwJZ5n4NAt/PQ=
> =S8wv
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-develmplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

>

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Thu, Mar 06, 2008 at 09:13:45AM +1100, mark cox wrote:
> On Thu, Mar 6, 2008 at 3:18 AM, Michael Niedermayer
<michaelnigmx.at>
> wrote:
> 
> > Hi
> >
> > On Wed, Mar 05, 2008 at 04:12:26PM +0100, Diego
Biurrun wrote:
> > > On Wed, Mar 05, 2008 at 10:22:04PM +1100,
mark cox wrote:
> > > > $subj
> > >
> > > I have the following in my local tree since
yesterday.  Michael, OK to
> > > commit?
> >
> > without the // and with a unused yes
> >
> 
> Patch like above attached.

ok

[...]
-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of
the fool.
-- Epicurus

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 05, 2008 at 05:18:56PM +0100, Michael
Niedermayer wrote:
> 
> On Wed, Mar 05, 2008 at 04:12:26PM +0100, Diego Biurrun
wrote:
> > On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox
wrote:
> > > $subj
> > 
> > I have the following in my local tree since
yesterday.  Michael, OK to
> > commit?
> 
> without the // and with a unused yes

What's so bad about commenting out the variables?

Diego
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

Diego Biurrun <diegobiurrun.de> writes:

> On Wed, Mar 05, 2008 at 05:18:56PM +0100, Michael
Niedermayer wrote:
>> 
>> On Wed, Mar 05, 2008 at 04:12:26PM +0100, Diego
Biurrun wrote:
>> > On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark
cox wrote:
>> > > $subj
>> > 
>> > I have the following in my local tree since
yesterday.  Michael, OK to
>> > commit?
>> 
>> without the // and with a unused yes
>
> What's so bad about commenting out the variables?

What purpose does a commented out variable serve?

-- 
Måns Rullgård
mansmansr.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Thu, Mar 06, 2008 at 12:00:05AM +0000, Måns Rullgård
wrote:
> Diego Biurrun <diegobiurrun.de> writes:
> 
> > On Wed, Mar 05, 2008 at 05:18:56PM +0100, Michael
Niedermayer wrote:
> >> 
> >> On Wed, Mar 05, 2008 at 04:12:26PM +0100,
Diego Biurrun wrote:
> >> > On Wed, Mar 05, 2008 at 10:22:04PM +1100,
mark cox wrote:
> >> > > $subj
> >> > 
> >> > I have the following in my local tree
since yesterday.  Michael, OK to
> >> > commit?
> >> 
> >> without the // and with a unused yes
> >
> > What's so bad about commenting out the variables?
> 
> What purpose does a commented out variable serve?

The same purpose that a block of '#if 0' code serves.  If
you enable the
'#if 0' block again, you put the variable back...

Diego
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Thu, Mar 06, 2008 at 01:05:56AM +0100, Diego Biurrun
wrote:
> On Thu, Mar 06, 2008 at 12:00:05AM +0000, Måns Rullgård
wrote:
> > Diego Biurrun <diegobiurrun.de> writes:
> > 
> > > On Wed, Mar 05, 2008 at 05:18:56PM +0100,
Michael Niedermayer wrote:
> > >> 
> > >> On Wed, Mar 05, 2008 at 04:12:26PM +0100,
Diego Biurrun wrote:
> > >> > On Wed, Mar 05, 2008 at 10:22:04PM
+1100, mark cox wrote:
> > >> > > $subj
> > >> > 
> > >> > I have the following in my local
tree since yesterday.  Michael, OK to
> > >> > commit?
> > >> 
> > >> without the // and with a unused yes
> > >
> > > What's so bad about commenting out the
variables?
> > 
> > What purpose does a commented out variable serve?
> 
> The same purpose that a block of '#if 0' code serves. 
If you enable the
> '#if 0' block again, you put the variable back...

No if you enable the '#if 0' block again, you get a
compilation failure, if
the variable has been commented out or removed.

At this point you have to start debuging why it failed ...


[...]

-- 
Michael     GnuPG fingerprint:
9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most
aggravated
form of tyranny and slavery out of the most extreme liberty.
-- Plato

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Thu, Mar 06, 2008 at 01:15:03AM +0100, Michael
Niedermayer wrote:
> On Thu, Mar 06, 2008 at 01:05:56AM +0100, Diego Biurrun
wrote:
> > On Thu, Mar 06, 2008 at 12:00:05AM +0000, Måns
Rullgård wrote:
> > > Diego Biurrun <diegobiurrun.de> writes:
> > > 
> > > > On Wed, Mar 05, 2008 at 05:18:56PM
+0100, Michael Niedermayer wrote:
> > > >> 
> > > >> On Wed, Mar 05, 2008 at 04:12:26PM
+0100, Diego Biurrun wrote:
> > > >> > On Wed, Mar 05, 2008 at
10:22:04PM +1100, mark cox wrote:
> > > >> > > $subj
> > > >> > 
> > > >> > I have the following in my
local tree since yesterday.  Michael, OK to
> > > >> > commit?
> > > >> 
> > > >> without the // and with a unused
yes
> > > >
> > > > What's so bad about commenting out the
variables?
> > > 
> > > What purpose does a commented out variable
serve?
> > 
> > The same purpose that a block of '#if 0' code
serves.  If you enable the
> > '#if 0' block again, you put the variable back...
> 
> No if you enable the '#if 0' block again, you get a
compilation failure, if
> the variable has been commented out or removed.
> 
> At this point you have to start debuging why it failed
...

I would not call this "debugging".  You have to
edit the code anyway to
enable the #if 0 block, enabling one more variable is not
really hard or
much extra work.  Furthermore, if the block gets removed,
the variable
is likely to stay behind.  And it only works with gcc.

But hey, if you prefer it that way, it shall be done that
way...

Diego
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

On Wed, Mar 05, 2008 at 11:20:34PM +0100, Michael
Niedermayer wrote:
> On Thu, Mar 06, 2008 at 09:13:45AM +1100, mark cox
wrote:
> > On Thu, Mar 6, 2008 at 3:18 AM, Michael
Niedermayer <michaelnigmx.at>
> > wrote:
> > 
> > > On Wed, Mar 05, 2008 at 04:12:26PM +0100,
Diego Biurrun wrote:
> > > > On Wed, Mar 05, 2008 at 10:22:04PM
+1100, mark cox wrote:
> > > > > $subj
> > > >
> > > > I have the following in my local tree
since yesterday.  Michael, OK to
> > > > commit?
> > >
> > > without the // and with a unused yes
> > 
> > Patch like above attached.
> 
> ok

Applied.

Diego
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-develmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel