Recent nightly builds crashing @ NS_strlen (caused by myspell.dll)

Since the 20070328 nightly builds of Firefox there have been
numerous
reports of crashing at NS_strlen when loading a page with a
<textarea>. See for example h
ttps://bugzilla.mozilla.org/show_bug.cgi?id=376205
. This has also been affecting Thunderbird. After tracking
this down
to an old myspell.dll presumably left behind by a previous
install of
Minefield from around July 2006 I'm left with a few
questions.

1) How does the spellcheck work if not with myspell.dll? I
think I can
answer that question looking through the build log:
spellcheck.lib is
linked into firefox.lib. However, there are also these
warnings:

Warning: package error or possible missing or unnecessary
file: bin/
components/myspell.dll (packages-static, 310).
Warning: package error or possible missing or unnecessary
file: bin/
components/spellchk.dll (packages-static, 312).

2) Will the underlying problem, if there is one, come back
or is this
dll gone for good &mdash; the warnings merely indicating
a need to
update the packaging code? I see that myspell.dll is still
being
distributed with Firefox2 but haven't seen any evidence of
this being
a problem with the branch.

Lastly, for reference, the crash first appears with the
20070327_0944
hourly. Checkin range: http://tinyurl.com/285dea .

Thanks,

Wildmyron

_______________________________________________
dev-apps-firefox mailing list
dev-apps-firefoxlists.mozilla.org
h
ttps://lists.mozilla.org/listinfo/dev-apps-firefox

Wildmyron wrote:

> 1) How does the spellcheck work if not with
myspell.dll? I think I can
> answer that question looking through the build log:
spellcheck.lib is
> linked into firefox.lib. However, there are also these
warnings:

You are correct, it is now linked into the main firefox or
thunderbird
executable.

> 2) Will the underlying problem, if there is one, come
back or is this
> dll gone for good — the warnings merely
indicating a need to
> update the packaging code? I see that myspell.dll is
still being
> distributed with Firefox2 but haven't seen any evidence
of this being
> a problem with the branch.

Yes, the packaging code needs to be updated. We should
remove myspell.dll
from the packaging list, and add it to the
"removed-files" list, so that
when people upgrade from FF2->FF3 their myspell.dll is
removed.

http://lxr.mozilla.org/mozilla/so
urce/browser/installer/windows/packages-static
http://lxr.mozilla.org/mozilla/sourc
e/browser/installer/unix/packages-static
http://lxr.mozilla.org/mozilla/source/br
owser/installer/removed-files.in

If you're interested in providing a patch, please attach it
to bug 376205.
If you can't, let me know and I'll get to it sometime.

--BDS
_______________________________________________
dev-apps-firefox mailing list
dev-apps-firefoxlists.mozilla.org
h
ttps://lists.mozilla.org/listinfo/dev-apps-firefox

On Apr 5, 6:40 pm, Benjamin Smedberg <benja...smedbergs.us> wrote:
> <snip>
> If you're interested in providing a patch, please
attach it to bug 376205.
> If you can't, let me know and I'll get to it sometime.

Thanks for the clarification. I'll leave the patch to you:
it's 8pm
here, I'm happy I managed to work this much out and I'm even
happier
when I can get Firefox to compile, let alone modify it.

Happy Easter,

Wildmyron


_______________________________________________
dev-apps-firefox mailing list
dev-apps-firefoxlists.mozilla.org
h
ttps://lists.mozilla.org/listinfo/dev-apps-firefox

And on the seventh day Benjamin Smedberg spoke:

>Yes, the packaging code needs to be updated. We should
remove myspell.dll
>from the packaging list, and add it to the
"removed-files" list, so that
>when people upgrade from FF2->FF3 their myspell.dll
is removed.
>
>http://lxr.mozilla.org/mozilla/so
urce/browser/installer/windows/packages-static
>http://lxr.mozilla.org/mozilla/sourc
e/browser/installer/unix/packages-static
>http://lxr.mozilla.org/mozilla/source/br
owser/installer/removed-files.in
>
>If you're interested in providing a patch, please attach
it to bug 376205.
>If you can't, let me know and I'll get to it sometime.

Ben, I've put a patch in your queue.

Simon
-- 
Sunbird/Lightning Website Maintainer:
http://www.m
ozilla.org/projects/calendar
Sunbird/Lightning blog: http://weblog
s.mozillazine.org/calendar
_______________________________________________
dev-apps-firefox mailing list
dev-apps-firefoxlists.mozilla.org
h
ttps://lists.mozilla.org/listinfo/dev-apps-firefox