Re: standards/122051: Add posix_spawn(3)

Thread: Re: standards/122051: Add posix_spawn(3)

Search this list only Search all lists
Re: standards/122051: Add posix_spawn(3)
Netherlands	2008-03-24 13:21:49
Hello Kostik, Thanks a lot for your feedback! * Kostik Belousov gmail.com> wrote: > > It isn't possible to make the structures opague, which is a pity with > > respect to binary compatibility. That's why I've decided to take the > > easy path by inlining most of the get/set routines. > Why ? > > I do not remember any POSIX requirements that would force us to provide > the direct access to the the internals of the attrs. Am I wrong ? > > If this is true, then it would be better to not inline the setters/getters, > and add the padding for the structures just in case. I forgot that we could typedef posix_spawnattr_t and posix_spawn_file_actions_t to a pointer type. That way we wouldn't need any padding. This also prevents a lot of namespace polution. > > This patch still misses a manual page. > FreeBSD has an permit to use the verbatim POSIX specification in its > manual pages, with proper attribution. > See the /usr/share/examples/mdoc/POSIX-copyright I'll take a look at it soon. I will probably store a final diff somewhere online, because the manual pages will make the diff too big to post it in the PR. > > --- lib/libc/gen/Symbol.map > > +++ lib/libc/gen/Symbol.map > > -118,6 +118,7 > > execlp; > > execv; > > execvp; > > + execvpe; > > execvP; > > fmtcheck; > > fmtmsg; > > -220,9 +221,16 > > nrand48; > > opendir; > > pause; > > - posix_madvise; > > - popen; > > pclose; > > + popen; > > + posix_madvise; > > + posix_spawn; > > + posix_spawn_file_actions_addclose; > > + posix_spawn_file_actions_adddup2; > > + posix_spawn_file_actions_addopen; > > + posix_spawn_file_actions_destroy; > > + posix_spawn_file_actions_init; > > + posix_spawnp; > > shm_open; > > shm_unlink; > > pselect; > > These chunks are almost definitely wrong. You shall add new symbols to the > FBSD_1.1 namespace. Fixed. I've attached an updated version of my patch, which should already address all the issues you pointed out. > I have the unfulfilled obligation for the openat() and friends commit. > After I do that, unless somebody else shows the interest in your work, > feel free to ping me. I will. Thanks a lot! -- Ed Schouten 80386.nl> WWW: http://g-rave.nl/
Approximate file size 20510 bytes