802.1Q vlan performance.

Ian FREISLICH wrote:
> Alternatively is there an objection to making this a
kernel
> configuration file option as opposed to leaving it as
an undocumented
> buried treasure?

I see it is an option, just undocumented.

Whitespace mangled:

RCS file: /home/ncvs/src/sys/conf/NOTES,v
retrieving revision 1.1378
diff -u -d -r1.1378 NOTES
--- /usr/src/sys/conf/NOTES       17 Aug 2006 00:37:03 -0000
     1.1378
+++ /usr/src/sys/conf/NOTES       25 Aug 2006 10:03:18 -0000
 -646,6
+646,7 
 #
 device         ether                   #Generic Ethernet
 device         vlan                    #VLAN support (needs
miibus)
+options                VLAN_ARRAY              #Lookup
table for trunk interface
 device         wlan                    #802.11 support
 device         wlan_wep                #802.11 WEP support
 device         wlan_ccmp               #802.11 CCMP support


--
Ian Freislich
_______________________________________________
freebsd-currentfreebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-curre
nt
To unsubscribe, send any mail to
"freebsd-current-unsubscribefreebsd.org"

On Fri, Aug 25, 2006 at 12:04:25PM +0200, Ian FREISLICH
wrote:
I> > Alternatively is there an objection to making
this a kernel
I> > configuration file option as opposed to leaving
it as an undocumented
I> > buried treasure?
I> 
I> I see it is an option, just undocumented.
I> 
I> Whitespace mangled:
I> 
I> RCS file: /home/ncvs/src/sys/conf/NOTES,v
I> retrieving revision 1.1378
I> diff -u -d -r1.1378 NOTES
I> --- /usr/src/sys/conf/NOTES       17 Aug 2006 00:37:03
-0000      1.1378
I> +++ /usr/src/sys/conf/NOTES       25 Aug 2006 10:03:18
-0000
I>  -646,6 +646,7 
I>  #
I>  device         ether                   #Generic
Ethernet
I>  device         vlan                    #VLAN support
(needs miibus)
I> +options                VLAN_ARRAY             
#Lookup table for trunk interface
I>  device         wlan                    #802.11
support
I>  device         wlan_wep                #802.11 WEP
support
I>  device         wlan_ccmp               #802.11 CCMP
support

I'd prefer not to put it into NOTES. When enabled, less
code will
be covered by LINT.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
_______________________________________________
freebsd-currentfreebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-curre
nt
To unsubscribe, send any mail to
"freebsd-current-unsubscribefreebsd.org"

On Friday 25 August 2006 06:11, Gleb Smirnoff wrote:
> On Fri, Aug 25, 2006 at 12:04:25PM +0200, Ian FREISLICH
wrote:
> I> > Alternatively is there an objection to
making this a kernel
> I> > configuration file option as opposed to
leaving it as an undocumented
> I> > buried treasure?
> I> 
> I> I see it is an option, just undocumented.
> I> 
> I> Whitespace mangled:
> I> 
> I> RCS file: /home/ncvs/src/sys/conf/NOTES,v
> I> retrieving revision 1.1378
> I> diff -u -d -r1.1378 NOTES
> I> --- /usr/src/sys/conf/NOTES       17 Aug 2006
00:37:03 -0000      1.1378
> I> +++ /usr/src/sys/conf/NOTES       25 Aug 2006
10:03:18 -0000
> I>  -646,6 +646,7 
> I>  #
> I>  device         ether                   #Generic
Ethernet
> I>  device         vlan                    #VLAN
support (needs miibus)
> I> +options                VLAN_ARRAY             
#Lookup table for trunk interface
> I>  device         wlan                    #802.11
support
> I>  device         wlan_wep                #802.11
WEP support
> I>  device         wlan_ccmp               #802.11
CCMP support
> 
> I'd prefer not to put it into NOTES. When enabled,
less code will
> be covered by LINT.

Bah, GENERIC will cover it then.  All options should be in
NOTES.  If
an option removes code and it's enabled in GENERIC, then
you should put
it in NOTES but comment it out.

-- 
John Baldwin
_______________________________________________
freebsd-currentfreebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-curre
nt
To unsubscribe, send any mail to
"freebsd-current-unsubscribefreebsd.org"

On Fri, Aug 25, 2006 at 10:31:33AM -0400, John Baldwin
wrote:
J> > I> +++ /usr/src/sys/conf/NOTES       25 Aug
2006 10:03:18 -0000
J> > I>  -646,6 +646,7 
J> > I>  #
J> > I>  device         ether                  
#Generic Ethernet
J> > I>  device         vlan                   
#VLAN support (needs miibus)
J> > I> +options                VLAN_ARRAY         
    #Lookup table for trunk interface
J> > I>  device         wlan                   
#802.11 support
J> > I>  device         wlan_wep               
#802.11 WEP support
J> > I>  device         wlan_ccmp              
#802.11 CCMP support
J> > 
J> > I'd prefer not to put it into NOTES. When
enabled, less code will
J> > be covered by LINT.
J> 
J> Bah, GENERIC will cover it then.  All options should
be in NOTES.  If
J> an option removes code and it's enabled in GENERIC,
then you should put
J> it in NOTES but comment it out.

But "device vlan" isn't in GENERIC.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
_______________________________________________
freebsd-currentfreebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-curre
nt
To unsubscribe, send any mail to
"freebsd-current-unsubscribefreebsd.org"

On Friday 25 August 2006 06:11, Gleb Smirnoff wrote:
> On Fri, Aug 25, 2006 at 12:04:25PM +0200, Ian FREISLICH
wrote:
> I> > Alternatively is there an objection to
making this a kernel
> I> > configuration file option as opposed to
leaving it as an undocumented
> I> > buried treasure?
> I> 
> I> I see it is an option, just undocumented.
> I> 
> I> Whitespace mangled:
> I> 
> I> RCS file: /home/ncvs/src/sys/conf/NOTES,v
> I> retrieving revision 1.1378
> I> diff -u -d -r1.1378 NOTES
> I> --- /usr/src/sys/conf/NOTES       17 Aug 2006
00:37:03 -0000      1.1378
> I> +++ /usr/src/sys/conf/NOTES       25 Aug 2006
10:03:18 -0000
> I>  -646,6 +646,7 
> I>  #
> I>  device         ether                   #Generic
Ethernet
> I>  device         vlan                    #VLAN
support (needs miibus)
> I> +options                VLAN_ARRAY             
#Lookup table for trunk interface
> I>  device         wlan                    #802.11
support
> I>  device         wlan_wep                #802.11
WEP support
> I>  device         wlan_ccmp               #802.11
CCMP support
> 
> I'd prefer not to put it into NOTES. When enabled,
less code will
> be covered by LINT.

Bah, GENERIC will cover it then.  All options should be in
NOTES.  If
an option removes code and it's enabled in GENERIC, then
you should put
it in NOTES but comment it out.

-- 
John Baldwin
_______________________________________________
freebsd-currentfreebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-curre
nt
To unsubscribe, send any mail to
"freebsd-current-unsubscribefreebsd.org"

On Fri, Aug 25, 2006 at 10:31:33AM -0400, John Baldwin
wrote:
J> > I> +++ /usr/src/sys/conf/NOTES       25 Aug
2006 10:03:18 -0000
J> > I>  -646,6 +646,7 
J> > I>  #
J> > I>  device         ether                  
#Generic Ethernet
J> > I>  device         vlan                   
#VLAN support (needs miibus)
J> > I> +options                VLAN_ARRAY         
    #Lookup table for trunk interface
J> > I>  device         wlan                   
#802.11 support
J> > I>  device         wlan_wep               
#802.11 WEP support
J> > I>  device         wlan_ccmp              
#802.11 CCMP support
J> > 
J> > I'd prefer not to put it into NOTES. When
enabled, less code will
J> > be covered by LINT.
J> 
J> Bah, GENERIC will cover it then.  All options should
be in NOTES.  If
J> an option removes code and it's enabled in GENERIC,
then you should put
J> it in NOTES but comment it out.

But "device vlan" isn't in GENERIC.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
_______________________________________________
freebsd-currentfreebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-curre
nt
To unsubscribe, send any mail to
"freebsd-current-unsubscribefreebsd.org"

On Friday 25 August 2006 10:56, Gleb Smirnoff wrote:
> On Fri, Aug 25, 2006 at 10:31:33AM -0400, John Baldwin
wrote:
> J> > I> +++ /usr/src/sys/conf/NOTES       25
Aug 2006 10:03:18 -0000
> J> > I>  -646,6 +646,7 
> J> > I>  #
> J> > I>  device         ether                 
 #Generic Ethernet
> J> > I>  device         vlan                  
 #VLAN support (needs miibus)
> J> > I> +options                VLAN_ARRAY    
         #Lookup table for 
trunk interface
> J> > I>  device         wlan                  
 #802.11 support
> J> > I>  device         wlan_wep              
 #802.11 WEP support
> J> > I>  device         wlan_ccmp             
 #802.11 CCMP support
> J> > 
> J> > I'd prefer not to put it into NOTES. When
enabled, less code will
> J> > be covered by LINT.
> J> 
> J> Bah, GENERIC will cover it then.  All options
should be in NOTES.  If
> J> an option removes code and it's enabled in
GENERIC, then you should put
> J> it in NOTES but comment it out.
> 
> But "device vlan" isn't in GENERIC.

Then put the option in and comment it out.  NOTES serves 2
purposes: 1 is to 
provide the basis for LINT, the second is to document the
various options and 
devices.

-- 
John Baldwin
_______________________________________________
freebsd-currentfreebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-curre
nt
To unsubscribe, send any mail to
"freebsd-current-unsubscribefreebsd.org"

On Fri, 25 Aug 2006, Gleb Smirnoff wrote:

> On Fri, Aug 25, 2006 at 10:31:33AM -0400, John Baldwin
wrote:
> J> > I> +++ /usr/src/sys/conf/NOTES       25
Aug 2006 10:03:18 -0000
> J> > I>  -646,6 +646,7 
> J> > I>  #
> J> > I>  device         ether                 
 #Generic Ethernet
> J> > I>  device         vlan                  
 #VLAN support (needs miibus)
> J> > I> +options                VLAN_ARRAY    
         #Lookup table for trunk interface
> J> > I>  device         wlan                  
 #802.11 support
> J> > I>  device         wlan_wep              
 #802.11 WEP support
> J> > I>  device         wlan_ccmp             
 #802.11 CCMP support
> J> >
> J> > I'd prefer not to put it into NOTES. When
enabled, less code will
> J> > be covered by LINT.
> J>
> J> Bah, GENERIC will cover it then.  All options
should be in NOTES.  If
> J> an option removes code and it's enabled in
GENERIC, then you should put
> J> it in NOTES but comment it out.
>
> But "device vlan" isn't in GENERIC.

Only for historical reasons -- at the recent devsummit, I
argued that if_vlan 
should, in fact, be part of our generic ethernet support
code, as vlans have 
become an expected ethernet link layer feature.  I also
argued that tigher 
integration of vlan support into ethernet would help avoid
some of the 
trickier issues in keeping vlan interfaces synchronized to
the set of ethernet 
interfaces, as well as avoiding the mbuf tag overhead, etc. 
I have some hope 
of looking into this once if_startmbuf is off the ground.

Robert N M Watson
Computer Laboratory
University of Cambridge
_______________________________________________
freebsd-currentfreebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-curre
nt
To unsubscribe, send any mail to
"freebsd-current-unsubscribefreebsd.org"