SpamAssassin 3.2 compatiblity

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,


after I saw that there are incompatiblities with SA 3.2 and
FuzzyOcr,
I decided to try to fix them although I'm still very busy
(preparing
for Bachelor thesis).


I made changes and the current SVN version fixes ticket #396
as well
as the good old "Exporter.pm warnings" bug.


There is still another problem though, the formatting of the
rule
descriptions changed in SA 3.2 and I can't seem to get it to
do the
"old" formatting (listing the words etc), the
wrapper screws it up
totally.


I'd be glad if some people could try the SVN version with SA
3.2 and
report back. If someone knows how to fix those ugly output
formatting
problems, tell me. This is a cosmetically issue but it still
looks bad.

If there are any other problems that can be fixed quickly,
tell me and
I'll make those changes in SVN before releasing a bugfix
version for 3.2.


Best regards,


Chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFGWXnkJQIKXnJyDxURAtetAJ9Ec8+BSP0L9ZiGrvlUBjcYy5YoQACg
hQai
5PREZKNNOL7pOs8W1qRAcaI=
=KGla
-----END PGP SIGNATURE-----

_______________________________________________
Devel-spam mailing list
Devel-spamlists.own-hero.net
http://lists.own-hero.net/mailman/listinfo/devel-spam

hi,

> I'd be glad if some people could try the SVN version
with SA 3.2 and
> report back. If someone knows how to fix those ugly
output formatting
> problems, tell me. This is a cosmetically issue but it
still looks bad.

i'm not clear as to what exactly you're seeing, but, fwiw,
with:

   focr svn r130 & sa svn 33x trunk, r541915,

sending/receiving a simple msg w/ just a 'bad' gif
attachment
extracted from focr distro's example
"ocr-gif.eml", the SA-generated
headers report (as viewed in TBird's 'view Message
Source'):

X-Spam-Flag: YES
X-Spam-Checker-Version: SpamAssassin 3.3.0-r534407
(2007-05-02)
X-Spam-Level: !!!!!!!!!!!!!!!!!
X-Spam-Status: score=17.7/4.0 autolearn=spam
X-Spam-Report:
	*  1.2 SARE_GIF_ATTACH FULL: Email has a inline gif
	*  2.5 FUZZY_OCR_CORRUPT_IMG BODY:
	*   14 FUZZY_OCR BODY: Img with common spam text inside
	Words found:
	*      "target" in 1 lines
	"stock" in 2 lines
	"investor" in 1 lines
	"price"
	*       in 2 lines
	"company" in 1 lines
	"recommendation" in 1 lines
	(12
	*      word occurrences found)

hth.

thanks!
_______________________________________________
Devel-spam mailing list
Devel-spamlists.own-hero.net
http://lists.own-hero.net/mailman/listinfo/devel-spam

decoder writes:
> There is still another problem though, the formatting
of the rule
> descriptions changed in SA 3.2 and I can't seem to get
it to do the
> "old" formatting (listing the words etc), the
wrapper screws it up
> totally.
> 
> I'd be glad if some people could try the SVN version
with SA 3.2 and
> report back. If someone knows how to fix those ugly
output formatting
> problems, tell me. This is a cosmetically issue but it
still looks bad.

hi Chris --

if you can cut it down to a small test case that demos just
this problem,
then open a bug on the SpamAssassin bugzilla, we can take a
look. It
could be there's a bug in 3.2.0 regarding the
PerMsgStatus::test_log()
API (and we almost definitely need to define an
"official" way to
do this, anyway).

--j.
_______________________________________________
Devel-spam mailing list
Devel-spamlists.own-hero.net
http://lists.own-hero.net/mailman/listinfo/devel-spam

decoder wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> after I saw that there are incompatiblities with SA 3.2
and FuzzyOcr,
> I decided to try to fix them although I'm still very
busy (preparing
> for Bachelor thesis).
>
>
> There is still another problem though, the formatting
of the rule
> descriptions changed in SA 3.2 and I can't seem to get
it to do the
> "old" formatting (listing the words etc), the
wrapper screws it up
> totally.
>   
Hi

I fixed this for me - it's a dirty hack but it seems to work
for quite a 
while now by just padding every line to 45 with spaces and
removing the 
newlines.

For example:

Instead of
push( cfound, ""$w" in $wcnt lines"
);

I'm using:

my $text = ""$w" in $wcnt lines";
$text .= " " x (45-length($text));
push( cfound, $text );

Dont forget the initial line and the reports look fine to me
- only 
downside is, the log is now pretty unreadable but I can live
with that....

Matt
btw: this issue also arises with 3.1.8, not only 3.2 !
_______________________________________________
Devel-spam mailing list
Devel-spamlists.own-hero.net
http://lists.own-hero.net/mailman/listinfo/devel-spam

Matthias Keller wrote:
> decoder wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> after I saw that there are incompatiblities with SA
3.2 and FuzzyOcr,
>> I decided to try to fix them although I'm still
very busy (preparing
>> for Bachelor thesis).
>>
>>
>> There is still another problem though, the
formatting of the rule
>> descriptions changed in SA 3.2 and I can't seem to
get it to do the
>> "old" formatting (listing the words etc),
the wrapper screws it up
>> totally.
>>  
> Hi
>
> I fixed this for me - it's a dirty hack but it seems to
work for quite a
> while now by just padding every line to 45 with spaces
and removing the
> newlines.
>
> For example:
>
> Instead of
> push( cfound, ""$w" in $wcnt lines"
);
>
> I'm using:
>
> my $text = ""$w" in $wcnt
lines";
> $text .= " " x (45-length($text));
> push( cfound, $text );
>
> Dont forget the initial line and the reports look fine
to me - only
> downside is, the log is now pretty unreadable but I can
live with that....
>
> Matt
> btw: this issue also arises with 3.1.8, not only 3.2 !
Yes, I found that out as well, the reason is the changed
implementation of Mail::SpamAssassin::Util::wrap(). Before
3.1.8, this
was only a wrapper to Text::wrap() but now it is an own
implementation
which does obviously screw some things up... Justin Mason
recommended
me to try out the test_log() API which was added just for
this purpose
and I will try this as soon as I have time.


Best regards,


Chris

> _______________________________________________
> Devel-spam mailing list
> Devel-spamlists.own-hero.net
> http://lists.own-hero.net/mailman/listinfo/devel-spam


_______________________________________________
Devel-spam mailing list
Devel-spamlists.own-hero.net
http://lists.own-hero.net/mailman/listinfo/devel-spam

On 27 May 2007, decoderown-hero.net said:
> I made changes and the current SVN version fixes ticket
#396 as well
> as the good old "Exporter.pm warnings" bug.

#396 is fixed. I now see this, with scores and
descriptions:

 pts rule name              description
---- ----------------------
--------------------------------------------------
 0.0 DKIM_POLICY_SIGNSOME   Domain Keys Identified Mail:
policy says domain
                            signs some mails
 0.0 HTML_MESSAGE           BODY: HTML included in message
 0.5 RCVD_IN_PBL            RBL: Received via a relay in
Spamhaus PBL
                            [217.226.209.237 listed in
zen.spamhaus.org]
 1.6 RCVD_IN_SORBS_DUL      RBL: SORBS: sent directly from
dynamic IP address
                            [217.226.209.237 listed in
dnsbl.sorbs.net]
 0.1 RDNS_DYNAMIC           Delivered to trusted network by
host with
                            dynamic-looking rDNS
 0.7 SHORT_HELO_AND_INLINE_IMAGE Short HELO string, with
inline image
 0.0 DYN_RDNS_SHORT_HELO_IMAGE Short HELO string, dynamic
rDNS, inline
                            image
 0.3 DYN_RDNS_SHORT_HELO_HTML Sent by dynamic rDNS, short
HELO, and HTML
 0.0 DYN_RDNS_AND_INLINE_IMAGE Contains image, and was sent
by dynamic
                            rDNS
 1.5 FUZZY_OCR_WRONG_CTYPE  BODY: Mail contains an image
with wrong
                            content-type set
Image has format "GIF" but
                            content-type is
"image/jpeg"
 2.5 FUZZY_OCR_CORRUPT_IMG  BODY: Mail contains a corrupted
image
Corrupt
                            image: GIF-LIB error: Image is
defective,
                            decoding aborted.
  13 FUZZY_OCR              BODY: Mail contains an image
with common spam text inside
                            Words found:
"target" in 1 lines
"service" in 1
                             lines
"stock" in 2 lines
"price" in 2 lines
                            "company" in 1 lines
"recommendation" in 1
                            lines
(12 word occurrences found)
 0.1 AWL                    AWL: From: address is in the
auto white-list

Wow, those descriptions look disgusting ;)

I'm rather disturbed by the +13 score. Surely *no* single
test should
be able to add *nearly three times* my spam threshold of +5
to the score
of a single mail? Is there a way to threshold the thing so
that it will
cap scores at +4.5 or something more sane?

> There is still another problem though, the formatting
of the rule
> descriptions changed in SA 3.2 and I can't seem to get
it to do the
> "old" formatting (listing the words etc), the
wrapper screws it up
> totally.

I'll say! However, spamassassin --remove-markup can still
expunge even
this wildly mangled description...

> I'd be glad if some people could try the SVN version
with SA 3.2 and
> report back. If someone knows how to fix those ugly
output formatting
> problems, tell me. This is a cosmetically issue but it
still looks bad.

I'll look at that soon (I have some work to avoid and this
is a good way
to avoid it).

-- 
`On a scale of one to ten of usefulness, BBC BASIC was
several points ahead
 of the competition, scoring a relatively respectable zero.'
--- Peter Corlett
_______________________________________________
Devel-spam mailing list
Devel-spamlists.own-hero.net
http://lists.own-hero.net/mailman/listinfo/devel-spam