TUI + gdbserver broken?

Hi,

TUI + gdbserver seems to be broken on head.  Can't reproduce
when
TUI + native debugging.

main is a simple hello world.

Could this still be related to the recent
get_selected_frame
changes?  I tried to blindly change all of them in
tui/tui-hooks.c to deprecated_get_selected_frame, but it
didn't fix it.

I also see some nasty extra screen repaints in
tui mode while stepping I didn't see before.  Any ideas?

$gdbserver :9999 main

$gdb main.exe
GNU gdb 6.6.50.20070312-cvs
Copyright (C) 2007 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public
License, and you are
welcome to change it and/or distribute copies of it under
certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show
warranty" for details.
This GDB was configured as "i686-pc-cygwin"...
(gdb) tar rem :9999
Remote debugging using :9999
[New Thread 5340]
[Switching to Thread 5340]
0x7c911231 in ?? ()
(gdb) c
Continuing.

Program exited normally.
(gdb) c
The program is not being run.

----

$gdbserver :9999 main

$gdbtui main
tar rem :9999
Remote debugging using :9999
[New Thread 5612]
[Switching to Thread 5612]
0x7c911231 in ?? ()
(gdb) c
Continuing.
Remote communication error: Software caused connection
abort.
(gdb) c
Continuing.
putpkt: write failed: Software caused connection abort.

On Wed, Mar 14, 2007 at 12:55:40AM +0000, Pedro Alves
wrote:
> Could this still be related to the recent
get_selected_frame
> changes?

I doubt it.

> (gdb) c
> Continuing.
> Remote communication error: Software caused connection
abort.

I recommend set debug remote.  What does gdbserver do when
this happens?

-- 
Daniel Jacobowitz
CodeSourcery

Pedro Alves wrote:
> Denis PILAT wrote:
>>
>> Pedro Alves wrote:
>> > Hi,
>> >
>> > TUI + gdbserver seems to be broken on head. 
Can't reproduce when
>> > TUI + native debugging.
>> >
>> As far as the TUI is concerned:
>> It's broken with Solaris Native debugging.
>> I've spent a few hours debugging that problem but I
have not solution 
>> yet !!
>> I also tried using deprecated_get_selected_frame
without any better
>> results :(
>>
>> This problem is present in the CVS HEAD but also in
the 6.6 released
>> version, so I don't think it comes from recent
changes.
>>
>
> Just tested a GNU gdb 6.6.50.20070101-cvs configured as

> sparc-sun-solaris2.9,
> built with gcc 3.4.6 I had here - TUI works fine.
>
> $uname -srvmpi
> SunOS 5.9 Generic_117171-13 sun4u sparc
SUNW,Sun-Fire-480R
>
I tested 6.6 TUI configured as sparc-sun-solaris2.8 built
with gcc 3.2.2.
uname gives: SunOS  5.8 Generic_117350-23 sun4u sparc

I'm looking for a 2.9 Solaris to make some tests

Denis
> Don't know if it adds any value, but I tried it under
solaris xterm
> displaying on cygwin X,
> under GNU bash, version 3.2.0(1)-release
(sparc-sun-solaris2.9)
>
> I'll try doing a binary search on Cygwin when I get
home.
>
> Cheers,
> Pedro Alves
>

Daniel Jacobowitz escreveu:
> On Wed, Mar 14, 2007 at 12:55:40AM +0000, Pedro Alves
wrote:
>   
>> Could this still be related to the recent
get_selected_frame
>> changes?
>>     
>
> I doubt it.
>
>   

But it is.  Going back to cvs before the following patch
fixes both problems I see on Cygwin.

2007-02-27  Daniel Jacobowitz  <dancodesourcery.com>

    * frame.c (deprecated_selected_frame): Rename to...
    (selected_frame): ...this.  Make static.
    (get_selected_frame, select_frame): Update.
    * frame.h (deprected_select_frame): Delete.
    (deprecated_safe_get_selected_frame): Update comments.

    * breakpoint.c, cli/cli-cmds.c, f-valprint.c, infcmd.c,
inflow.c,
    infrun.c, stack.c, tui/tui-disasm.c, tui/tui-source.c,
    tui/tui-winsource.c, valops.c, varobj.c, findvar.c,
macroscope.c,
    parse.c, regcache.h, sh64-tdep.c, tui/tui-hooks.c,
tui/tui-win.c,
    tui/tui.c: Replace references to
deprecated_selected_frame.


>> (gdb) c
>> Continuing.
>> Remote communication error: Software caused
connection abort.
>>     
>
> I recommend set debug remote.  What does gdbserver do
when this happens?
>
>   

It ends successfully.
I'm out of time for today to look further.

Cheers,
Pedro Alves

Pedro Alves wrote:
>
> But it is.  Going back to cvs before the following
patch
> fixes both problems I see on Cygwin.
>
> 2007-02-27  Daniel Jacobowitz  <dancodesourcery.com>
>
>    * frame.c (deprecated_selected_frame): Rename to...
>    (selected_frame): ...this.  Make static.
>    (get_selected_frame, select_frame): Update.
>    * frame.h (deprected_select_frame): Delete.
>    (deprecated_safe_get_selected_frame): Update
comments.
>
>    * breakpoint.c, cli/cli-cmds.c, f-valprint.c,
infcmd.c, inflow.c,
>    infrun.c, stack.c, tui/tui-disasm.c,
tui/tui-source.c,
>    tui/tui-winsource.c, valops.c, varobj.c, findvar.c,
macroscope.c,
>    parse.c, regcache.h, sh64-tdep.c, tui/tui-hooks.c,
tui/tui-win.c,
>    tui/tui.c: Replace references to
deprecated_selected_frame.
>
>
>>> (gdb) c
>>> Continuing.
>>> Remote communication error: Software caused
connection abort.
>>>     
>>
>> I recommend set debug remote.  What does gdbserver
do when this happens?
>>
>>   
>
> It ends successfully.
> I'm out of time for today to look further.
>

I've looked further.

Here's what happens, on TUI + gdbserver:

(...)
Packet vCont (verbose-resume) is supported
Sending packet: $vCont;c#a8...Ack
Packet received: W00
Sending packet: $g#67...Remote communication error: Software
caused
connection abort.
(gdb) c
Continuing.

gdb is sending a g packet after a W.  Something in gdb
didn't
realize that the the target already exited.  I'm posting
a patch at gdb-patches with a deeper rationale.

Cheers,
Pedro Alves