List Info

Thread: ^m's in testsuite/gdb.disasm




^m's in testsuite/gdb.disasm
user name
2007-10-31 14:21:47
I can understand ^m's in djunpack.bat, but I'm curious if
there's any global
rule regarding ^m's appearing elsewhere.  I ask because the
following files
have ^m's and it resulting in spurious differences when
trying to compare
trees.  One program I used to create a tree was dos-vs-unix
aware and stripped
them.  On the one hand "my bad" and I'd expect to
pay the price if I try to use
djunpack.bat, but OTOH IWBN to avoid the issue where
possible and just stick
with ^j for newlines, even in the testsuite.  OTOOH, if the
^m's are
intentional, no problem - but a README to that effect in the
same directory
would be nice.

Just my $0.02.

gdb/testsuite/gdb.disasm/t01_mov.s
gdb/testsuite/gdb.disasm/t02_mova.s
gdb/testsuite/gdb.disasm/t03_add.s
gdb/testsuite/gdb.disasm/t04_sub.s
gdb/testsuite/gdb.disasm/t05_cmp.s
gdb/testsuite/gdb.disasm/t06_ari2.s
gdb/testsuite/gdb.disasm/t07_ari3.s
gdb/testsuite/gdb.disasm/t08_or.s
gdb/testsuite/gdb.disasm/t09_xor.s
gdb/testsuite/gdb.disasm/t10_and.s
gdb/testsuite/gdb.disasm/t11_logs.s
gdb/testsuite/gdb.disasm/t12_bit.s
gdb/testsuite/gdb.disasm/t13_otr.s

Re: ^m's in testsuite/gdb.disasm
country flaguser name
United States
2007-10-31 15:22:11
On Wed, Oct 31, 2007 at 10:18:51PM +0200, Eli Zaretskii
wrote:
> As for other files, IMO they should only have CR-LF if
the development
> tools or programs that use them require that.  I don't
think *.s
> assembly source files qualify; chances are they were
simply committed
> from a Windows machine...

I agree; I suspect it's just an accident.

-- 
Daniel Jacobowitz
CodeSourcery

Re: ^m's in testsuite/gdb.disasm
user name
2007-11-01 18:44:57
On Oct 31, 2007 1:22 PM, Daniel Jacobowitz <drowfalse.org> wrote:
> On Wed, Oct 31, 2007 at 10:18:51PM +0200, Eli Zaretskii
wrote:
> > As for other files, IMO they should only have
CR-LF if the development
> > tools or programs that use them require that.  I
don't think *.s
> > assembly source files qualify; chances are they
were simply committed
> > from a Windows machine...
>
> I agree; I suspect it's just an accident.

Thanks.  Can I check in a fix?

Re: ^m's in testsuite/gdb.disasm
country flaguser name
United States
2007-11-01 19:38:25
On Thu, Nov 01, 2007 at 04:44:57PM -0700, Douglas Evans
wrote:
> On Oct 31, 2007 1:22 PM, Daniel Jacobowitz <drowfalse.org> wrote:
> > On Wed, Oct 31, 2007 at 10:18:51PM +0200, Eli
Zaretskii wrote:
> > > As for other files, IMO they should only have
CR-LF if the development
> > > tools or programs that use them require that.
 I don't think *.s
> > > assembly source files qualify; chances are
they were simply committed
> > > from a Windows machine...
> >
> > I agree; I suspect it's just an accident.
> 
> Thanks.  Can I check in a fix?

Please do!

-- 
Daniel Jacobowitz
CodeSourcery

[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )