List Info

Thread: Re: My Recent Changes




Re: My Recent Changes
user name
2007-03-08 15:05:02
Hi Robert

Great, do you plan to merge this in trunk? would be nice for
me.
I'd like to reorganize a the source tree to make gforge
easier to 
install on an ISP Box
I think for example that all includes should be moved in the
www/include 
dir that is usually the default include, remove the need of
symlink for 
plugins.
Would you find this useful or not?

Christian

Robert Nelson wrote:
>
> I created a branch called Branch_4_6-mysql to contain
the changes 
> required to use MySQL instead of PostgreSQL and also to
support 
> installation on a hosted server where root access is
not available.
>
> I separated the changes into a number of commits. The
first 6 commits 
> are bug fixes and features which are of general
interest. These were 
> committed separately in order to facilitate inclusion
into the main 
> 4.6 tree if desired.
>
> I still have quite a bit of testing and a few more
areas to complete 
> but all of the core functionality appears to work in
the targeted 
> environment.
>
> Here is a list of the commits and the areas they
address:
>
> 5922
>
> ------
>
> This fixes a number of uninitialized variables and
undeclared globals 
> that result in warnings and notices in the error log or
result in the 
> code not working as intended.
>
> 5923
>
> ------
>
> This fixes some layout bugs in the project registration
page. It also 
> adds the ability to change the SCM package for a
project at any time. 
> This is very useful for projects that decide to migrate
from CVS to 
> SVN for example.
>
> 5924
>
> ------
>
> Change all the absolute paths such as /opt/gforge, etc
to global 
> variable references. This makes it much easier to
install GForge in 
> different directories; it also allows multiple copies
of GForge to be 
> installed on a single machine.
>
> 5927
>
> ------
>
> These are database changes that make the code more
portable to other 
> databases but are a no-op on PostgreSQL.
>
> 5933
>
> ------
>
> This fixes the issues when displaying GForge on
Internet Explorer. The 
> default alignment for table cells is centered, so all
the tables with 
> cells which are intended to display left aligned end up
centered and 
> hard to read. This also makes the HTML more XHTML
compliant since it 
> replaces the deprecated align=”center” with
style=”text-align:center”.
>
> 5934
>
> ------
>
> This fixes a number of additional notice, warnings and
errors logged 
> by PHP. It also enhances the usability of the product
by sorting the 
> list of plugins in the Plugin Configuration screen and
also sorts the 
> list of variables in the Configuration Manager screen.
>
> 5935
>
> ------
>
> This is the change that actually provides support for
MySQL.
>
>
------------------------------------------------------------
------------
>
> _______________________________________________
> Gforge-devel mailing list
> Gforge-devellists.gforge.org
> http://lists.gforge.org/mailman/listinfo/gforge-devel
>   

_______________________________________________
Gforge-devel mailing list
Gforge-devellists.gforge.org
http://lists.gforge.org/mailman/listinfo/gforge-devel

RE: My Recent Changes
user name
2007-03-08 15:28:40
Answers below.

> -----Original Message-----
> From: gforge-devel-bounceslists.gforge.org
[mailto:gforge-devel-
> bounceslists.gforge.org] On Behalf Of Christian BAYLE
> Sent: Thursday, March 08, 2007 1:05 PM
> To: gforge-devellists.gforge.org
> Subject: Re: [Gforge-devel] My Recent Changes
> 
> Hi Robert
> 
> Great, do you plan to merge this in trunk? would be
nice for me.

I will be merging it into the trunk.  I wanted to finish my
testing first.
Also I figured I'd wait a few days to let your big commit
settle down. 

> I'd like to reorganize a the source tree to make gforge
easier to
> install on an ISP Box
> I think for example that all includes should be moved
in the www/include
> dir that is usually the default include, remove the
need of symlink for
> plugins.
> Would you find this useful or not?
> 

The include files in common/include don't really matter
however the symlink
of the plugins does cause problems.  Most ISPs are running
some sort of
Apache module like suphp which runs the PHP scripts as the
user rather than
Apache.  One of the security checks is to ensure that the
scripts and/or the
file a symlink points to is under the document root for that
site.  If the
www directory of the plugin were copied to www/plugins
rather than
symlink'ed it would work much better.

Included and required files can be located anywhere. 

I committed the script I use for installing GForge, it's a
modified version
of gforge-install.sh called gforge-restricted.sh.  I added a
modified
version of INSTALL called INSTALL.restricted.  That should
give you an idea
of what I'm doing.

Also I spent some time to figure out the minimum set of file
and directory
permissions required.

Basically I have a separate user called gforge, but it could
be anything.
In that user's home directory I have a gforge subdirectory
with the
following structure.

	~/gforge/opt	=	/opt/gforge
	~/gforge/var	=	/var/gforge
	~/gforge/etc	=	/etc/gforge


> Christian
> 



_______________________________________________
Gforge-devel mailing list
Gforge-devellists.gforge.org
http://lists.gforge.org/mailman/listinfo/gforge-devel

RE: My Recent Changes
user name
2007-03-08 23:56:36
Christian, I just merged my changes into the trunk.

> -----Original Message-----
> From: gforge-devel-bounceslists.gforge.org
[mailto:gforge-devel-
> bounceslists.gforge.org] On Behalf Of Christian BAYLE
> Sent: Thursday, March 08, 2007 1:05 PM
> To: gforge-devellists.gforge.org
> Subject: Re: [Gforge-devel] My Recent Changes
> 
> Hi Robert
> 
> Great, do you plan to merge this in trunk? would be
nice for me.
> I'd like to reorganize a the source tree to make gforge
easier to
> install on an ISP Box
> I think for example that all includes should be moved
in the www/include
> dir that is usually the default include, remove the
need of symlink for
> plugins.
> Would you find this useful or not?
> 
> Christian
> 
> Robert Nelson wrote:
> >
> > I created a branch called Branch_4_6-mysql to
contain the changes
> > required to use MySQL instead of PostgreSQL and
also to support
> > installation on a hosted server where root access
is not available.
> >
> > I separated the changes into a number of commits.
The first 6 commits
> > are bug fixes and features which are of general
interest. These were
> > committed separately in order to facilitate
inclusion into the main
> > 4.6 tree if desired.
> >
> > I still have quite a bit of testing and a few more
areas to complete
> > but all of the core functionality appears to work
in the targeted
> > environment.
> >
> > Here is a list of the commits and the areas they
address:
> >
> > 5922
> >
> > ------
> >
> > This fixes a number of uninitialized variables and
undeclared globals
> > that result in warnings and notices in the error
log or result in the
> > code not working as intended.
> >
> > 5923
> >
> > ------
> >
> > This fixes some layout bugs in the project
registration page. It also
> > adds the ability to change the SCM package for a
project at any time.
> > This is very useful for projects that decide to
migrate from CVS to
> > SVN for example.
> >
> > 5924
> >
> > ------
> >
> > Change all the absolute paths such as /opt/gforge,
etc to global
> > variable references. This makes it much easier to
install GForge in
> > different directories; it also allows multiple
copies of GForge to be
> > installed on a single machine.
> >
> > 5927
> >
> > ------
> >
> > These are database changes that make the code more
portable to other
> > databases but are a no-op on PostgreSQL.
> >
> > 5933
> >
> > ------
> >
> > This fixes the issues when displaying GForge on
Internet Explorer. The
> > default alignment for table cells is centered, so
all the tables with
> > cells which are intended to display left aligned
end up centered and
> > hard to read. This also makes the HTML more XHTML
compliant since it
> > replaces the deprecated align="center"
with style="text-align:center".
> >
> > 5934
> >
> > ------
> >
> > This fixes a number of additional notice, warnings
and errors logged
> > by PHP. It also enhances the usability of the
product by sorting the
> > list of plugins in the Plugin Configuration screen
and also sorts the
> > list of variables in the Configuration Manager
screen.
> >
> > 5935
> >
> > ------
> >
> > This is the change that actually provides support
for MySQL.
> >
> >
------------------------------------------------------------
------------
> >
> > _______________________________________________
> > Gforge-devel mailing list
> > Gforge-devellists.gforge.org
> > http://lists.gforge.org/mailman/listinfo/gforge-devel
> >
> 
> _______________________________________________
> Gforge-devel mailing list
> Gforge-devellists.gforge.org
> http://lists.gforge.org/mailman/listinfo/gforge-devel



_______________________________________________
Gforge-devel mailing list
Gforge-devellists.gforge.org
http://lists.gforge.org/mailman/listinfo/gforge-devel

[1-3]

about | contact  Other archives ( Real Estate discussion Medical topics )