List Info

Thread: Problem with git-apply?




Problem with git-apply?
user name
2006-11-04 18:33:06
Linus Torvalds <torvaldsosdl.org> writes:

> On Sat, 4 Nov 2006, Junio C Hamano wrote:
>> 
>> The problem appears that GNU diff _never_ uses
"--- /dev/null" or "+++ 
>> /dev/null" to indicate creation or deletion of
the file, but the 
>> "traditional patch parser" builtin-apply
has assumed that is what the 
>> traditional diff output from day one.  Where we got
that idea is mystery 
>> to me (this is Linus's code), but I suspect it is
what other SCMs did.
>
> No, the original code used to trigger a
"create" diff on
>  - source was /dev/null
> OR
>  - source had zero patches.
>
> It used to have code like
>...
> and I think the person who broke it was you ;)

Sorry, if you followed the threads by now you know I know
that.
A few messages down there is a fix for the breakage caused
by
4be60962, which I'll have in 'maint'.

I think it is a time for a 1.4.3.4; these are queued since
we did 1.4.3.3.

Andy Parkins (2):
  Minor grammar fixes for git-diff-index.txt
  git-clone documentation didn't mention --origin as
equivalent of -o

Christian Couder (3):
  Remove --syslog in git-daemon inetd documentation
examples.
  Documentation: add upload-archive service to git-daemon.
  Documentation: add git in /etc/services.

Edgar Toernig (1):
  Use memmove instead of memcpy for overlapping areas

J. Bruce Fields (1):
  Documentation: updates to "Everyday GIT"

Jakub Narebski (3):
  diff-format.txt: Combined diff format documentation
supplement
  diff-format.txt: Correct information about pathnames
quoting in patch format
  gitweb: Check git base URLs before generating URL from it

Jan Harkes (1):
  Continue traversal when rev-list --unpacked finds a packed
commit.

Johannes Schindelin (1):
  link_temp_to_file: call adjust_shared_perm() only when we
created the directory

Junio C Hamano (9):
  Documentation: clarify refname disambiguation rules.
  combine-diff: a few more finishing touches.
  combine-diff: fix hunk_comment_line logic.
  combine-diff: honour --no-commit-id
  Surround "#define DEBUG 0" with "#ifndef
DEBUG..#endif"
  quote.c: ensure the same quoting across platforms.
  revision traversal: --unpacked does not limit commit list
anymore.
  link_temp_to_file: don't leave the path truncated on
adjust_shared_perm failure
  apply: handle "traditional" creation/deletion
diff correctly.

Nicolas Pitre (1):
  pack-objects doesn't create random pack names

Rene Scharfe (1):
  git-cherry: document limit and add diagram


-
To unsubscribe from this list: send the line
"unsubscribe git" in
the body of a message to majordomovger.kernel.org
More majordomo info at  http://vge
r.kernel.org/majordomo-info.html
[1]

about | contact  Other archives ( Real Estate discussion Medical topics )