Wrong path in gst.im

Hello,

I have noticed that path to *some* Smalltalk files are not
correctly
kept inside the `gst.im' file. The last path part is
stripped.

For example searching to `Boolean.st' within `gst.im' using
the
strings command gives `/usr/share/smalltalk/Boolean.st'
while the
file is actually located in
`/usr/share/smalltalk/kernel/Boolean.st'.
This makes BLOX Namespace Browser unable to display the
content of
Boolean methods.

>From what I have found, it seems Smalltalk and Kernel
namespaces are
affected. Am I missing something?

Regards,

Thomas


_______________________________________________
help-smalltalk mailing list
help-smalltalkgnu.org

http://lists.gnu.org/mailman/listinfo/help-smalltalk

> I have noticed that path to *some* Smalltalk files are
not correctly
> kept inside the `gst.im' file. The last path part is
stripped.
> 
> For example searching to `Boolean.st' within `gst.im'
using the
> strings command gives `/usr/share/smalltalk/Boolean.st'
while the
> file is actually located in
`/usr/share/smalltalk/kernel/Boolean.st'.
> This makes BLOX Namespace Browser unable to display the
content of
> Boolean methods.

What version is this?

Paolo


_______________________________________________
help-smalltalk mailing list
help-smalltalkgnu.org

http://lists.gnu.org/mailman/listinfo/help-smalltalk

On Fri, Mar 09, 2007 at 01:58:59PM +0100, Paolo Bonzini
wrote:
> > I have noticed that path to *some* Smalltalk files
are not correctly
> > kept inside the `gst.im' file. The last path part
is stripped.

[...]

> What version is this?

Oops, sorry. That's version 2.3.3.

Thomas


_______________________________________________
help-smalltalk mailing list
help-smalltalkgnu.org

http://lists.gnu.org/mailman/listinfo/help-smalltalk

Thomas Girard wrote:
> On Fri, Mar 09, 2007 at 01:58:59PM +0100, Paolo Bonzini
wrote:
>>> I have noticed that path to *some* Smalltalk
files are not correctly
>>> kept inside the `gst.im' file. The last path
part is stripped.
> 
> [...]
> 
>> What version is this?
> 
> Oops, sorry. That's version 2.3.3.

Sigh.  As soon as I found time to fix Sungjin and Brad's
reported
bugs, I'll release 2.3.4.  In the meanwhile, here's the
patch.

--- orig/scripts/Finish.st
+++ mod/scripts/Finish.st
 -43,11
+43,12  ok ifFalse: [ ObjectMemory quit: 1 ]!
 
 "Remove DESTDIR and references to the build directory,
from the paths
  stored in the image"
-| newImagePath newKernelBasePath |
+| newImagePath oldKernelBasePath newKernelBasePath |
+oldKernelBasePath := File pathFor: KernelFilePath.
 newKernelBasePath := Smalltalk arguments at: 1.
 newImagePath := Smalltalk arguments at: 2.
-KernelFilePath = newKernelBasePath
-    ifFalse: [ FileSegment relocateFrom: KernelFilePath to:
newKernelBasePath ].
+oldKernelBasePath = newKernelBasePath ifFalse: [
+    FileSegment relocateFrom: oldKernelBasePath to:
newKernelBasePath ].
 
 ImageFileName := 'gst.im'.
 ImageFilePath := newImagePath.

Paolo


_______________________________________________
help-smalltalk mailing list
help-smalltalkgnu.org

http://lists.gnu.org/mailman/listinfo/help-smalltalk

On Fri, Mar 09, 2007 at 02:06:09PM +0100, Paolo Bonzini
wrote:
> Thomas Girard wrote:
> > On Fri, Mar 09, 2007 at 01:58:59PM +0100, Paolo
Bonzini wrote:
> >>> I have noticed that path to *some*
Smalltalk files are not correctly
> >>> kept inside the `gst.im' file. The last
path part is stripped.

[...]

> Sigh.  As soon as I found time to fix Sungjin and
Brad's reported
> bugs, I'll release 2.3.4.  In the meanwhile, here's the
patch.

It works, thanks a lot!

Thomas


_______________________________________________
help-smalltalk mailing list
help-smalltalkgnu.org

http://lists.gnu.org/mailman/listinfo/help-smalltalk

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 9 Mar 2007 20:20:37 +0100, you wrote:

>It works, thanks a lot!

I have added the patch to the Fedora packages.

The new packages should be available on the mirrors in the
next
days.

Best Regards:

Jochen Schmitt

-----BEGIN PGP SIGNATURE-----
Version: PGP Desktop 9.5.2 (Build 4075)
Charset: us-ascii

wj8DBQFF9sXjT2AHK6txfgwRApDwAKDNRa3FwlkIp8gTo90v233H5p2iCgCg
+PzP
CWP3ra/0DoKxN0UDkX01AUI=
=H3u6
-----END PGP SIGNATURE-----


_______________________________________________
help-smalltalk mailing list
help-smalltalkgnu.org

http://lists.gnu.org/mailman/listinfo/help-smalltalk