It appears you attached the whole file for embeddedapp.cpp
and hxutil.cpp
instead of just the diffs (cvs diff -uw).
Also, this CR should goto the player-dev list, not
helix-client-dev.
That way the player developers can look at it.
Thanks,
--greg.
Sridhar V Iyer wrote:
> Modified by: Sridhar V Iyer(sridhar.v.iyer gmail.com)
> Date: 5/2/07
> Project: Embedded Real player for firefox
>
> Synopsis: Realplayer segfaults when running online
radios like raaga.com on Linux
>
> Overview: On closer inspection this was due to few
booleans being memset to 0.
>
> Files Added:None
>
>
> Files Modified:
> /player/common/gtk/hxutil.cpp : Used an undefined
variable for higher glibc versions. Fixed that
> /player/app/gtk/embeddedapp: Removed a few typos.
>
>
> Platforms and Profiles Affected:
> Embedded player for firefox on Linux
>
>
> Platforms and Profiles Build Verified:
> linux-2.2-libc6-gcc32-i586
> helix-client-all-defines
>
> Platforms and Profiles Functionality verified:
> linux-2.2-libc6-gcc32-i586
> helix-client-all-defines
>
> Branch:
> realplay_gtk_current
>
> Copyright assignment:
>
> 1. In consideration for RealNetworks' hosting
and maintenance
> of my modification, I agree to assign to
RealNetworks full
> copyright ownership of the code included in
the attached
> patch, and agree that RealNetworks has no
duty of accounting
> to me for it. I warrant that this code is
entirely original
> to and owned by me, that I can legally grant
the copyright
> assignment, and that my contribution does
not violate any other
> person's rights, and laws or breach any
contract. I understand
> that RealNetworks may license this code
under RPSL, RCSL,
> and/or any other license at RealNetworks'
discretion, and use
> the code in any way.
>
>
> QA Instructions:
> Try playing any song from Ragaa.com after and before
compilation
>
>
>
>
------------------------------------------------------------
------------
>
> _______________________________________________
> Helix-client-dev mailing list
> Helix-client-dev helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev
_______________________________________________
Player-dev mailing list
Player-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev
|