CR: Remove XNextEvent from hxplayer_pump() of Helix dbus-server

Zhao, Halley wrote:
> Synopsis: 
> 
>            Helix dbus-server needn't and shouldn't deal
with X Event
> since it is a media service, there is higher level
media application
> deal with it.

Make sure that SMIL playback still works, it uses keyboard
and mouse
events. The site will normally do this by itself but it
depends on
how the XWindow gets created. copy both of the attached
files into
the same directory and play back the .smil file. You should
see a
few 'x's. Click on the top left one and all the 'x's should
start
moving around the screen. You can try this with 'splay' to
see how
it should work.

If that still works then the change looks good.

--greg.

> 
> Overview: 
> 
>     Helix dbus-server needn't deal with user input
event, such as
> 'keypress', 'buttonclick', because:
> 
>         1> it is a media service 
> 
>         2> there is media application above it which
will deal with such
> events. so:
> 
>             XNextEvent() doesn't make sense for Helix
dbus-server's
> pump(), because:
> 
>             a> XNextEvent() will get one event from
X's event sequence
> and remove it from the sequence.
> 
>                 --these events should be dealt by
higher media
> application.
> 
>                 --if helix dbus service and media
application deal with
> these message at the same time, 
> 
>                   there maybe some confliction. for
example: when user
> drag the seek bar, 
> 
>                   there is lots of xEvent, may cause
some exceptions.
> 
>             b> only XFlush() is really needed here.
> 
>         
> 
> Files Added:
> 
>        No file added
> 
> Files Modified:
> 
>     hxplayer.cpp:
(player/kit/dbus-server/src/hxplayer.cpp)
> 
>         modify hxplayer_pump()
> 
>         
> 
> Image Size and Heap Use impact (Client -Only):
> 
>     little
> 
> Platforms and Profiles Affected:
> 
>     platform:   linux-2.2-libc6-gcc32-i586
> 
>     profile:    helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>     <helix-dbus-server.bin>
> 
> Distribution library impact and planned action:
> 
>     <None>
> 
> Platforms and Profiles Build Verified:
> 
>     Set BIF branch  -> hxdbus_3_1_0_atlas
> 
>     Set Target(s)   -> dbus_server_with_video
> 
>     Set Profile     -> helix-client-all-defines
> 
>     System ID       -> linux-2.2-libc6-gcc32-i586
> 
> Branch: 
> 
>     HEAD, hxclient_3_1_0_atlas
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>    2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>            agreement was received. 
> 
> Files Attached:
> 
>     helix-dbus-server.diff
> 
>  
> 
> ZHAO, Halley (Aihua)
> 
> Email: halley.zhaointel.com <mailto:aihua.zhaointel.com> 
> 
> Tel: +86(21)61166476
> 
> iNet: 8821-6476
> 
> SSG/OTC/UMD
> 
>  
> 
> 
> 
>
------------------------------------------------------------
------------
> 
> This body part will be downloaded on demand.


_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev