CR: turn on xvideo on solaris x86 platform

Modified by: jerry.tansun.com
Date: 04:03:2006
Project: Porting solaris
Bug Number: 4790
Bug URL: 
https://bugs.helixcommunity.org/show_bug.cgi?id=4790

Synopsis:
   Turn on xvideo on solaris x86 platform

Overview:
   With Xvideo turned on, the playback performance on
solaris x86 will 
be improved greatly.
this patch will turn xvideo on when compile on solaris x86
with the 
SYSTEM_ID=sunos-5.10-i386-studio11
because xvideo is one part of xorg, and xorg is used by
solaris x86.
and solaris sparc is still using xsun, so I only enable it
on solaris x86.
   If Xvideo is working in sparc in the future, I will
modify sparc's 
bif file to enable it.


Files Added:
none


Files Modified:
[file 1]video/site/unix.pcf
[file 2]video/sitelib/platform/unix/unixsurf.cpp
[file 3]video/sitelib/pub/platform/unix/unixsurf.h
[file 4]build/umakecf/sunos-5.10-i386-studio11.cf

Platforms and Profiles Affected:
 only for solaris x86 build with SYSTEM_ID=
sunos-5.10-i386-studio11


Distribution Libraries Affected:
no

Distribution library impact and planned action:
no

Platforms and Profiles Build Verified:
Have verified on solaris 10 x86 , with
SYSTEM_ID=sunos-5.10-i386-studio11, profile as player-all

Platforms and Profiles Functionality verified:
runs the contentsuite1.0, works.

Branch: hxclient_1_4_4_neptunex
it may need to check into 133 .

Copyright assignment:
1. My company (sun.com) submits this code under the terms
of a commercial contribution agreement with RealNetworks,
and I am authorized to contribute this code under said
agreement.

_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev

This looks good. 

> -----Original Message-----
> From: porting-solaris-bounceshelixcommunity.org 
> [mailto:porting-solaris-bounceshelixcommunity.org] On
Behalf 
> Of Jerry Tan
> Sent: Monday, April 03, 2006 9:20 PM
> To: porting-solarishelixcommunity.org; 
> ribosome-devhelixcommunity.org; player-devhelixcommunity.org
> Subject: [Porting-solaris] CR: turn on xvideo on
solaris x86 platform
> 
> Modified by: jerry.tansun.com
> Date: 04:03:2006
> Project: Porting solaris
> Bug Number: 4790
> Bug URL: 
https://bugs.helixcommunity.org/show_bug.cgi?id=4790
> 
> Synopsis:
>    Turn on xvideo on solaris x86 platform
> 
> Overview:
>    With Xvideo turned on, the playback performance on
solaris 
> x86 will 
> be improved greatly.
> this patch will turn xvideo on when compile on solaris
x86 with the 
> SYSTEM_ID=sunos-5.10-i386-studio11
> because xvideo is one part of xorg, and xorg is used by
solaris x86.
> and solaris sparc is still using xsun, so I only enable
it on 
> solaris x86.
>    If Xvideo is working in sparc in the future, I will
modify sparc's 
> bif file to enable it.
> 
> 
> Files Added:
> none
> 
> 
> Files Modified:
> [file 1]video/site/unix.pcf
> [file 2]video/sitelib/platform/unix/unixsurf.cpp
> [file 3]video/sitelib/pub/platform/unix/unixsurf.h
> [file 4]build/umakecf/sunos-5.10-i386-studio11.cf
> 
> Platforms and Profiles Affected:
>  only for solaris x86 build with SYSTEM_ID=
sunos-5.10-i386-studio11
> 
> 
> Distribution Libraries Affected:
> no
> 
> Distribution library impact and planned action:
> no
> 
> Platforms and Profiles Build Verified:
> Have verified on solaris 10 x86 , with
> SYSTEM_ID=sunos-5.10-i386-studio11, profile as
player-all
> 
> Platforms and Profiles Functionality verified:
> runs the contentsuite1.0, works.
> 
> Branch: hxclient_1_4_4_neptunex
> it may need to check into 133 .
> 
> Copyright assignment:
> 1. My company (sun.com) submits this code under the
terms
> of a commercial contribution agreement with
RealNetworks,
> and I am authorized to contribute this code under said
agreement.
> 
> 


_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev

Jerry Tan wrote:
> Modified by: jerry.tansun.com
> Date: 04:03:2006
> Project: Porting solaris
> Bug Number: 4790
> Bug URL: 
https://bugs.helixcommunity.org/show_bug.cgi?id=4790
> 
> Synopsis:
>   Turn on xvideo on solaris x86 platform
> 
> Overview:
>   With Xvideo turned on, the playback performance on
solaris x86 will be 
> improved greatly.
> this patch will turn xvideo on when compile on solaris
x86 with the 
> SYSTEM_ID=sunos-5.10-i386-studio11
> because xvideo is one part of xorg, and xorg is used by
solaris x86.
> and solaris sparc is still using xsun, so I only enable
it on solaris x86.
>   If Xvideo is working in sparc in the future, I will
modify sparc's bif 
> file to enable it.
> 

>========================================================
===========
>RCS file: /cvsroot/video/site/unix.pcf,v
>retrieving revision 1.3.10.1
>diff -u -w -r1.3.10.1 unix.pcf
>--- site/unix.pcf	9 Jul 2004 01:59:40 -0000	1.3.10.1
>+++ site/unix.pcf	4 Apr 2006 01:22:19 -0000
> -61,6 +61,6 
> # Add in the XVideo lib if we are on linux and not
building the mini
> # site. Right now I have only turned on XVideo for
linux.
> if( ('HELIX_FEATURE_MINI_SITE' not in
project.defines) and
>-    (platform.name in ('linux2', 'linux-i386'))):
>+    (platform.name in ('linux2', 'linux-i386',
'sunos5'))):
>           project.sys_libraries.append('Xv')
> 

If you only want to turn XVideo on for
sunos-5.10-i386-studio11.cf
builds, it seems that you would need to have something other
then 'sunos5' there. Doesn't sunos5 represent a lot more
then
just Sudio 11 x86 builds? Perhaps you need sunos-5.10-i386
instead?

> 
> Branch: hxclient_1_4_4_neptunex
> it may need to check into 133 .

You need to check this into 133NepX and HEAD.

--greg.

> 
> Copyright assignment:
> 1. My company (sun.com) submits this code under the
terms
> of a commercial contribution agreement with
RealNetworks,
> and I am authorized to contribute this code under said
agreement.
> 
> 
>
------------------------------------------------------------
------------
> 
> _______________________________________________
> Porting-solaris mailing list
> Porting-solarishelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo
/porting-solaris

_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev

>
>>
============================================================
=======
>> RCS file: /cvsroot/video/site/unix.pcf,v
>> retrieving revision 1.3.10.1
>> diff -u -w -r1.3.10.1 unix.pcf
>> --- site/unix.pcf 9 Jul 2004 01:59:40 -0000
1.3.10.1
>> +++ site/unix.pcf 4 Apr 2006 01:22:19 -0000
>>  -61,6 +61,6 
>> # Add in the XVideo lib if we are on linux and not
building the mini
>> # site. Right now I have only turned on XVideo for
linux.
>> if( ('HELIX_FEATURE_MINI_SITE' not in
project.defines) and
>> - (platform.name in ('linux2', 'linux-i386'))):
>> + (platform.name in ('linux2', 'linux-i386',
'sunos5'))):
>> project.sys_libraries.append('Xv')
>>
>
> If you only want to turn XVideo on for
sunos-5.10-i386-studio11.cf
> builds, it seems that you would need to have something
other
> then 'sunos5' there. Doesn't sunos5 represent a lot
more then
> just Sudio 11 x86 builds? Perhaps you need
sunos-5.10-i386 instead?
>
>>

Yes, sunos5 is used by more than one bif file.
I use it in order to support other SYSTEM_ID in solaris
family,
so in the future, if xvideo works on sparc, or solaris 11,
what I need to do is just to add
"project.AddDefines("HELIX_CONFIG_XVIDEO")
"
into its bif file,
and I dont need to change unix.pcf everytimes.





_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev

>> If you only want to turn XVideo on for
sunos-5.10-i386-studio11.cf
>> builds, it seems that you would need to have
something other
>> then 'sunos5' there. Doesn't sunos5 represent a
lot more then
>> just Sudio 11 x86 builds? Perhaps you need
sunos-5.10-i386 instead?
>>
> 
> Yes, sunos5 is used by more than one bif file.
> I use it in order to support other SYSTEM_ID in solaris
family,
> so in the future, if xvideo works on sparc, or solaris
11,
> what I need to do is just to add
>
"project.AddDefines("HELIX_CONFIG_XVIDEO")
"
> into its bif file,
> and I dont need to change unix.pcf everytimes.

Ok, sounds good.

--greg.



_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev

Greg,  you are right,
I  consider this patch again, I have to add system_id check
here,
or other SYSTEM_ID on solaris build may break.


Here is the patch.

Index: unix.pcf
============================================================
=======
RCS file: /cvsroot/video/site/unix.pcf,v
retrieving revision 1.3.10.1.6.1
diff -u -w -r1.3.10.1.6.1 unix.pcf
--- unix.pcf    6 Apr 2006 07:52:00 -0000       1.3.10.1.6.1
+++ unix.pcf    10 Apr 2006 09:09:04 -0000
 -61,6
+61,7 
 # Add in the XVideo lib if we are on linux and not building
the mini
 # site. Right now I have only turned on XVideo for linux.
 if( ('HELIX_FEATURE_MINI_SITE' not in project.defines)
and
-    (platform.name in ('linux2', 'linux-i386',
'sunos5'))):
+    (platform.name in ('linux2', 'linux-i386')) or
+     (id == 'sunos-5.10-i386-studio11')):
           project.sys_libraries.append('Xv')

>
>>
============================================================
=======
>> RCS file: /cvsroot/video/site/unix.pcf,v
>> retrieving revision 1.3.10.1
>> diff -u -w -r1.3.10.1 unix.pcf
>> --- site/unix.pcf    9 Jul 2004 01:59:40 -0000   
1.3.10.1
>> +++ site/unix.pcf    4 Apr 2006 01:22:19 -0000
>>  -61,6 +61,6 
>> # Add in the XVideo lib if we are on linux and not
building the mini
>> # site. Right now I have only turned on XVideo for
linux.
>> if( ('HELIX_FEATURE_MINI_SITE' not in
project.defines) and
>> -    (platform.name in ('linux2',
'linux-i386'))):
>> +    (platform.name in ('linux2', 'linux-i386',
'sunos5'))):
>>           project.sys_libraries.append('Xv')
>>
>
> If you only want to turn XVideo on for
sunos-5.10-i386-studio11.cf
> builds, it seems that you would need to have something
other
> then 'sunos5' there. Doesn't sunos5 represent a lot
more then
> just Sudio 11 x86 builds? Perhaps you need
sunos-5.10-i386 instead?
>
>>
>> Branch: hxclient_1_4_4_neptunex
>> it may need to check into 133 .
>
>
> You need to check this into 133NepX and HEAD.
>
> --greg.
>
>>
>> Copyright assignment:
>> 1. My company (sun.com) submits this code under the
terms
>> of a commercial contribution agreement with
RealNetworks,
>> and I am authorized to contribute this code under
said agreement.
>>
>>
>>
------------------------------------------------------------
------------
>>
>> _______________________________________________
>> Porting-solaris mailing list
>> Porting-solarishelixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo
/porting-solaris
>
>
> _______________________________________________
> Porting-solaris mailing list
> Porting-solarishelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo
/porting-solaris



_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev

Is it ok for me to checkin?


jerry tan wrote:

> Greg,  you are right,
> I  consider this patch again, I have to add system_id
check here,
> or other SYSTEM_ID on solaris build may break.
>
>
> Here is the patch.
>
> Index: unix.pcf
>
============================================================
=======
> RCS file: /cvsroot/video/site/unix.pcf,v
> retrieving revision 1.3.10.1.6.1
> diff -u -w -r1.3.10.1.6.1 unix.pcf
> --- unix.pcf    6 Apr 2006 07:52:00 -0000      
1.3.10.1.6.1
> +++ unix.pcf    10 Apr 2006 09:09:04 -0000
>  -61,6 +61,7 
>  # Add in the XVideo lib if we are on linux and not
building the mini
>  # site. Right now I have only turned on XVideo for
linux.
>  if( ('HELIX_FEATURE_MINI_SITE' not in
project.defines) and
> -    (platform.name in ('linux2', 'linux-i386',
'sunos5'))):
> +    (platform.name in ('linux2', 'linux-i386')) or
> +     (id == 'sunos-5.10-i386-studio11')):
>            project.sys_libraries.append('Xv')
>
>>
>>>
============================================================
=======
>>> RCS file: /cvsroot/video/site/unix.pcf,v
>>> retrieving revision 1.3.10.1
>>> diff -u -w -r1.3.10.1 unix.pcf
>>> --- site/unix.pcf    9 Jul 2004 01:59:40 -0000 
  1.3.10.1
>>> +++ site/unix.pcf    4 Apr 2006 01:22:19 -0000
>>>  -61,6 +61,6 
>>> # Add in the XVideo lib if we are on linux and
not building the mini
>>> # site. Right now I have only turned on XVideo
for linux.
>>> if( ('HELIX_FEATURE_MINI_SITE' not in
project.defines) and
>>> -    (platform.name in ('linux2',
'linux-i386'))):
>>> +    (platform.name in ('linux2',
'linux-i386', 'sunos5'))):
>>>           project.sys_libraries.append('Xv')
>>>
>>
>> If you only want to turn XVideo on for
sunos-5.10-i386-studio11.cf
>> builds, it seems that you would need to have
something other
>> then 'sunos5' there. Doesn't sunos5 represent a
lot more then
>> just Sudio 11 x86 builds? Perhaps you need
sunos-5.10-i386 instead?
>>
>>>
>>> Branch: hxclient_1_4_4_neptunex
>>> it may need to check into 133 .
>>
>>
>>
>> You need to check this into 133NepX and HEAD.
>>
>> --greg.
>>
>>>
>>> Copyright assignment:
>>> 1. My company (sun.com) submits this code under
the terms
>>> of a commercial contribution agreement with
RealNetworks,
>>> and I am authorized to contribute this code
under said agreement.
>>>
>>>
>>>
------------------------------------------------------------
------------ 
>>>
>>>
>>> _______________________________________________
>>> Porting-solaris mailing list
>>> Porting-solarishelixcommunity.org
>>> http://lists.helixcommunity.org/mailman/listinfo
/porting-solaris
>>
>>
>>
>> _______________________________________________
>> Porting-solaris mailing list
>> Porting-solarishelixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo
/porting-solaris
>
>
>
>


_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev

Yes, this looks good.

--Bob

On Apr 10, 2006, at 10:57 PM, Jerry Tan wrote:

> Is it ok for me to checkin?
>
>
> jerry tan wrote:
>
>> Greg,  you are right,
>> I  consider this patch again, I have to add
system_id check here,
>> or other SYSTEM_ID on solaris build may break.
>>
>>
>> Here is the patch.
>>
>> Index: unix.pcf
>>
============================================================
=======
>> RCS file: /cvsroot/video/site/unix.pcf,v
>> retrieving revision 1.3.10.1.6.1
>> diff -u -w -r1.3.10.1.6.1 unix.pcf
>> --- unix.pcf    6 Apr 2006 07:52:00 -0000      
1.3.10.1.6.1
>> +++ unix.pcf    10 Apr 2006 09:09:04 -0000
>>  -61,6 +61,7 
>>  # Add in the XVideo lib if we are on linux and not
building the mini
>>  # site. Right now I have only turned on XVideo for
linux.
>>  if( ('HELIX_FEATURE_MINI_SITE' not in
project.defines) and
>> -    (platform.name in ('linux2', 'linux-i386',
'sunos5'))):
>> +    (platform.name in ('linux2',
'linux-i386')) or
>> +     (id == 'sunos-5.10-i386-studio11')):
>>            project.sys_libraries.append('Xv')
>>
>>>
>>>>
============================================================
=======
>>>> RCS file: /cvsroot/video/site/unix.pcf,v
>>>> retrieving revision 1.3.10.1
>>>> diff -u -w -r1.3.10.1 unix.pcf
>>>> --- site/unix.pcf    9 Jul 2004 01:59:40
-0000    1.3.10.1
>>>> +++ site/unix.pcf    4 Apr 2006 01:22:19
-0000
>>>>  -61,6 +61,6 
>>>> # Add in the XVideo lib if we are on linux
and not building the  
>>>> mini
>>>> # site. Right now I have only turned on
XVideo for linux.
>>>> if( ('HELIX_FEATURE_MINI_SITE' not in
project.defines) and
>>>> -    (platform.name in ('linux2',
'linux-i386'))):
>>>> +    (platform.name in ('linux2',
'linux-i386', 'sunos5'))):
>>>>          
project.sys_libraries.append('Xv')
>>>>
>>>
>>> If you only want to turn XVideo on for
sunos-5.10-i386-studio11.cf
>>> builds, it seems that you would need to have
something other
>>> then 'sunos5' there. Doesn't sunos5
represent a lot more then
>>> just Sudio 11 x86 builds? Perhaps you need
sunos-5.10-i386 instead?
>>>
>>>>
>>>> Branch: hxclient_1_4_4_neptunex
>>>> it may need to check into 133 .
>>>
>>>
>>>
>>> You need to check this into 133NepX and HEAD.
>>>
>>> --greg.
>>>
>>>>
>>>> Copyright assignment:
>>>> 1. My company (sun.com) submits this code
under the terms
>>>> of a commercial contribution agreement with
RealNetworks,
>>>> and I am authorized to contribute this code
under said agreement.
>>>>
>>>>
>>>>
------------------------------------------------------------
------- 
>>>> -----
>>>>
>>>>
_______________________________________________
>>>> Porting-solaris mailing list
>>>> Porting-solarishelixcommunity.org
>>>> http://lists.helixcommunity.org/mailman/listinfo
/porting-solaris
>>>
>>>
>>>
>>> _______________________________________________
>>> Porting-solaris mailing list
>>> Porting-solarishelixcommunity.org
>>> http://lists.helixcommunity.org/mailman/listinfo
/porting-solaris
>>
>>
>>
>>
>
>
> _______________________________________________
> Porting-solaris mailing list
> Porting-solarishelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo
/porting-solaris


_______________________________________________
Player-dev mailing list
Player-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/play
er-dev