CN: Java MMAPI sending clip rect larger thanwindows rect

Thanks Greg for review.
changes committed to Head and 210Cays, with suggested log
level.

BR,
 Carol.

-----Original Message-----
From: clientapps-dev-bounceshelixcommunity.org
[mailto:clientapps-dev-bounceshelixcommunity.org] On
Behalf Of ext Greg
Wright
Sent: Monday, June 26, 2006 12:22 PM
To: Chen Carol.I (Nokia-TP-MSW/Dallas)
Cc: clientapps-devhelixcommunity.org
Subject: Re: [Clientapps-dev] CR: Java MMAPI sending clip
rect larger
thanwindows rect



Carol.i.Chennokia.com wrote:
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with RealNetworks, and I am authorized to
contribute this 
> code under said agreement."
> 
> Modified by:
>     carol.i.chennokia.com
> 
> Reviewed by:
> 
> Date: 
>     6-23-2006
> 
> Error ID:
>     TSW ID=EOVL-6PLM6X, EOVL-6PLT4G, EOVL-6PLTA4,
EOVL-6PTTW2
> 
> Project: 
>     Helix plugin for Symbian
> 
> Synopsis: 
> When a Java midlet tries to play a video clip with
Helix through the 
> MMAPI, sometimes it sends Clip rect that is larger than
the Windows 
> rect when it SetDisplayWindow. (It sets Clip rect to be
the whole 
> "canvas".) Depending on post processor
implementation, the end result 
> may not be correct (e.g.
> IVA
> does not support Clip rect > Windows rect). The
solution is to take 
> intersection of clip rect and windows rect.
> 
> Files Modified: 
>     clientapps\symbianMmf\hxmmfctrlimpl.cpp
> 
> Files Added: 
>     none
> 
> Image Size and Heap Use impact: 
>     minor
> 
> Platforms and Profiles Build Verified: 
>     armv5 / helix-client-s60-mmf-mdf-dsp
> 
> Platforms and Profiles Functionality verified: 
>     armv5 / helix-client-s60-mmf-mdf-dsp
> 
> Branch: 
>     hxclient_2_1_0_cayennes and HEAD
> 
> 
> 
> Index: hxmmfctrlimpl.cpp
>
============================================================
=======
> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfctrlimpl.cpp,v
> retrieving revision 1.12.2.24
> diff -u -w -r1.12.2.24 hxmmfctrlimpl.cpp
> --- hxmmfctrlimpl.cpp   25 May 2006 19:06:37 -0000     
1.12.2.24
> +++ hxmmfctrlimpl.cpp   15 Jun 2006 22:36:39 -0000
>  -1459,7 +1459,17 
>      HXLOGL1(HXLOG_SMMF,
"HXMMFCtrlImpl::MvpcSetDisplayWindowL() Clip 
> (%d %d) (%d %d)",
>          tl.iX, tl.iY, br.iX, br.iY);
> 
> -    m_pStateCtrl->SetDisplayWindow( aWindowRect,
aClipRect );
> +    // Take intersection of Window and Clip rect as
clip region
> +    TRect clipRegion = aClipRect;
> +    clipRegion.Intersection( aWindowRect );
> +
> +    tl = clipRegion.iTl;
> +    br = clipRegion.iBr;
> +
> +    HXLOGL1(HXLOG_SMMF,
"HXMMFCtrlImpl::MvpcSetDisplayWindowL() Clip
> after intersection (%d %d) (%d %d)",
> +        tl.iX, tl.iY, br.iX, br.iY);

I am not sure you want that to be a Log Level 1, seems like
it would
fire a lot in release builds. Maybe a L3?

The rest looks good.

--greg.

> +
> +    m_pStateCtrl->SetDisplayWindow( aWindowRect,
clipRegion );
> 
>  }
> 
> 
> 
> 
>
------------------------------------------------------------
----------
> --
> 
> _______________________________________________
> Clientapps-dev mailing list
> Clientapps-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev