CN: SymbianMMF - API MvcGetAudioCodecL does notreturn proper FourCC code

Thanks Eric !

The changes are committed to Head and 210CayS.


-Rajesh. 

>-----Original Message-----
>From: ext Eric Hyche [mailto:ehychereal.com]

>Sent: Friday, July 07, 2006 8:14 AM
>To: Rathinasamy Rajesh (Nokia-TP-MSW/Dallas); 
>clientapps-devhelixcommunity.org
>Subject: RE: [Clientapps-dev] CR: SymbianMMF - API 
>MvcGetAudioCodecL does notreturn proper FourCC code
>
>
>Rajesh,
>
>These changes look good.
>
>Eric 
>
>> -----Original Message-----
>> From: clientapps-dev-bounceshelixcommunity.org
>> [mailto:clientapps-dev-bounceshelixcommunity.org] On Behalf Of 
>> rajesh.rathinasamynokia.com
>> Sent: Thursday, July 06, 2006 8:20 PM
>> To: clientapps-devhelixcommunity.org
>> Subject: [Clientapps-dev] CR: SymbianMMF - API 
>MvcGetAudioCodecL does 
>> notreturn proper FourCC code
>> 
>> "Nokia submits this code under the terms of a
commercial 
>contribution 
>> agreement with RealNetworks, and I am authorized to
contribute this 
>> code under said agreement."
>> 
>> 	Modified by:  rajesh.rathinasamynokia.com
>> 
>> 	Reviewed by: 
>> 
>> 	Date: 06-Jul-2006. 
>> 
>> 	Project: Helix Symbian player
>> 
>> 	ErrorId: EOVL-6PGKBZ
>> 
>> 	Synopsis:  API MvcGetAudioCodecL does not return
proper 
>FourCC code
>> 
>> 	Two problems were identified in the code. 
>> 
>> 	* Mapping check for FourCC was not checked for
HXR_OK 
>which resulted 
>> in comparison failure for all cases.
>> 
>> 	* The Mapping object used for storing FourCC map
was 
>making a case 
>> sensitive comparison on the keys. Changed it to
make case 
>insensitive 
>> and used specific string to ULONG mapping rather
than keyvalue list.
>> 
>> 
>> 	Files Modified: 
>> 	=========== 
>> 	clientapps/symbianMmf/hxmmfctrlimpl.cpp 
>> 	clientapps/symbianMmf/hxmmffourccmap.cpp 
>> 	clientapps/symbianMmf/hxmmffourccmap.h 
>> 
>> 	Image Size and Heap Use impact: Minor 
>> 
>> 	Platforms and Profiles Build Verified: 
>> helix-client-s60-mmf-mdf-arm 
>> 
>> 	Platforms and Profiles Functionality verified:
armv5 
>> 
>>      Branch: Helix, 210CayS 
>> 
>> Index: hxmmfctrlimpl.cpp 
>>
============================================================
======= 
>> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfctrlimpl.cpp,v 
>> retrieving revision 1.12.2.26 
>> diff -w -u -b -r1.12.2.26 hxmmfctrlimpl.cpp 
>> --- hxmmfctrlimpl.cpp   26 Jun 2006 17:58:22 -0000 
    1.12.2.26 
>> +++ hxmmfctrlimpl.cpp   6 Jul 2006 15:18:24 -0000 
>>  -1640,6 +1640,7  
>>          
>>          m_pMetaData->FindStreamValueByName(
"Video", 
>> "MimeType", mimeType ); 
>>          
>> +        aCodec.Set(0); 
>>          m_fourCcMap.Map(mimeType, aCodec); 
>>      } 
>>      else 
>>  -1658,6 +1659,7  
>>      { 
>>          CHXString mimeType; 
>>          
>> +        aCodec.Set(0); 
>>          m_pMetaData->FindStreamValueByName(
"Audio", 
>> "MimeType", mimeType ); 
>>          
>>          m_fourCcMap.Map(mimeType, aCodec); 
>> Index: hxmmffourccmap.cpp 
>>
============================================================
======= 
>> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmffourccmap.cpp,v 
>> retrieving revision 1.1.1.1 
>> diff -w -u -b -r1.1.1.1 hxmmffourccmap.cpp 
>> --- hxmmffourccmap.cpp  30 Sep 2005 21:47:44 -0000 
    1.1.1.1 
>> +++ hxmmffourccmap.cpp  6 Jul 2006 15:18:24 -0000 
>>  -75,7 +75,7  
>>  { 
>>      unsigned long code = 0L; 
>>   
>> -    if ( m_mapping.GetPropertyULONG32(pKey, code)
) 
>> +    if ( m_FourCCMap.GetProperty(pKey, code) ==
HXR_OK) 
>>      { 
>>          aType = TFourCC(code); 
>>      } 
>>  -138,6 +138,6  
>>      for ( int i=0 ; MMFCodesFourCC[i] != 0 ; i++ )

>>      { 
>>          CHXString str(MMFCodesMimeTypes[i]); 
>> -        m_mapping.SetPropertyULONG32(str,
MMFCodesFourCC[i]); 
>> +        m_FourCCMap.SetProperty(str,
MMFCodesFourCC[i]); 
>>      } 
>>  } 
>> Index: hxmmffourccmap.h 
>>
============================================================
======= 
>> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmffourccmap.h,v 
>> retrieving revision 1.1.1.1 
>> diff -w -u -b -r1.1.1.1 hxmmffourccmap.h 
>> --- hxmmffourccmap.h    30 Sep 2005 21:47:44 -0000 
    1.1.1.1 
>> +++ hxmmffourccmap.h    6 Jul 2006 15:18:24 -0000 
>>  -76,7 +76,7  
>>      private: 
>>          void Initialize(); 
>>   
>> -        CHXUniquelyKeyedList m_mapping; 
>> +        CSimpleUlongMapStrCaseCmp m_FourCCMap; 
>>  }; 
>>   
>>  #endif _HX_MMF_FOURCC_MAP_H_ 
>> 
>> 
>> 
>
>

_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev