List Info

Thread: CR Add mapping for corrupt files and correct hxmmfmetadata.cpp to compile with CW
CR Add mapping for corrupt files and correct hxmmfmetadata.cpp to compile with CW
user name
 2006-07-27 15:18:23 
"Nokia submits this code under the terms of a
commercial contribution
agreement with Real Networks, and I am authorized to
contribute this
code under said agreement."

Modified by:
    Sunitha.Ramakrishnanokia.com

Reviewed by:


Date: 
    July-26-2006

Project: 
    Helix plug-in for Symbian

Error ID: ELFG_6RE7V3
          EOVL-6PHU5T  
    
Synopsis: 

When Helix returns HXR_CORRUPT for corrupted files, the
mmfcontroller
was not mapping this to an appropriate Symbian error code
understood by
the UI. This CR adds a mapping for HXR_CORRUPT to
KErrCorrupt.

This CR also corrects a compile error for CodeWarrior by
changing TInt32
to Tint
		

Files Modified: 
    clientapps\symbianMmf\hxmmfctrlimpl.cpp
    clientapps\symabianMmf\hxmmfmetadata.cpp
   
    
Files Added:
    None

Image Size and Heap Use impact: 
    None

Platforms and Profiles Build Verified: 
    helix-client-s60-mmf-mdf-arm
    helix-client-s60-mmf-mdf-dsp

Platforms and Profiles Functionality verified: 
    armv5
    winscw

Branch: 
    head and hxclient_2_1_0_cayennes 

Index: hxmmfctrlimpl.cpp
============================================================
=======
RCS file: /cvsroot/clientapps/symbianMmf/hxmmfctrlimpl.cpp,v
retrieving revision 1.12.2.30
diff -w -u -b -r1.12.2.30 hxmmfctrlimpl.cpp
--- hxmmfctrlimpl.cpp	26 Jul 2006 19:54:11 -0000	1.12.2.30
+++ hxmmfctrlimpl.cpp	27 Jul 2006 15:16:17 -0000
 -180,6
+180,7 
     { HXR_SET_SECURE_OUT_FAIL,    KErrNotSupported        
},
     { HXR_DEVVIDEO_FATAL_ERROR,   KErrMMVideoDevice       
},
     { HXR_CLOSED,                 KErrSessionClosed       
},
+    { HXR_CORRUPT_FILE,           KErrCorrupt             
},
     { HXR_SOCK_DISCON,            KErrDisconnected        
}
     	
 };
Index: hxmmfmetadata.cpp
============================================================
=======
RCS file: /cvsroot/clientapps/symbianMmf/hxmmfmetadata.cpp,v
retrieving revision 1.5.2.6
diff -w -u -b -r1.5.2.6 hxmmfmetadata.cpp
--- hxmmfmetadata.cpp	26 Jul 2006 19:54:37 -0000	1.5.2.6
+++ hxmmfmetadata.cpp	27 Jul 2006 15:16:17 -0000
 -277,7
+277,7 
     
     TInt numElements = m_metaData.Nelements();
     
-    for ( TInt32 idx=0; idx < numElements; ++idx)
+    for ( TInt idx=0; idx < numElements; ++idx)
     {
         
      	CMMFMetaDataEntry* pEntry = m_metaData[idx];
 -301,7
+301,7 
    
     TInt numElements = m_metaData.Nelements();
     
-    for ( TInt32 idx=0; idx < numElements; ++idx)
+    for ( TInt idx=0; idx < numElements; ++idx)
     {
         
         CMMFMetaDataEntry* pEntry = m_metaData[idx];       


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
CR Add mapping for corrupt files and correcthxmmfmetadata.cpp to compile with CW
user name
 2006-07-27 15:43:19 
Looks good
Please check in to HEAD and 210CayS
-Thanks
Anshuman 
 

>-----Original Message-----
>From: clientapps-dev-bounceshelixcommunity.org 
>[mailto:clientapps-dev-bounceshelixcommunity.org] 
>Sent: Thursday, July 27, 2006 10:18 AM
>To: clientapps-devhelixcommunity.org; 
>porting-symbianhelixcommunity.org
>Subject: [Clientapps-dev] Re: CR Add mapping for corrupt
files 
>and correcthxmmfmetadata.cpp to compile with CW
>
>"Nokia submits this code under the terms of a
commercial 
>contribution agreement with Real Networks, and I am
authorized 
>to contribute this code under said agreement."
>
>Modified by:
>    Sunitha.Ramakrishnanokia.com
>
>Reviewed by:
>
>
>Date: 
>    July-26-2006
>
>Project: 
>    Helix plug-in for Symbian
>
>Error ID: ELFG_6RE7V3
>          EOVL-6PHU5T  
>    
>Synopsis: 
>
>When Helix returns HXR_CORRUPT for corrupted files, the 
>mmfcontroller was not mapping this to an appropriate
Symbian 
>error code understood by the UI. This CR adds a mapping
for 
>HXR_CORRUPT to KErrCorrupt.
>
>This CR also corrects a compile error for CodeWarrior by

>changing TInt32 to Tint
>		
>
>Files Modified: 
>    clientapps\symbianMmf\hxmmfctrlimpl.cpp
>    clientapps\symabianMmf\hxmmfmetadata.cpp
>   
>    
>Files Added:
>    None
>
>Image Size and Heap Use impact: 
>    None
>
>Platforms and Profiles Build Verified: 
>    helix-client-s60-mmf-mdf-arm
>    helix-client-s60-mmf-mdf-dsp
>
>Platforms and Profiles Functionality verified: 
>    armv5
>    winscw
>
>Branch: 
>    head and hxclient_2_1_0_cayennes 
>
>Index: hxmmfctrlimpl.cpp
>========================================================
===========
>RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfctrlimpl.cpp,v
>retrieving revision 1.12.2.30
>diff -w -u -b -r1.12.2.30 hxmmfctrlimpl.cpp
>--- hxmmfctrlimpl.cpp	26 Jul 2006 19:54:11
-0000	1.12.2.30
>+++ hxmmfctrlimpl.cpp	27 Jul 2006 15:16:17 -0000
> -180,6 +180,7 
>     { HXR_SET_SECURE_OUT_FAIL,    KErrNotSupported     
   },
>     { HXR_DEVVIDEO_FATAL_ERROR,   KErrMMVideoDevice    
   },
>     { HXR_CLOSED,                 KErrSessionClosed    
   },
>+    { HXR_CORRUPT_FILE,           KErrCorrupt          
   },
>     { HXR_SOCK_DISCON,            KErrDisconnected     
   }
>     	
> };
>Index: hxmmfmetadata.cpp
>========================================================
===========
>RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfmetadata.cpp,v
>retrieving revision 1.5.2.6
>diff -w -u -b -r1.5.2.6 hxmmfmetadata.cpp
>--- hxmmfmetadata.cpp	26 Jul 2006 19:54:37 -0000	1.5.2.6
>+++ hxmmfmetadata.cpp	27 Jul 2006 15:16:17 -0000
> -277,7 +277,7 
>     
>     TInt numElements = m_metaData.Nelements();
>     
>-    for ( TInt32 idx=0; idx < numElements; ++idx)
>+    for ( TInt idx=0; idx < numElements; ++idx)
>     {
>         
>      	CMMFMetaDataEntry* pEntry = m_metaData[idx];  -301,7
+301,7 
>    
>     TInt numElements = m_metaData.Nelements();
>     
>-    for ( TInt32 idx=0; idx < numElements; ++idx)
>+    for ( TInt idx=0; idx < numElements; ++idx)
>     {
>         
>         CMMFMetaDataEntry* pEntry = m_metaData[idx];   
    
>
>_______________________________________________
>Clientapps-dev mailing list
>Clientapps-devhelixcommunity.org
>http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
>

_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
CR Add mapping for corrupt files and correct hxmmfmetadata.cpp to compile with CW
user name
 2006-07-27 17:57:12 
Looks good.
--greg.


Sunitha.Ramakrishnanokia.com wrote:
> "Nokia submits this code under the terms of a
commercial contribution
> agreement with Real Networks, and I am authorized to
contribute this
> code under said agreement."
> 
> Modified by:
>     Sunitha.Ramakrishnanokia.com
> 
> Reviewed by:
> 
> 
> Date: 
>     July-26-2006
> 
> Project: 
>     Helix plug-in for Symbian
> 
> Error ID: ELFG_6RE7V3
>           EOVL-6PHU5T  
>     
> Synopsis: 
> 
> When Helix returns HXR_CORRUPT for corrupted files, the
mmfcontroller
> was not mapping this to an appropriate Symbian error
code understood by
> the UI. This CR adds a mapping for HXR_CORRUPT to
KErrCorrupt.
> 
> This CR also corrects a compile error for CodeWarrior
by changing TInt32
> to Tint
> 		
> 
> Files Modified: 
>     clientapps\symbianMmf\hxmmfctrlimpl.cpp
>     clientapps\symabianMmf\hxmmfmetadata.cpp
>    
>     
> Files Added:
>     None
> 
> Image Size and Heap Use impact: 
>     None
> 
> Platforms and Profiles Build Verified: 
>     helix-client-s60-mmf-mdf-arm
>     helix-client-s60-mmf-mdf-dsp
> 
> Platforms and Profiles Functionality verified: 
>     armv5
>     winscw
> 
> Branch: 
>     head and hxclient_2_1_0_cayennes 
> 
> Index: hxmmfctrlimpl.cpp
>
============================================================
=======
> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfctrlimpl.cpp,v
> retrieving revision 1.12.2.30
> diff -w -u -b -r1.12.2.30 hxmmfctrlimpl.cpp
> --- hxmmfctrlimpl.cpp	26 Jul 2006 19:54:11
-0000	1.12.2.30
> +++ hxmmfctrlimpl.cpp	27 Jul 2006 15:16:17 -0000
>  -180,6 +180,7 
>      { HXR_SET_SECURE_OUT_FAIL,    KErrNotSupported    
    },
>      { HXR_DEVVIDEO_FATAL_ERROR,   KErrMMVideoDevice   
    },
>      { HXR_CLOSED,                 KErrSessionClosed   
    },
> +    { HXR_CORRUPT_FILE,           KErrCorrupt         
    },
>      { HXR_SOCK_DISCON,            KErrDisconnected    
    }
>      	
>  };
> Index: hxmmfmetadata.cpp
>
============================================================
=======
> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfmetadata.cpp,v
> retrieving revision 1.5.2.6
> diff -w -u -b -r1.5.2.6 hxmmfmetadata.cpp
> --- hxmmfmetadata.cpp	26 Jul 2006 19:54:37
-0000	1.5.2.6
> +++ hxmmfmetadata.cpp	27 Jul 2006 15:16:17 -0000
>  -277,7 +277,7 
>      
>      TInt numElements = m_metaData.Nelements();
>      
> -    for ( TInt32 idx=0; idx < numElements; ++idx)
> +    for ( TInt idx=0; idx < numElements; ++idx)
>      {
>          
>       	CMMFMetaDataEntry* pEntry = m_metaData[idx];
>  -301,7 +301,7 
>     
>      TInt numElements = m_metaData.Nelements();
>      
> -    for ( TInt32 idx=0; idx < numElements; ++idx)
> +    for ( TInt idx=0; idx < numElements; ++idx)
>      {
>          
>          CMMFMetaDataEntry* pEntry = m_metaData[idx];  
     
> 
> _______________________________________________
> Porting-symbian mailing list
> Porting-symbianhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo
/porting-symbian
> 

_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
CN Add mapping for corrupt files and correct hxmmfmetadata.cpp to compile with CW
user name
 2006-07-27 18:22:07 
 
Thanks Greg,

Files have been checked into both HEAD and CAY210S
-----Original Message-----
From: ext Greg Wright [mailto:gwrightreal.com] 
Sent: Thursday, July 27, 2006 12:57 PM
To: Ramakrishna Sunitha (Nokia-TP-MSW/Dallas)
Cc: clientapps-devhelixcommunity.org;
porting-symbianhelixcommunity.org
Subject: Re: [Porting-symbian] Re: CR Add mapping for
corrupt files and
correct hxmmfmetadata.cpp to compile with CW

Looks good.
--greg.


Sunitha.Ramakrishnanokia.com wrote:
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with Real Networks, and I am authorized to
contribute this 
> code under said agreement."
> 
> Modified by:
>     Sunitha.Ramakrishnanokia.com
> 
> Reviewed by:
> 
> 
> Date: 
>     July-26-2006
> 
> Project: 
>     Helix plug-in for Symbian
> 
> Error ID: ELFG_6RE7V3
>           EOVL-6PHU5T
>     
> Synopsis: 
> 
> When Helix returns HXR_CORRUPT for corrupted files, the
mmfcontroller 
> was not mapping this to an appropriate Symbian error
code understood 
> by the UI. This CR adds a mapping for HXR_CORRUPT to
KErrCorrupt.
> 
> This CR also corrects a compile error for CodeWarrior
by changing 
> TInt32 to Tint
> 		
> 
> Files Modified: 
>     clientapps\symbianMmf\hxmmfctrlimpl.cpp
>     clientapps\symabianMmf\hxmmfmetadata.cpp
>    
>     
> Files Added:
>     None
> 
> Image Size and Heap Use impact: 
>     None
> 
> Platforms and Profiles Build Verified: 
>     helix-client-s60-mmf-mdf-arm
>     helix-client-s60-mmf-mdf-dsp
> 
> Platforms and Profiles Functionality verified: 
>     armv5
>     winscw
> 
> Branch: 
>     head and hxclient_2_1_0_cayennes
> 
> Index: hxmmfctrlimpl.cpp
>
============================================================
=======
> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfctrlimpl.cpp,v
> retrieving revision 1.12.2.30
> diff -w -u -b -r1.12.2.30 hxmmfctrlimpl.cpp
> --- hxmmfctrlimpl.cpp	26 Jul 2006 19:54:11
-0000	1.12.2.30
> +++ hxmmfctrlimpl.cpp	27 Jul 2006 15:16:17 -0000
>  -180,6 +180,7 
>      { HXR_SET_SECURE_OUT_FAIL,    KErrNotSupported    
    },
>      { HXR_DEVVIDEO_FATAL_ERROR,   KErrMMVideoDevice   
    },
>      { HXR_CLOSED,                 KErrSessionClosed   
    },
> +    { HXR_CORRUPT_FILE,           KErrCorrupt         
    },
>      { HXR_SOCK_DISCON,            KErrDisconnected    
    }
>      	
>  };
> Index: hxmmfmetadata.cpp
>
============================================================
=======
> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfmetadata.cpp,v
> retrieving revision 1.5.2.6
> diff -w -u -b -r1.5.2.6 hxmmfmetadata.cpp
> --- hxmmfmetadata.cpp	26 Jul 2006 19:54:37
-0000	1.5.2.6
> +++ hxmmfmetadata.cpp	27 Jul 2006 15:16:17 -0000
>  -277,7 +277,7 
>      
>      TInt numElements = m_metaData.Nelements();
>      
> -    for ( TInt32 idx=0; idx < numElements; ++idx)
> +    for ( TInt idx=0; idx < numElements; ++idx)
>      {
>          
>       	CMMFMetaDataEntry* pEntry = m_metaData[idx];
 -301,7
+301,7 
> 
>     
>      TInt numElements = m_metaData.Nelements();
>      
> -    for ( TInt32 idx=0; idx < numElements; ++idx)
> +    for ( TInt idx=0; idx < numElements; ++idx)
>      {
>          
>          CMMFMetaDataEntry* pEntry = m_metaData[idx];  
     
> 
> _______________________________________________
> Porting-symbian mailing list
> Porting-symbianhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo
/porting-symbian
> 

_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )