CR:HxMmfStateCtrl crashes on QIwhenm_pClientEngine is NULL.

---

From: clientapps-dev-bounceshelixcommunity.org [mailto:clientapps-dev-bounceshelixcommunity.org]
Sent: Saturday, November 11, 2006 1:16 PM
To: clientapps-dev-bounceshelixcommunity.org; clientapps-devhelixcommunity.org
Subject: RE: [Clientapps-dev] CR:HxMmfStateCtrl crashes on QIwhenm_pClientEngine is NULL.

Hi Ashish

This looks good for HEAD and 210 CayS

- Thanks

Anshuman

 

---

From: clientapps-dev-bounceshelixcommunity.org [mailto:clientapps-dev-bounceshelixcommunity.org]
Sent: Saturday, November 11, 2006 11:45 AM
To: clientapps-devhelixcommunity.org
Subject: [Clientapps-dev] CR:HxMmfStateCtrl crashes on QI whenm_pClientEngine is NULL.

HxMmfStateCtrl crashes on QI when m_pClientEngine is NULL.

"Nokia submits this code under the terms of a commercial contribution agreement
with RealNetworks, and I am authorized to contribute this code under said agreement."

Modified by:  ashish.as.guptanokia.com

Reviewed by:

Date: 11-11-2006

Error ID: TSW ID=MPEI-6VDBT8, MPEI-6VEEYB, EYSN-6VBDCS

Project: Helix plugin for Symbian

Synopsis: HxMmfStateCtrl crashes on QI when m_pClientEngine is NULL.

Files Modified:

Check if m_pClientEngine is NULL.. This happens when we exit in the pause state.

clientapps/symbianMmf/hxmmfstatectrl.cpp

Files Added: None.

Image Size and Heap Use impact: None

Platforms and Profiles Build Verified: helix-client-s60-32-mmf-mdf-arm

Platforms and Profiles Functionality verified: winscw, armv5

Branch: head, hxclient_2_1_0_cayennes

? Makefile
? MmfCtrlLib.mak
? MmfCtrlLib.upp
? Umakefil.upp
? armv5-rel32
? clientapp_symbianMmf_diff.txt
? hxmmfstatectrl.cpp.fixed
? ribosome_logs
? rm.exe.stackdump
? audiocontroller/Makefile
? audiocontroller/Umakefil.upp
? audiocontroller/armv5-rel32
? audiocontroller/controllerdll.mak
? audiocontroller/controllerdll.upp
? audiocontroller/controllersis.mak
? audiocontroller/controllersis.upp
? audiocontroller/copyDlls.bat
? audiocontroller/hxaudio-s60-mmf.pkg
? audiocontroller/hxaudio-s60-mmf.sis
? audiocontroller/hxmmfaudioctrl{000a0000}.def
? common/Makefile
? common/Umakefil.upp
? common/armv5-rel32
? videocontroller/Makefile
? videocontroller/MmfCtrlDll.mak
? videocontroller/MmfCtrlDll.upp
? videocontroller/MmfSis.mak
? videocontroller/MmfSis.upp
? videocontroller/Umakefil.upp
? videocontroller/armv5-rel32
? videocontroller/copyDlls.bat
? videocontroller/hxmmfctrl{000a0000}.def
? videocontroller/mmfplayer-s60-mmf.pkg
? videocontroller/mmfplayer-s60-mmf.sis
Index: hxmmfstatectrl.cpp
===================================================================
RCS file: /cvsroot/clientapps/symbianMmf/hxmmfstatectrl.cpp,v
retrieving revision 1.4.2.15
diff -u -w -r1.4.2.15 hxmmfstatectrl.cpp
--- hxmmfstatectrl.cpp  3 Nov 2006 20:58:22 -0000 ;      1.4.2.15
+++ hxmmfstatectrl.cpp  11 Nov 2006 05:38:41 -0000
-85,7 +85,8
     {
         return m_pCCF->;QueryInterface(riid, ppvObj);
     }
-
+    else if ( m_pClientEngine )
+    {
     //
     //  If the interface has not been found, check the engine for the interface
     //  This should be the last option for the QueryInterface
-93,6 +94,10
     return m_pClientEngine->QueryInterface(riid, ppvObj);
 }
 
+    *ppvObj = NULL;
+    return HXR_NOINTERFACE;
+}
+
 STDMETHODIMP
 HXMMFStateCtrl::OnPosLength(UINT32 ulPosition, UINT32 ulLength)
 {