CR: Memory leak for an invalid clip on Symbian

Looks good.
--greg.

rajesh.rathinasamynokia.com wrote:
> 		"Nokia submits this code under the terms of a
commercial
> contribution agreement with RealNetworks, and I am
authorized to
> contribute this code under said agreement."
> 
> 			Modified by:  rajesh.rathinasamynokia.com
> 
> 			Reviewed by: 
> 
> 			Date: 25-Jan-2007
> 
> 			Project: SymbianMmf
> 
> 			ErrorId:  NRRR-6X9CBQ
> 
> 			Synopsis:  CR: Memory leak for an invalid clip
> 
> 			When using an invalid clip from video gallery,
> clip region was not closed.
> 
> 			Invalid clip resulted in DevVideo fatal error
> resulting in DevVideo Shutdown and clip region was
closed. The app send
> an update region which sets the region value again and
during
> destrcution of mdfdevvideo, clip regoin was not closed
again. 
> 
> 			Solution: Move closing of region to destructor
> instead of Shutdown call. Also added a check on context
on the fatal
> error callback
> 
> 			Root Cause of the problem:  Implementation phase
> 			  
> 			Files Modified:
> 			clientapps/symbianMmf/common/hxmmfbasectrl.cpp
> 			clientapps/symbianMmf/common/hxmmfbasectrl.h
> 	
>
clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp
> 			datatype/mdf/video/renderer/mdfvideoadapter.cpp
> 
> 			Image Size and Heap Use impact: no major impact
> 
> 			Module Release testing (STIF) :  Pass 
> 
> 			Test case(s) Added  :  No. The problem is seen
> when used with media gallery and not when used with
media player.  
> 
> 			Memory leak check performed : Yes.  No new leaks
> introduced.  
> 
> 			Platforms and Profiles Build Verified:
> helix-client-s60-32-mmf-mdf-arm
> 
> 			Platforms and Profiles Functionality verified:
> armv5, winscw 
> 
> 		      Branch: Head & 210CayS
> 
> 
>  <<cvs_diff.txt>> 
> 
> 
> 
>
------------------------------------------------------------
------------
> 
> _______________________________________________
> Datatype-dev mailing list
> Datatype-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

Thanks Greg !

The changes have been checked into Head and 210CayS

- Rajesh.
 

>-----Original Message-----
>From: ext Greg Wright [mailto:gwrightreal.com]

>Sent: Friday, January 26, 2007 2:13 PM
>To: Rathinasamy Rajesh (Nokia-TP-MSW/Dallas)
>Cc: datatype-devhelixcommunity.org; clientapps-devhelixcommunity.org
>Subject: Re: [datatype-dev] CR: Memory leak for an
invalid 
>clip on Symbian
>
>Looks good.
>--greg.
>
>rajesh.rathinasamynokia.com wrote:
>> 		"Nokia submits this code under the terms of
a 
>commercial 
>> contribution agreement with RealNetworks, and I am
authorized to 
>> contribute this code under said agreement."
>> 
>> 			Modified by:  rajesh.rathinasamynokia.com
>> 
>> 			Reviewed by: 
>> 
>> 			Date: 25-Jan-2007
>> 
>> 			Project: SymbianMmf
>> 
>> 			ErrorId:  NRRR-6X9CBQ
>> 
>> 			Synopsis:  CR: Memory leak for an invalid clip
>> 
>> 			When using an invalid clip from video 
>gallery, clip region was not 
>> closed.
>> 
>> 			Invalid clip resulted in DevVideo fatal 
>error resulting in DevVideo 
>> Shutdown and clip region was closed. The app send
an update region 
>> which sets the region value again and during
destrcution of 
>> mdfdevvideo, clip regoin was not closed again.
>> 
>> 			Solution: Move closing of region to 
>destructor instead of Shutdown 
>> call. Also added a check on context on the fatal
error callback
>> 
>> 			Root Cause of the problem:  Implementation
phase
>> 			  
>> 			Files Modified:
>> 			clientapps/symbianMmf/common/hxmmfbasectrl.cpp
>> 			clientapps/symbianMmf/common/hxmmfbasectrl.h
>> 	
>>
clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp
>> 			datatype/mdf/video/renderer/mdfvideoadapter.cpp
>> 
>> 			Image Size and Heap Use impact: no major impact
>> 
>> 			Module Release testing (STIF) :  Pass
>> 
>> 			Test case(s) Added  :  No. The problem 
>is seen when used with media 
>> gallery and not when used with media player.
>> 
>> 			Memory leak check performed : Yes.  No 
>new leaks introduced.
>> 
>> 			Platforms and Profiles Build Verified:
>> helix-client-s60-32-mmf-mdf-arm
>> 
>> 			Platforms and Profiles Functionality verified:
>> armv5, winscw
>> 
>> 		      Branch: Head & 210CayS
>> 
>> 
>>  <<cvs_diff.txt>>
>> 
>> 
>> 
>> 
>--------------------------------------------------------
--------------
>> --
>> 
>> _______________________________________________
>> Datatype-dev mailing list
>> Datatype-devhelixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
>
>

_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev