List Info

Thread: Set S60 Progressive Download Mode during MMF Prepare State




Set S60 Progressive Download Mode during MMF Prepare State
user name
2007-02-09 14:31:39

Modified by: Arnel.Periquetnokia.com
Reviewed by:
Date: 02-09-2007
Project: Helix plugin for Symbian
ErrorId: APET-6Y9S3G
Synopsis:  Set Progressive Download Mode during Prepare State
Previously, a feature was submitted for "Progressive Download Filesystem Plugin for Series 60 ". In that feature, the Symbian MMF plugin puts itself into "progressive download mode" in the AddDataSource method(), after a "download ID" is received via a CustomCommand. This would result in the progressive download filesystem being loaded. Two changes are made.

(1) We now move the progressive download detection code from the AddDataSource method() to the Prepare() method to ensure the CustomCommand is received first.

(2) In the mp4 file format atomizer, the following proposed code was changed
        from...
        #if defined(HELIX_FEATURE_PROGDOWN)
   ;             && m_bPreferLinearAccess == FALSE
        #endif // HELIX_FEATURE_PROGDOWN
        #if defined(HELIX_FEATURE_S60_PROGDOWN)
      ;          && m_bPreferLinearAccess == FALSE
        #endif // HELIX_FEATURE_S60_PROGDOWN
  ;      to…
   ;     #if defined(HELIX_FEATURE_PROGDOWN) || defined(HELIX_FEATURE_S60_PROGDOWN)
      ;          && m_bPreferLinearAccess == FALSE
        #endif // HELIX_FEATURE_PROGDOWN || HELIX_FEATURE_S60_PROGDOWN
However, the streamlined version does not behave properly when compiled under CodeWarrior. So, the code is now reverted to its original proposed form.

Root Cause: These problems were revealed during integration testing. Module-level testing did not reveal the problems.
Files Modified:
Clientapps/symbianMmf/common/hxmmfbasectrl.cpp
Clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp
Datatype/mp4/fileformat/atomizer.cpp
Image Size and Heap Use impact: minimal
Platforms and Profiles Build Verified:
Armv5/helix-client-s60-mmf-mdf-arm
Armv5/helix-client-s60-mmf-mdf-dsp
Platforms and Profiles Functionality Verified:
Armv5/helix-client-s60-mmf-mdf-arm
Branch:
HEAD and Hxclient_2_1_0_cayennes
 
<<atomizer_cpp.diff>>; <<clientapps_symbianMmf.diff>>

  
  
RE: Set S60 Progressive Download Modeduring MMF Prepare State
user name
2007-02-13 10:18:52
Looks fine to me!
 
Regards,
 
Junhong


From: datatype-dev-bounceshelixcommunity.org [mailto:datatype-dev-bounceshelixcommunity.org]
Sent: Friday, February 09, 2007 2:32 PM
To: datatype-devhelixcommunity.org; clientapps-devhelixcommunity.org
Subject: [datatype-dev] [clientapps-dev] Set S60 Progressive Download Modeduring MMF Prepare State

Modified by: Arnel.Periquetnokia.com
Reviewed by:
Date: 02-09-2007
Project: Helix plugin for Symbian
ErrorId: APET-6Y9S3G
Synopsis:&nbsp; Set Progressive Download Mode during Prepare State
Previously, a feature was submitted for "Progressive Download Filesystem Plugin for Series 60 ". In that feature, the Symbian MMF plugin puts itself into "progressive download mode" in the AddDataSource method(), after a "download ID" is received via a CustomCommand. This would result in the progressive download filesystem being loaded. Two changes are made.

(1) We now move the progressive download detection code from the AddDataSource method() to the Prepare() method to ensure the CustomCommand is received first.

(2) In the mp4 file format atomizer, the following proposed code was changed
 &nbsp; &nbsp;   ; from...
 &nbsp; &nbsp;   ; #if defined(HELIX_FEATURE_PROGDOWN)
 &nbsp; &nbsp; &nbsp;   &nbsp; &nbsp; &nbsp;  && m_bPreferLinearAccess == FALSE
 &nbsp; &nbsp; &nbsp;  #endif // HELIX_FEATURE_PROGDOWN
 &nbsp; &nbsp; &nbsp;  #if defined(HELIX_FEATURE_S60_PROGDOWN)
 &nbsp; &nbsp; &nbsp;   &nbsp; &nbsp; &nbsp;  && m_bPreferLinearAccess == FALSE
 &nbsp; &nbsp; &nbsp;  #endif // HELIX_FEATURE_S60_PROGDOWN
 &nbsp; &nbsp; &nbsp;  to…
 &nbsp; &nbsp; &nbsp;  #if defined(HELIX_FEATURE_PROGDOWN) || defined(HELIX_FEATURE_S60_PROGDOWN)
 &nbsp; &nbsp; &nbsp;   &nbsp; &nbsp; &nbsp;  && m_bPreferLinearAccess == FALSE
 &nbsp; &nbsp; &nbsp;  #endif // HELIX_FEATURE_PROGDOWN || HELIX_FEATURE_S60_PROGDOWN
However, the streamlined version does not behave properly when compiled under CodeWarrior. So, the code is now reverted to its original proposed form.

Root Cause: These problems were revealed during integration testing. Module-level testing did not reveal the problems.
Files Modified:
Clientapps/symbianMmf/common/hxmmfbasectrl.cpp
Clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp
Datatype/mp4/fileformat/atomizer.cpp
Image Size and Heap Use impact: minimal
Platforms and Profiles Build Verified:
Armv5/helix-client-s60-mmf-mdf-arm
Armv5/helix-client-s60-mmf-mdf-dsp
Platforms and Profiles Functionality Verified:
Armv5/helix-client-s60-mmf-mdf-arm
Branch:
HEAD and Hxclient_2_1_0_cayennes
 
<<atomizer_cpp.diff>>; <<clientapps_symbianMmf.diff>>

RE: CN: Set S60 Progressive DownloadModeduring MMF Prepare State
user name
2007-02-13 11:28:58

Checked into HEAD and hxclient_2_1_0_cayennes.

Thanks, Arnel

 

From: clientapps-dev-bounceshelixcommunity.org [mailto:clientapps-dev-bounceshelixcommunity.org]
Sent: Tuesday, February 13, 2007 10:19 AM
To: datatype-dev-bounceshelixcommunity.org; datatype-devhelixcommunity.org; clientapps-devhelixcommunity.org
Subject: RE: [datatype-dev] [clientapps-dev] Set S60 Progressive DownloadModeduring MMF Prepare State

Looks fine to me!
 
Regards,
 
Junhong


From: datatype-dev-bounceshelixcommunity.org [mailto:datatype-dev-bounceshelixcommunity.org]
Sent: Friday, February 09, 2007 2:32 PM
To: datatype-devhelixcommunity.org; clientapps-devhelixcommunity.org
Subject: [datatype-dev] [clientapps-dev] Set S60 Progressive Download Modeduring MMF Prepare State

Modified by: Arnel.Periquetnokia.com
Reviewed by:
Date: 02-09-2007
Project: Helix plugin for Symbian
ErrorId: APET-6Y9S3G
Synopsis:&nbsp; Set Progressive Download Mode during Prepare State
Previously, a feature was submitted for "Progressive Download Filesystem Plugin for Series 60 ". In that feature, the Symbian MMF plugin puts itself into "progressive download mode" in the AddDataSource method(), after a "download ID" is received via a CustomCommand. This would result in the progressive download filesystem being loaded. Two changes are made.

(1) We now move the progressive download detection code from the AddDataSource method() to the Prepare() method to ensure the CustomCommand is received first.

(2) In the mp4 file format atomizer, the following proposed code was changed
 &nbsp; &nbsp;   ; from...
 &nbsp; &nbsp;   ; #if defined(HELIX_FEATURE_PROGDOWN)
 &nbsp; &nbsp; &nbsp;   &nbsp; &nbsp; &nbsp;  && m_bPreferLinearAccess == FALSE
 &nbsp; &nbsp; &nbsp;  #endif // HELIX_FEATURE_PROGDOWN
 &nbsp; &nbsp; &nbsp;  #if defined(HELIX_FEATURE_S60_PROGDOWN)
 &nbsp; &nbsp; &nbsp;   &nbsp; &nbsp; &nbsp;  && m_bPreferLinearAccess == FALSE
 &nbsp; &nbsp; &nbsp;  #endif // HELIX_FEATURE_S60_PROGDOWN
 &nbsp; &nbsp; &nbsp;  to…
 &nbsp; &nbsp; &nbsp;  #if defined(HELIX_FEATURE_PROGDOWN) || defined(HELIX_FEATURE_S60_PROGDOWN)
 &nbsp; &nbsp; &nbsp;   &nbsp; &nbsp; &nbsp;  && m_bPreferLinearAccess == FALSE
 &nbsp; &nbsp; &nbsp;  #endif // HELIX_FEATURE_PROGDOWN || HELIX_FEATURE_S60_PROGDOWN
However, the streamlined version does not behave properly when compiled under CodeWarrior. So, the code is now reverted to its original proposed form.

Root Cause: These problems were revealed during integration testing. Module-level testing did not reveal the problems.
Files Modified:
Clientapps/symbianMmf/common/hxmmfbasectrl.cpp
Clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp
Datatype/mp4/fileformat/atomizer.cpp
Image Size and Heap Use impact: minimal
Platforms and Profiles Build Verified:
Armv5/helix-client-s60-mmf-mdf-arm
Armv5/helix-client-s60-mmf-mdf-dsp
Platforms and Profiles Functionality Verified:
Armv5/helix-client-s60-mmf-mdf-arm
Branch:
HEAD and Hxclient_2_1_0_cayennes
 
<<atomizer_cpp.diff>>; <<clientapps_symbianMmf.diff>>

RE: Set S60 Progressive Download Modeduring MMF Prepare State
country flaguser name
United States
2007-02-15 07:56:05
These changes look good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: clientapps-dev-bounceshelixcommunity.org 
> [mailto:clientapps-dev-bounceshelixcommunity.org] On
Behalf 
> Of Arnel.Periquetnokia.com
> Sent: Friday, February 09, 2007 3:32 PM
> To: datatype-devhelixcommunity.org; clientapps-devhelixcommunity.org
> Subject: [datatype-dev] [clientapps-dev] Set S60
Progressive 
> Download Modeduring MMF Prepare State
> 
> Modified by: Arnel.Periquetnokia.com 
> Reviewed by: 
> Date: 02-09-2007 
> Project: Helix plugin for Symbian 
> ErrorId: APET-6Y9S3G 
> Synopsis:  Set Progressive Download Mode during Prepare
State 
> Previously, a feature was submitted for
"Progressive Download 
> Filesystem Plugin for Series 60 ". In that
feature, the 
> Symbian MMF plugin puts itself into "progressive
download 
> mode" in the AddDataSource method(), after a
"download ID" is 
> received via a CustomCommand. This would result in the

> progressive download filesystem being loaded. Two
changes are made.
> 
> (1) We now move the progressive download detection code
from 
> the AddDataSource method() to the Prepare() method to
ensure 
> the CustomCommand is received first.
> 
> (2) In the mp4 file format atomizer, the following
proposed 
> code was changed 
>         from... 
>         #if defined(HELIX_FEATURE_PROGDOWN) 
>                 && m_bPreferLinearAccess ==
FALSE 
>         #endif // HELIX_FEATURE_PROGDOWN 
>         #if defined(HELIX_FEATURE_S60_PROGDOWN) 
>                 && m_bPreferLinearAccess ==
FALSE 
>         #endif // HELIX_FEATURE_S60_PROGDOWN 
>         to. 
>         #if defined(HELIX_FEATURE_PROGDOWN) || 
> defined(HELIX_FEATURE_S60_PROGDOWN) 
>                 && m_bPreferLinearAccess ==
FALSE 
>         #endif // HELIX_FEATURE_PROGDOWN || 
> HELIX_FEATURE_S60_PROGDOWN 
> However, the streamlined version does not behave
properly 
> when compiled under CodeWarrior. So, the code is now
reverted 
> to its original proposed form.
> 
> Root Cause: These problems were revealed during
integration 
> testing. Module-level testing did not reveal the
problems. 
> Files Modified: 
> Clientapps/symbianMmf/common/hxmmfbasectrl.cpp 
> Clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp

> Datatype/mp4/fileformat/atomizer.cpp 
> Image Size and Heap Use impact: minimal 
> Platforms and Profiles Build Verified:
> Armv5/helix-client-s60-mmf-mdf-arm
> Armv5/helix-client-s60-mmf-mdf-dsp 
> Platforms and Profiles Functionality Verified:
> Armv5/helix-client-s60-mmf-mdf-arm 
> Branch:
> HEAD and Hxclient_2_1_0_cayennes 
>   
> <<atomizer_cpp.diff>>
<<clientapps_symbianMmf.diff>> 
> 
> 


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )